| Message ID | 20210125113557.2388311-1-arnd@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] ipa: add remoteproc dependency | expand |
On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Compile-testing without CONFIG_REMOTEPROC results in a build failure: > > >>> referenced by ipa_main.c > >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a > ld.lld: error: undefined symbol: rproc_put > >>> referenced by ipa_main.c > >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a > >>> referenced by ipa_main.c > >>> net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a > > Add a new dependency to avoid this. > Afaict this should be addressed by: 86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency") which is present in linux-next. Regards, Bjorn > Fixes: 38a4066f593c ("net: ipa: support COMPILE_TEST") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/net/ipa/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig > index b68f1289b89e..aa1c0ae3cf01 100644 > --- a/drivers/net/ipa/Kconfig > +++ b/drivers/net/ipa/Kconfig > @@ -3,6 +3,7 @@ config QCOM_IPA > depends on 64BIT && NET && QCOM_SMEM > depends on ARCH_QCOM || COMPILE_TEST > depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) > + depends on REMOTEPROC > select QCOM_MDT_LOADER if ARCH_QCOM > select QCOM_QMI_HELPERS > help > -- > 2.29.2 >
On Mon, Jan 25, 2021 at 4:23 PM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote: > > > From: Arnd Bergmann <arnd@arndb.de> > > > > Compile-testing without CONFIG_REMOTEPROC results in a build failure: > > > > >>> referenced by ipa_main.c > > >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a > > ld.lld: error: undefined symbol: rproc_put > > >>> referenced by ipa_main.c > > >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a > > >>> referenced by ipa_main.c > > >>> net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a > > > > Add a new dependency to avoid this. > > > > Afaict this should be addressed by: > > 86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency") > > which is present in linux-next. Ok, good. I was testing with next-20210122, which was still lacking that commit. Arnd
On 1/25/21 9:30 AM, Arnd Bergmann wrote: > On Mon, Jan 25, 2021 at 4:23 PM Bjorn Andersson > <bjorn.andersson@linaro.org> wrote: >> >> On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote: >> >>> From: Arnd Bergmann <arnd@arndb.de> >>> >>> Compile-testing without CONFIG_REMOTEPROC results in a build failure: >>> >>>>>> referenced by ipa_main.c >>>>>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a >>> ld.lld: error: undefined symbol: rproc_put >>>>>> referenced by ipa_main.c >>>>>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a >>>>>> referenced by ipa_main.c >>>>>> net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a >>> >>> Add a new dependency to avoid this. >>> >> >> Afaict this should be addressed by: >> >> 86fdf1fc60e9 ("net: ipa: remove a remoteproc dependency") >> >> which is present in linux-next. > > Ok, good. I was testing with next-20210122, which was > still lacking that commit. Yes, for various reasons this took a while to get incorporated. It just got accepted over the weekend. Thanks for mentioning it. -Alex > > Arnd >
diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig index b68f1289b89e..aa1c0ae3cf01 100644 --- a/drivers/net/ipa/Kconfig +++ b/drivers/net/ipa/Kconfig @@ -3,6 +3,7 @@ config QCOM_IPA depends on 64BIT && NET && QCOM_SMEM depends on ARCH_QCOM || COMPILE_TEST depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) + depends on REMOTEPROC select QCOM_MDT_LOADER if ARCH_QCOM select QCOM_QMI_HELPERS help