diff mbox series

[V2,1/4] dt-bindings: mmc: fsl-imx-esdhc: add pinctrl bindings

Message ID 1611198593-16287-2-git-send-email-peng.fan@nxp.com
State New
Headers show
Series imx esdhc dt/driver update | expand

Commit Message

Peng Fan Jan. 21, 2021, 3:09 a.m. UTC
From: Peng Fan <peng.fan@nxp.com>

Add pinctrl bindings for fsl-imx-esdhc yaml

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 .../bindings/mmc/fsl-imx-esdhc.yaml           | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

Comments

Rob Herring (Arm) Jan. 22, 2021, 4:38 p.m. UTC | #1
On Thu, Jan 21, 2021 at 11:09:50AM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>

> 

> Add pinctrl bindings for fsl-imx-esdhc yaml

> 

> Signed-off-by: Peng Fan <peng.fan@nxp.com>

> ---

>  .../bindings/mmc/fsl-imx-esdhc.yaml           | 25 +++++++++++++++++++

>  1 file changed, 25 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml

> index 802c9df23752..f91e97cd7d4e 100644

> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml

> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml

> @@ -103,6 +103,31 @@ properties:

>        Only eMMC HS400 mode need to take care of this property.

>      default: 0

>  

> +  pinctrl-0:

> +    minItems: 1

> +    maxItems: 2

> +

> +  pinctrl-1:

> +    minItems: 1

> +    maxItems: 2

> +

> +  pinctrl-2:

> +    minItems: 1

> +    maxItems: 2

> +

> +  pinctrl-3:

> +    minItems: 1

> +    maxItems: 2


You can drop these. They are automatically added and there's not 
anything additional to describe here that's useful.

> +

> +  pinctrl-names:

> +    minItems: 1

> +    maxItems: 4

> +    items:

> +      - const: default

> +      - const: state_100mhz

> +      - const: state_200mhz

> +      - const: sleep


This should stay since you are defining the names.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index 802c9df23752..f91e97cd7d4e 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -103,6 +103,31 @@  properties:
       Only eMMC HS400 mode need to take care of this property.
     default: 0
 
+  pinctrl-0:
+    minItems: 1
+    maxItems: 2
+
+  pinctrl-1:
+    minItems: 1
+    maxItems: 2
+
+  pinctrl-2:
+    minItems: 1
+    maxItems: 2
+
+  pinctrl-3:
+    minItems: 1
+    maxItems: 2
+
+  pinctrl-names:
+    minItems: 1
+    maxItems: 4
+    items:
+      - const: default
+      - const: state_100mhz
+      - const: state_200mhz
+      - const: sleep
+
 required:
   - compatible
   - reg