diff mbox series

[V9,06/10] remoteproc: imx_rproc: use devm_ioremap

Message ID 1611191015-22584-7-git-send-email-peng.fan@nxp.com
State Accepted
Commit ecadcc47492cc73a9bb92fbf16098192df514b87
Headers show
Series remoteproc: imx_rproc: support iMX8MQ/M | expand

Commit Message

Peng Fan Jan. 21, 2021, 1:03 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>


We might need to map an region multiple times, becaue the region might
be shared between remote processors, such i.MX8QM with dual M4 cores.
So use devm_ioremap, not devm_ioremap_resource.

Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>

Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

---
 drivers/remoteproc/imx_rproc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.28.0
diff mbox series

Patch

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 2a093cea4997..47fc1d06be6a 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -296,7 +296,8 @@  static int imx_rproc_addr_init(struct imx_rproc *priv,
 		if (b >= IMX7D_RPROC_MEM_MAX)
 			break;
 
-		priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
+		/* Not use resource version, because we might share region */
+		priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res));
 		if (IS_ERR(priv->mem[b].cpu_addr)) {
 			dev_err(dev, "failed to remap %pr\n", &res);
 			err = PTR_ERR(priv->mem[b].cpu_addr);