diff mbox series

[v2] ASoC: qcom: lpass: Fix i2s ctl register bit map

Message ID 20210120024955.3911891-1-jun.nie@linaro.org
State Superseded
Headers show
Series [v2] ASoC: qcom: lpass: Fix i2s ctl register bit map | expand

Commit Message

Jun Nie Jan. 20, 2021, 2:49 a.m. UTC
Fix bitwidth mapping in i2s ctl register per APQ8016 document.
Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
dmactl registers")

Signed-off-by: Jun Nie <jun.nie@linaro.org>
---
 sound/soc/qcom/lpass-apq8016.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephan Gerhold Jan. 25, 2021, 10:30 a.m. UTC | #1
On Wed, Jan 20, 2021 at 10:49:55AM +0800, Jun Nie wrote:
> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
> dmactl registers")
> 
> Signed-off-by: Jun Nie <jun.nie@linaro.org>

Thanks for spotting this, I guess this did not cause me problems yet
because I use SNDRV_PCM_FMTBIT_S16 everywhere.

Anyway, this looks correct according to the datasheet:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>

> ---
>  sound/soc/qcom/lpass-apq8016.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
> index 8507ef8f6679..3efa133d1c64 100644
> --- a/sound/soc/qcom/lpass-apq8016.c
> +++ b/sound/soc/qcom/lpass-apq8016.c
> @@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
>  	.micmode		= REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
>  	.micmono		= REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
>  	.wssrc			= REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
> -	.bitwidth		= REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
> +	.bitwidth		= REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
>  
>  	.rdma_dyncclk		= REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
>  	.rdma_bursten		= REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
> -- 
> 2.25.1
>
Srinivas Kandagatla Jan. 25, 2021, 11:01 a.m. UTC | #2
On 20/01/2021 02:49, Jun Nie wrote:
> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
> dmactl registers")
> 
> Signed-off-by: Jun Nie <jun.nie@linaro.org>

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>   sound/soc/qcom/lpass-apq8016.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
> index 8507ef8f6679..3efa133d1c64 100644
> --- a/sound/soc/qcom/lpass-apq8016.c
> +++ b/sound/soc/qcom/lpass-apq8016.c
> @@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
>   	.micmode		= REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
>   	.micmono		= REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
>   	.wssrc			= REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
> -	.bitwidth		= REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
> +	.bitwidth		= REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
>   
>   	.rdma_dyncclk		= REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
>   	.rdma_bursten		= REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
>
Stephan Gerhold Feb. 1, 2021, 10:44 a.m. UTC | #3
Hi Jun,

On Wed, Jan 20, 2021 at 10:49:55AM +0800, Jun Nie wrote:
> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
> dmactl registers")
> 
> Signed-off-by: Jun Nie <jun.nie@linaro.org>

It looks like you forgot to Cc the ASoC maintainer(s) here, especially
Mark Brown, which might be why this patch has not been applied yet.

Can you re-send this patch with all the maintainers in the Cc?
You can add the Reviewed-by: from me and Srinivas to your patch so
we don't need to send them again.

Thanks!
Stephan
diff mbox series

Patch

diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
index 8507ef8f6679..3efa133d1c64 100644
--- a/sound/soc/qcom/lpass-apq8016.c
+++ b/sound/soc/qcom/lpass-apq8016.c
@@ -250,7 +250,7 @@  static struct lpass_variant apq8016_data = {
 	.micmode		= REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
 	.micmono		= REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
 	.wssrc			= REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
-	.bitwidth		= REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
+	.bitwidth		= REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
 
 	.rdma_dyncclk		= REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
 	.rdma_bursten		= REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),