diff mbox series

[net] selftests/net/fib_tests: remove duplicate log test

Message ID 20210119025930.2810532-1-liuhangbin@gmail.com
State New
Headers show
Series [net] selftests/net/fib_tests: remove duplicate log test | expand

Commit Message

Hangbin Liu Jan. 19, 2021, 2:59 a.m. UTC
The previous test added an address with a specified metric and check if
correspond route was created. I somehow added two logs for the same
test. Remove the duplicated one.

Reported-by: Antoine Tenart <atenart@redhat.com>
Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/net/fib_tests.sh | 1 -
 1 file changed, 1 deletion(-)

Comments

Jakub Kicinski Jan. 20, 2021, 1:07 a.m. UTC | #1
On Mon, 18 Jan 2021 20:03:12 -0700 David Ahern wrote:
> On 1/18/21 7:59 PM, Hangbin Liu wrote:

> > The previous test added an address with a specified metric and check if

> > correspond route was created. I somehow added two logs for the same

> > test. Remove the duplicated one.

> > 

> > Reported-by: Antoine Tenart <atenart@redhat.com>

> > Fixes: 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")

> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

> > ---

> >  tools/testing/selftests/net/fib_tests.sh | 1 -

> >  1 file changed, 1 deletion(-)

> >   

> 

> Reviewed-by: David Ahern <dsahern@kernel.org>


Applied, thanks!
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
index 84205c3a55eb..2b5707738609 100755
--- a/tools/testing/selftests/net/fib_tests.sh
+++ b/tools/testing/selftests/net/fib_tests.sh
@@ -1055,7 +1055,6 @@  ipv6_addr_metric_test()
 
 	check_route6 "2001:db8:104::1 dev dummy2 proto kernel metric 260"
 	log_test $? 0 "Set metric with peer route on local side"
-	log_test $? 0 "User specified metric on local address"
 	check_route6 "2001:db8:104::2 dev dummy2 proto kernel metric 260"
 	log_test $? 0 "Set metric with peer route on peer side"