| Message ID | 1409771208-21867-2-git-send-email-nm@ti.com |
|---|---|
| State | New |
| Headers | show |
Hi, On Wed, Sep 03, 2014 at 02:06:47PM -0500, Nishanth Menon wrote: > ti,system-power-controller is more or less the standard way of > indicating that the PMIC is the system wide power controller and hence > may be used to switch off the system. Almost ALL TI PMIC drivers and > many Maxim PMIC drivers follow the same style. > > So support 'ti,system-power-controller' in addition to the usual > 'ti,use_poweroff' to indicate that the PMIC instance has control for > switching off the system. > > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > .../devicetree/bindings/mfd/twl4030-power.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt > index b9ee7b9..e1dff57 100644 > --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt > +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt > @@ -23,8 +23,11 @@ down during off-idle. Note that this does not work on all boards > depending on how the external oscillator is wired. > > Optional properties: > -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or > - SLEEP-to-OFF transition when the system poweroffs. > + > +- ti,system-power-controller OR ti,use_poweroff: This indicates that > + TWL4030 is the power supply master of the system. With this flag, the > + chip will initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when > + the system poweroffs. I suggest the following wording: - ti,system-power-controller: This indicates that TWL4030 is the power supply master of the system. With this flag, the chip will initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the system poweroffs. - ti,use_poweroff: Deprecated name for ti,system-power-controller -- Sebastian
On Wed, Sep 3, 2014 at 2:53 PM, Sebastian Reichel <sre@kernel.org> wrote: > On Wed, Sep 03, 2014 at 02:06:47PM -0500, Nishanth Menon wrote: >> Optional properties: >> -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or >> - SLEEP-to-OFF transition when the system poweroffs. >> + >> +- ti,system-power-controller OR ti,use_poweroff: This indicates that >> + TWL4030 is the power supply master of the system. With this flag, the >> + chip will initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when >> + the system poweroffs. > > I suggest the following wording: > > - ti,system-power-controller: This indicates that TWL4030 is the > power supply master of the system. With this flag, the chip will > initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > system poweroffs. > > - ti,use_poweroff: Deprecated name for ti,system-power-controller Yes, this does indeed sound better. if no one has a different opinion or further comments, will update this patch tomorrow.
diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt index b9ee7b9..e1dff57 100644 --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt @@ -23,8 +23,11 @@ down during off-idle. Note that this does not work on all boards depending on how the external oscillator is wired. Optional properties: -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or - SLEEP-to-OFF transition when the system poweroffs. + +- ti,system-power-controller OR ti,use_poweroff: This indicates that + TWL4030 is the power supply master of the system. With this flag, the + chip will initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when + the system poweroffs. Example: &i2c1 {
ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style. So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system. Signed-off-by: Nishanth Menon <nm@ti.com> --- .../devicetree/bindings/mfd/twl4030-power.txt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)