diff mbox series

[1/2] arm64: dts: fsl-ls1012a-rdb: add i2c devices

Message ID 20210115101613.1490837-1-paweldembicki@gmail.com
State Superseded
Headers show
Series [1/2] arm64: dts: fsl-ls1012a-rdb: add i2c devices | expand

Commit Message

Pawel Dembicki Jan. 15, 2021, 10:16 a.m. UTC
LS1012A-RDB equipped in some i2c devices:
  - 3x GPIO Expander: PCAL9555A (NXP)
  - Gyro: FXAS21002 (NXP)
  - Accelerometer: FXOS8700 (NXP)
  - Current & Power Monitor: INA220 (TI)

This patch add listed devices to dts.

Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
---
 .../boot/dts/freescale/fsl-ls1012a-rdb.dts    | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)

Comments

Shawn Guo Jan. 18, 2021, 7:36 a.m. UTC | #1
On Fri, Jan 15, 2021 at 11:16:12AM +0100, Pawel Dembicki wrote:
> LS1012A-RDB equipped in some i2c devices:

>   - 3x GPIO Expander: PCAL9555A (NXP)

>   - Gyro: FXAS21002 (NXP)

>   - Accelerometer: FXOS8700 (NXP)

>   - Current & Power Monitor: INA220 (TI)

> 

> This patch add listed devices to dts.

> 

> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>

> ---

>  .../boot/dts/freescale/fsl-ls1012a-rdb.dts    | 45 +++++++++++++++++++

>  1 file changed, 45 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts

> index d45c17620b98..12117a973eb6 100644

> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts

> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts

> @@ -7,6 +7,7 @@

>   */

>  /dts-v1/;

>  

> +#include <dt-bindings/interrupt-controller/irq.h>

>  #include "fsl-ls1012a.dtsi"

>  

>  / {

> @@ -33,6 +34,50 @@ &esdhc1 {

>  

>  &i2c0 {

>  	status = "okay";

> +

> +	accelerometer@1e {

> +		compatible = "nxp,fxos8700";

> +		reg = <0x1e>;

> +		interrupt-parent = <&gpio26>;

> +		interrupts = <13 IRQ_TYPE_EDGE_RISING>;

> +		interrupt-names = "INT1";

> +	};

> +

> +	gyroscope@20 {


Please sort these device node in unit-address.

Shawn

> +		compatible = "nxp,fxas21002c";

> +		reg = <0x20>;

> +	};

> +

> +	gpio@24 {

> +		compatible = "nxp,pcal9555a";

> +		reg = <0x24>;

> +		gpio-controller;

> +		#gpio-cells = <2>;

> +	};

> +

> +	gpio@25 {

> +		compatible = "nxp,pcal9555a";

> +		reg = <0x25>;

> +		gpio-controller;

> +		#gpio-cells = <2>;

> +	};

> +

> +	gpio26: gpio@26 {

> +		compatible = "nxp,pcal9555a";

> +		reg = <0x26>;

> +		interrupt-parent = <&gpio0>;

> +		interrupts = <13 IRQ_TYPE_EDGE_FALLING>;

> +		interrupt-controller;

> +		#interrupt-cells = <2>;

> +		gpio-controller;

> +		#gpio-cells = <2>;

> +	};

> +

> +	current-sensor@40 {

> +		compatible = "ti,ina220";

> +		reg = <0x40>;

> +		shunt-resistor = <2000>;

> +	};

>  };

>  

>  &qspi {

> -- 

> 2.25.1

>
Pawel Dembicki Jan. 18, 2021, 10:08 a.m. UTC | #2
On 18.01.2021 at 08:36 Shawn Guo <shawnguo@kernel.org> wrote:
>

> On Fri, Jan 15, 2021 at 11:16:12AM +0100, Pawel Dembicki wrote:

> > LS1012A-RDB equipped in some i2c devices:

> >   - 3x GPIO Expander: PCAL9555A (NXP)

> >   - Gyro: FXAS21002 (NXP)

> >   - Accelerometer: FXOS8700 (NXP)

> >   - Current & Power Monitor: INA220 (TI)

> >

> > This patch add listed devices to dts.

> >

> > Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>

> > ---

> >  .../boot/dts/freescale/fsl-ls1012a-rdb.dts    | 45 +++++++++++++++++++

> >  1 file changed, 45 insertions(+)

> >

> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts

> > index d45c17620b98..12117a973eb6 100644

> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts

> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts

> > @@ -7,6 +7,7 @@

> >   */

> >  /dts-v1/;

> >

> > +#include <dt-bindings/interrupt-controller/irq.h>

> >  #include "fsl-ls1012a.dtsi"

> >

> >  / {

> > @@ -33,6 +34,50 @@ &esdhc1 {

> >

> >  &i2c0 {

> >       status = "okay";

> > +

> > +     accelerometer@1e {

> > +             compatible = "nxp,fxos8700";

> > +             reg = <0x1e>;

> > +             interrupt-parent = <&gpio26>;

> > +             interrupts = <13 IRQ_TYPE_EDGE_RISING>;

> > +             interrupt-names = "INT1";

> > +     };

> > +

> > +     gyroscope@20 {

>

> Please sort these device node in unit-address.

>

> Shawn

>


Could You give me more details please?  Devices are sorted by
unit-address ascending.

Pawel

> > +             compatible = "nxp,fxas21002c";

> > +             reg = <0x20>;

> > +     };

> > +

> > +     gpio@24 {

> > +             compatible = "nxp,pcal9555a";

> > +             reg = <0x24>;

> > +             gpio-controller;

> > +             #gpio-cells = <2>;

> > +     };

> > +

> > +     gpio@25 {

> > +             compatible = "nxp,pcal9555a";

> > +             reg = <0x25>;

> > +             gpio-controller;

> > +             #gpio-cells = <2>;

> > +     };

> > +

> > +     gpio26: gpio@26 {

> > +             compatible = "nxp,pcal9555a";

> > +             reg = <0x26>;

> > +             interrupt-parent = <&gpio0>;

> > +             interrupts = <13 IRQ_TYPE_EDGE_FALLING>;

> > +             interrupt-controller;

> > +             #interrupt-cells = <2>;

> > +             gpio-controller;

> > +             #gpio-cells = <2>;

> > +     };

> > +

> > +     current-sensor@40 {

> > +             compatible = "ti,ina220";

> > +             reg = <0x40>;

> > +             shunt-resistor = <2000>;

> > +     };

> >  };

> >

> >  &qspi {

> > --

> > 2.25.1

> >
Shawn Guo Jan. 19, 2021, 9:03 a.m. UTC | #3
On Mon, Jan 18, 2021 at 11:08:11AM +0100, Paweł Dembicki wrote:
> On 18.01.2021 at 08:36 Shawn Guo <shawnguo@kernel.org> wrote:

> >

> > On Fri, Jan 15, 2021 at 11:16:12AM +0100, Pawel Dembicki wrote:

> > > LS1012A-RDB equipped in some i2c devices:

> > >   - 3x GPIO Expander: PCAL9555A (NXP)

> > >   - Gyro: FXAS21002 (NXP)

> > >   - Accelerometer: FXOS8700 (NXP)

> > >   - Current & Power Monitor: INA220 (TI)

> > >

> > > This patch add listed devices to dts.

> > >

> > > Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>

> > > ---

> > >  .../boot/dts/freescale/fsl-ls1012a-rdb.dts    | 45 +++++++++++++++++++

> > >  1 file changed, 45 insertions(+)

> > >

> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts

> > > index d45c17620b98..12117a973eb6 100644

> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts

> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts

> > > @@ -7,6 +7,7 @@

> > >   */

> > >  /dts-v1/;

> > >

> > > +#include <dt-bindings/interrupt-controller/irq.h>

> > >  #include "fsl-ls1012a.dtsi"

> > >

> > >  / {

> > > @@ -33,6 +34,50 @@ &esdhc1 {

> > >

> > >  &i2c0 {

> > >       status = "okay";

> > > +

> > > +     accelerometer@1e {

> > > +             compatible = "nxp,fxos8700";

> > > +             reg = <0x1e>;

> > > +             interrupt-parent = <&gpio26>;

> > > +             interrupts = <13 IRQ_TYPE_EDGE_RISING>;

> > > +             interrupt-names = "INT1";

> > > +     };

> > > +

> > > +     gyroscope@20 {

> >

> > Please sort these device node in unit-address.

> >

> > Shawn

> >

> 

> Could You give me more details please?  Devices are sorted by

> unit-address ascending.


Oops! I'm sorry.  It must be something went wrong with my eyes.

Shawn
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
index d45c17620b98..12117a973eb6 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
@@ -7,6 +7,7 @@ 
  */
 /dts-v1/;
 
+#include <dt-bindings/interrupt-controller/irq.h>
 #include "fsl-ls1012a.dtsi"
 
 / {
@@ -33,6 +34,50 @@  &esdhc1 {
 
 &i2c0 {
 	status = "okay";
+
+	accelerometer@1e {
+		compatible = "nxp,fxos8700";
+		reg = <0x1e>;
+		interrupt-parent = <&gpio26>;
+		interrupts = <13 IRQ_TYPE_EDGE_RISING>;
+		interrupt-names = "INT1";
+	};
+
+	gyroscope@20 {
+		compatible = "nxp,fxas21002c";
+		reg = <0x20>;
+	};
+
+	gpio@24 {
+		compatible = "nxp,pcal9555a";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@25 {
+		compatible = "nxp,pcal9555a";
+		reg = <0x25>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio26: gpio@26 {
+		compatible = "nxp,pcal9555a";
+		reg = <0x26>;
+		interrupt-parent = <&gpio0>;
+		interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	current-sensor@40 {
+		compatible = "ti,ina220";
+		reg = <0x40>;
+		shunt-resistor = <2000>;
+	};
 };
 
 &qspi {