diff mbox series

ARM: dts: imx6-sr-som: increase at8035 PHY gigabit Tw parameter

Message ID E1l0Ye4-0002pq-CQ@rmk-PC.armlinux.org.uk
State Accepted
Commit b73d538a01305446e843a6be45853cce1438acdd
Headers show
Series ARM: dts: imx6-sr-som: increase at8035 PHY gigabit Tw parameter | expand

Commit Message

Russell King (Oracle) Jan. 15, 2021, 11:36 p.m. UTC
Increase the SmartEEE Tw parameter for Atheros PHYs to stop gigabit
links from sporadically dropping. Jon Nettleton found that a value
of 23 was the minimum to give a stable link, but testing with the
Com Express 7 module shows 24 is the minimum - so 23 may still be on
the margins. Use 24 instead for consistency across SolidRun platforms.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
The corresponding part of this has been merged into net-next:
  https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=e7fa5c80defe079190537fd6b6aecb8866b446a3

 arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Shawn Guo Jan. 29, 2021, 7:07 a.m. UTC | #1
On Fri, Jan 15, 2021 at 11:36:44PM +0000, Russell King wrote:
> Increase the SmartEEE Tw parameter for Atheros PHYs to stop gigabit

> links from sporadically dropping. Jon Nettleton found that a value

> of 23 was the minimum to give a stable link, but testing with the

> Com Express 7 module shows 24 is the minimum - so 23 may still be on

> the margins. Use 24 instead for consistency across SolidRun platforms.

> 

> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>


Applied, thanks.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
index 1d1f9ec27045..fd387960a2c9 100644
--- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
@@ -69,10 +69,12 @@ 
 		ethernet-phy@0 {
 			reg = <0>;
 			qca,clk-out-frequency = <125000000>;
+			qca,smarteee-tw-us-1g = <24>;
 		};
 		ethernet-phy@4 {
 			reg = <4>;
 			qca,clk-out-frequency = <125000000>;
+			qca,smarteee-tw-us-1g = <24>;
 		};
 	};
 };