diff mbox series

[5.10,033/103] chtls: Replace skb_dequeue with skb_peek

Message ID	20210115122007.660682591@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Vinay Kumar Yadav <vinay.yadav@chelsio.com>, Ayush Sawal <ayush.sawal@chelsio.com>, Jakub Kicinski <kuba@kernel.org> Subject: [PATCH 5.10 033/103] chtls: Replace skb_dequeue with skb_peek Date: Fri, 15 Jan 2021 13:27:26 +0100 Message-Id: <20210115122007.660682591@linuxfoundation.org> In-Reply-To: <20210115122006.047132306@linuxfoundation.org> References: <20210115122006.047132306@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [5.10,002/103] io_uring: synchronise IOPOLL on task_submit fail [5.10,005/103] RDMA/hns: Avoid filling sl in high 3 bits of vlan_id [5.10,006/103] iommu/arm-smmu-qcom: Initialize SCTLR of the bypass context [5.10,007/103] drm/panfrost: Dont corrupt the queue mutex on open/close [5.10,008/103] io_uring: Fix return value from alloc_fixed_file_ref_node [5.10,009/103] scsi: ufs: Fix -Wsometimes-uninitialized warning [5.10,010/103] btrfs: skip unnecessary searches for xattrs when logging an inode [5.10,012/103] btrfs: shrink delalloc pages instead of full inodes [5.10,014/103] net: hns3: fix incorrect handling of sctp6 rss tuple [5.10,015/103] net: hns3: fix the number of queues actually used by ARQ [5.10,017/103] net: stmmac: dwmac-sun8i: Fix probe error handling [5.10,023/103] net: bareudp: add missing error handling for bareudp_link_config() [5.10,025/103] net: ipv6: fib: flush exceptions when purging route [5.10,028/103] net: ip: always refragment ip defragmented packets [5.10,030/103] chtls: Remove invalid set_tcb call [5.10,031/103] chtls: Fix panic when route to peer not configured [5.10,033/103] chtls: Replace skb_dequeue with skb_peek [5.10,036/103] octeontx2-af: fix memory leak of lmac and lmac->name [5.10,037/103] nexthop: Fix off-by-one error in error path [5.10,038/103] nexthop: Unlink nexthop group entry in error path [5.10,039/103] nexthop: Bounce NHA_GATEWAY in FDB nexthop groups [5.10,040/103] s390/qeth: fix deadlock during recovery [5.10,042/103] s390/qeth: fix L2 header access in qeth_l3_osa_features_check() [5.10,043/103] net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE [5.10,048/103] scsi: lpfc: Fix variable vport set but not used in lpfc_sli4_abts_err_handler() [5.10,049/103] ionic: start queues before announcing link up [5.10,051/103] fanotify: Fix sys_fanotify_mark() on native x86-32 [5.10,053/103] i2c: sprd: use a specific timeout to avoid system hang up issue [5.10,054/103] dmaengine: dw-edma: Fix use after free in dw_edma_alloc_chunk() [5.10,055/103] selftests/bpf: Clarify build error if no vmlinux [5.10,056/103] can: tcan4x5x: fix bittiming const, use common bittiming from m_can driver [5.10,057/103] can: m_can: m_can_class_unregister(): remove erroneous m_can_clk_stop() [5.10,058/103] can: kvaser_pciefd: select CONFIG_CRC32 [5.10,060/103] cpufreq: powernow-k8: pass policy rather than use cpufreq_cpu_get() [5.10,064/103] i2c: mediatek: Fix apdma and i2c hand-shake timeout [5.10,065/103] bcache: set bcache device into read-only mode for BCH_FEATURE_INCOMPAT_OBSO_LARGE_... [5.10,067/103] interconnect: qcom: fix rpmh link failures [5.10,068/103] dmaengine: mediatek: mtk-hsdma: Fix a resource leak in the error handling path of ... [5.10,070/103] dmaengine: xilinx_dma: check dma_async_device_register return value [5.10,071/103] dmaengine: xilinx_dma: fix incompatible param warning in _child_probe() [5.10,072/103] dmaengine: xilinx_dma: fix mixed_enum_type coverity warning [5.10,074/103] qed: select CONFIG_CRC32 [5.10,075/103] phy: dp83640: select CONFIG_CRC32 [5.10,076/103] wil6210: select CONFIG_CRC32 [5.10,077/103] block: rsxx: select CONFIG_CRC32 [5.10,078/103] lightnvm: select CONFIG_CRC32 [5.10,079/103] zonefs: select CONFIG_CRC32 [5.10,080/103] iommu/vt-d: Fix misuse of ALIGN in qi_flush_piotlb() [5.10,086/103] regmap: debugfs: Fix a memory leak when calling regmap_attach_dev [5.10,087/103] wan: ds26522: select CONFIG_BITREVERSE [5.10,088/103] arm64: cpufeature: remove non-exist CONFIG_KVM_ARM_HOST [5.10,089/103] regulator: qcom-rpmh-regulator: correct hfsmps515 definition [5.10,091/103] drm/i915/dp: Track pm_qos per connector [5.10,092/103] net: mvneta: fix error message when MTU too large for XDP [5.10,093/103] selftests: fib_nexthops: Fix wrong mausezahn invocation [5.10,096/103] xsk: Rollback reservation at NETDEV_TX_BUSY [5.10,098/103] can: isotp: isotp_getname(): fix kernel information leak [5.10,100/103] net: drop bogus skb with CHECKSUM_PARTIAL and offset beyond end of trimmed packet [5.10,101/103] regmap: debugfs: Fix a reversed if statement in regmap_debugfs_init()

Commit Message

Greg KH Jan. 15, 2021, 12:27 p.m. UTC

From: Ayush Sawal <ayush.sawal@chelsio.com>

[ Upstream commit a84b2c0d5fa23da6d6c8c0d5f5c93184a2744d3e ]

The skb is unlinked twice, one in __skb_dequeue in function
chtls_reset_synq() and another in cleanup_syn_rcv_conn().
So in this patch using skb_peek() instead of __skb_dequeue(),
so that unlink will be handled only in cleanup_syn_rcv_conn().

Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition")
Signed-off-by: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

--- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c
+++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c
@@ -621,7 +621,7 @@  static void chtls_reset_synq(struct list
 
 	while (!skb_queue_empty(&listen_ctx->synq)) {
 		struct chtls_sock *csk =
-			container_of((struct synq *)__skb_dequeue
+			container_of((struct synq *)skb_peek
 				(&listen_ctx->synq), struct chtls_sock, synq);
 		struct sock *child = csk->sk;