| Message ID | 1409326293-33868-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | Accepted |
| Commit | 4b18b9fd607f23cf1cffb71fc7bae6738938a64b |
| Headers | show |
On 08/29/2014 07:31 PM, Mike Holmes wrote: > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index c9aac14..da109b7 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -170,7 +170,7 @@ AC_OUTPUT > AC_MSG_RESULT([ > $PACKAGE $VERSION > ======== > - > + with_platform: ${with_platform} white spaces. > prefix: ${prefix} > sysconfdir: ${sysconfdir} > libdir: ${libdir} above 3 lines use tabs. Maxim.
Tabs are semantically meaningful in make files (terrible design choice, but that's the way it is). Need to be careful about rules for them because of this. Bill On Mon, Sep 1, 2014 at 6:58 AM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 08/29/2014 07:31 PM, Mike Holmes wrote: > >> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >> --- >> configure.ac | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index c9aac14..da109b7 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -170,7 +170,7 @@ AC_OUTPUT >> AC_MSG_RESULT([ >> $PACKAGE $VERSION >> ======== >> - >> + with_platform: ${with_platform} >> > white spaces. > > prefix: ${prefix} >> sysconfdir: ${sysconfdir} >> libdir: ${libdir} >> > above 3 lines use tabs. > > Maxim. > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
On Sep 1, 2014, at 3:58 PM, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Tabs are semantically meaningful in make files (terrible design choice, but that's the way it is). Need to be careful about rules for them because of this. The rule body’s in Makefile’s must be tabbed for the first character of each line, but the other characters in the line are not as important. I would suggest to allow tabs in Makefiles just to make it simple. > > Bill > > > On Mon, Sep 1, 2014 at 6:58 AM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 08/29/2014 07:31 PM, Mike Holmes wrote: > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index c9aac14..da109b7 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -170,7 +170,7 @@ AC_OUTPUT > AC_MSG_RESULT([ > $PACKAGE $VERSION > ======== > - > + with_platform: ${with_platform} > white spaces. > > prefix: ${prefix} > sysconfdir: ${sysconfdir} > libdir: ${libdir} > above 3 lines use tabs. > > Maxim. > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
this commit was not about Makefile. It's message which printed in the and of ./configure. Not critical but it's better to follow the same coding style for all lines event in scripts and docs. Maxim. On 09/02/2014 03:46 AM, Wiles, Roger Keith wrote: > On Sep 1, 2014, at 3:58 PM, Bill Fischofer <bill.fischofer@linaro.org> wrote: > >> Tabs are semantically meaningful in make files (terrible design choice, but that's the way it is). Need to be careful about rules for them because of this. > The rule body’s in Makefile’s must be tabbed for the first character of each line, but the other characters in the line are not as important. I would suggest to allow tabs in Makefiles just to make it simple. >> Bill >> >> >> On Mon, Sep 1, 2014 at 6:58 AM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: >> On 08/29/2014 07:31 PM, Mike Holmes wrote: >> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >> --- >> configure.ac | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index c9aac14..da109b7 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -170,7 +170,7 @@ AC_OUTPUT >> AC_MSG_RESULT([ >> $PACKAGE $VERSION >> ======== >> - >> + with_platform: ${with_platform} >> white spaces. >> >> prefix: ${prefix} >> sysconfdir: ${sysconfdir} >> libdir: ${libdir} >> above 3 lines use tabs. >> >> Maxim. >> >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp > Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533 >
OK, thanks for the clarification. On Tue, Sep 2, 2014 at 3:47 AM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > this commit was not about Makefile. It's message which printed in the and > of ./configure. > Not critical but it's better to follow the same coding style for all lines > event in scripts and docs. > > Maxim. > > > On 09/02/2014 03:46 AM, Wiles, Roger Keith wrote: > >> On Sep 1, 2014, at 3:58 PM, Bill Fischofer <bill.fischofer@linaro.org> >> wrote: >> >> Tabs are semantically meaningful in make files (terrible design choice, >>> but that's the way it is). Need to be careful about rules for them because >>> of this. >>> >> The rule body’s in Makefile’s must be tabbed for the first character of >> each line, but the other characters in the line are not as important. I >> would suggest to allow tabs in Makefiles just to make it simple. >> >>> Bill >>> >>> >>> On Mon, Sep 1, 2014 at 6:58 AM, Maxim Uvarov <maxim.uvarov@linaro.org> >>> wrote: >>> On 08/29/2014 07:31 PM, Mike Holmes wrote: >>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >>> --- >>> configure.ac | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/configure.ac b/configure.ac >>> index c9aac14..da109b7 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -170,7 +170,7 @@ AC_OUTPUT >>> AC_MSG_RESULT([ >>> $PACKAGE $VERSION >>> ======== >>> - >>> + with_platform: ${with_platform} >>> white spaces. >>> >>> prefix: ${prefix} >>> sysconfdir: ${sysconfdir} >>> libdir: ${libdir} >>> above 3 lines use tabs. >>> >>> Maxim. >>> >>> >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> http://lists.linaro.org/mailman/listinfo/lng-odp >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> http://lists.linaro.org/mailman/listinfo/lng-odp >>> >> Keith Wiles, Principal Technologist with CTO office, Wind River mobile >> 972-213-5533 >> >> >
diff --git a/configure.ac b/configure.ac index c9aac14..da109b7 100644 --- a/configure.ac +++ b/configure.ac @@ -170,7 +170,7 @@ AC_OUTPUT AC_MSG_RESULT([ $PACKAGE $VERSION ======== - + with_platform: ${with_platform} prefix: ${prefix} sysconfdir: ${sysconfdir} libdir: ${libdir}
Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)