diff mbox series

[v2,2/9] clk: qcom: gcc-sdm660: Mark GPU CFG AHB clock as critical

Message ID 20210113183817.447866-3-angelogioacchino.delregno@somainline.org
State Accepted
Commit c3656218386a40d884d8a757e1683028147c6e1c
Headers show
Series SDM630/660 GCC/MMCC/GPUCC clock controllers | expand

Commit Message

AngeloGioacchino Del Regno Jan. 13, 2021, 6:38 p.m. UTC
This clock is critical for any access to the GPU: gating it will
crash the system when the GPU has been initialized (so, you cannot
gate it unless you deinit the Adreno completely).

So, to achieve a working state with GPU on, set the CLK_IS_CRITICAL
flag to this clock.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
---
 drivers/clk/qcom/gcc-sdm660.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Boyd Feb. 11, 2021, 8:18 p.m. UTC | #1
Quoting AngeloGioacchino Del Regno (2021-01-13 10:38:10)
> This clock is critical for any access to the GPU: gating it will

> crash the system when the GPU has been initialized (so, you cannot

> gate it unless you deinit the Adreno completely).

> 

> So, to achieve a working state with GPU on, set the CLK_IS_CRITICAL

> flag to this clock.

> 

> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

> ---


Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/qcom/gcc-sdm660.c b/drivers/clk/qcom/gcc-sdm660.c
index 3b7181d0ff71..6394257ca8c0 100644
--- a/drivers/clk/qcom/gcc-sdm660.c
+++ b/drivers/clk/qcom/gcc-sdm660.c
@@ -1571,6 +1571,7 @@  static struct clk_branch gcc_gpu_cfg_ahb_clk = {
 		.hw.init = &(struct clk_init_data){
 			.name = "gcc_gpu_cfg_ahb_clk",
 			.ops = &clk_branch2_ops,
+			.flags = CLK_IS_CRITICAL,
 		},
 	},
 };