| Message ID | 20210114152323.2382283-5-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | e664f0021fcaf4e4e5078e00a75db0f0bfa79256 |
| Headers | show |
| Series | (Set 2/2) Rid W=1 issues from Input | expand |
On Thu, Jan 14, 2021 at 4:23 PM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’: > drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable] > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Henrik Rydberg <rydberg@bitmath.org> > Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com> > Cc: linux-input@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Thanks for the cleanup :) Cheers, Benjamin > --- > drivers/input/touchscreen/surface3_spi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c > index 731454599fcee..1da23e5585a0d 100644 > --- a/drivers/input/touchscreen/surface3_spi.c > +++ b/drivers/input/touchscreen/surface3_spi.c > @@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data, > > static void surface3_spi_process_touch(struct surface3_ts_data *ts_data, u8 *data) > { > - u16 timestamp; > unsigned int i; > - timestamp = get_unaligned_le16(&data[15]); > > for (i = 0; i < 13; i++) { > struct surface3_ts_data_finger *finger; > -- > 2.25.1 >
On Thu, Jan 14, 2021 at 03:23:22PM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’: > drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable] > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Henrik Rydberg <rydberg@bitmath.org> > Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com> > Cc: linux-input@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied, thank you. -- Dmitry
diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c index 731454599fcee..1da23e5585a0d 100644 --- a/drivers/input/touchscreen/surface3_spi.c +++ b/drivers/input/touchscreen/surface3_spi.c @@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data, static void surface3_spi_process_touch(struct surface3_ts_data *ts_data, u8 *data) { - u16 timestamp; unsigned int i; - timestamp = get_unaligned_le16(&data[15]); for (i = 0; i < 13; i++) { struct surface3_ts_data_finger *finger;
Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’: drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Henrik Rydberg <rydberg@bitmath.org> Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com> Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/input/touchscreen/surface3_spi.c | 2 -- 1 file changed, 2 deletions(-) -- 2.25.1