| Message ID | 20210113194214.522238-8-angelogioacchino.delregno@somainline.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Really implement Qualcomm LAB/IBB regulators | expand |
On Wed 13 Jan 13:42 CST 2021, AngeloGioacchino Del Regno wrote: > In commit 208921bae696 ("arm64: dts: qcom: pmi8998: Add nodes for > LAB and IBB regulators") bindings for the lab/ibb regulators were > added to the pmi8998 dt, but the original committer has never > specified what the interrupts were for. > LAB and IBB regulators provide two interrupts, SC-ERR (short > circuit error) and VREG-OK but, in that commit, the regulators > were provided with two different types of interrupts; > specifically, IBB had the SC-ERR interrupt, while LAB had the > VREG-OK one, none of which were (luckily) used, since the driver > didn't actually use these at all. > Assuming that the original intention was to have the SC IRQ in > both LAB and IBB, as per the names appearing in documentation, > fix the SCP interrupt. > > While at it, also add the OCP interrupt in order to be able to > enable the Over-Current Protection feature, if requested. > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > --- > arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > index d016b12967eb..d230c510d4b7 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > @@ -30,11 +30,15 @@ labibb { > compatible = "qcom,pmi8998-lab-ibb"; > > ibb: ibb { > - interrupts = <0x3 0xdc 0x2 IRQ_TYPE_EDGE_RISING>; > + interrupts = <0x3 0xdc 0x2 IRQ_TYPE_EDGE_RISING>, > + <0x3 0xdc 0x0 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "sc-err", "ocp"; > }; > > lab: lab { > - interrupts = <0x3 0xde 0x0 IRQ_TYPE_EDGE_RISING>; > + interrupts = <0x3 0xde 0x1 IRQ_TYPE_EDGE_RISING>, > + <0x3 0xde 0x0 IRQ_TYPE_LEVEL_LOW>; > + interrupt-names = "sc-err", "ocp"; > }; > }; > }; > -- > 2.29.2 >
diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi index d016b12967eb..d230c510d4b7 100644 --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi @@ -30,11 +30,15 @@ labibb { compatible = "qcom,pmi8998-lab-ibb"; ibb: ibb { - interrupts = <0x3 0xdc 0x2 IRQ_TYPE_EDGE_RISING>; + interrupts = <0x3 0xdc 0x2 IRQ_TYPE_EDGE_RISING>, + <0x3 0xdc 0x0 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "sc-err", "ocp"; }; lab: lab { - interrupts = <0x3 0xde 0x0 IRQ_TYPE_EDGE_RISING>; + interrupts = <0x3 0xde 0x1 IRQ_TYPE_EDGE_RISING>, + <0x3 0xde 0x0 IRQ_TYPE_LEVEL_LOW>; + interrupt-names = "sc-err", "ocp"; }; }; };
In commit 208921bae696 ("arm64: dts: qcom: pmi8998: Add nodes for LAB and IBB regulators") bindings for the lab/ibb regulators were added to the pmi8998 dt, but the original committer has never specified what the interrupts were for. LAB and IBB regulators provide two interrupts, SC-ERR (short circuit error) and VREG-OK but, in that commit, the regulators were provided with two different types of interrupts; specifically, IBB had the SC-ERR interrupt, while LAB had the VREG-OK one, none of which were (luckily) used, since the driver didn't actually use these at all. Assuming that the original intention was to have the SC IRQ in both LAB and IBB, as per the names appearing in documentation, fix the SCP interrupt. While at it, also add the OCP interrupt in order to be able to enable the Over-Current Protection feature, if requested. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> --- arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)