| Message ID | 1409235244-25783-8-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hmm, this PCD looks to be specific to your platform. Only platform specific components use this PCD. Why do you not declare it into the DEC of your platform (ie: ArmVirtualizationPkg/ArmVirtualizationQemu.dec)? > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: 28 August 2014 15:14 > To: lersek@redhat.com; Olivier Martin; edk2- > devel@lists.sourceforge.net; peter.maydell@linaro.org; > christoffer.dall@linaro.org; drjones@redhat.com; > ilias.biris@linaro.org; leif.lindholm@linaro.org > Cc: Ard Biesheuvel > Subject: [PATCH v4 07/16] ArmPkg: introduce PCD > gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress > > Introduce gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress, which will be > used by > virtual machine ports that discover the system configuration from a > flattened > device tree DTB image. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Reviewed-by: Laszlo Ersek <lersek@redhat.com> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > ArmPkg/ArmPkg.dec | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > index 43eff6641294..9408b321d45e 100644 > --- a/ArmPkg/ArmPkg.dec > +++ b/ArmPkg/ArmPkg.dec > @@ -154,6 +154,8 @@ > gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum|26|UINT32|0x00000040 > gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|27|UINT32|0x00000041 > > + gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress|0x0|UINT64|0x00000042 > + > [PcdsFixedAtBuild.ARM] > # > # ARM Security Extension > -- > 1.8.3.2 > ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/
On 1 September 2014 18:04, Olivier Martin <olivier.martin@arm.com> wrote: > Hmm, this PCD looks to be specific to your platform. Only platform specific > components use this PCD. > > Why do you not declare it into the DEC of your platform (ie: > ArmVirtualizationPkg/ArmVirtualizationQemu.dec)? > Good point, I will do that. >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: 28 August 2014 15:14 >> To: lersek@redhat.com; Olivier Martin; edk2- >> devel@lists.sourceforge.net; peter.maydell@linaro.org; >> christoffer.dall@linaro.org; drjones@redhat.com; >> ilias.biris@linaro.org; leif.lindholm@linaro.org >> Cc: Ard Biesheuvel >> Subject: [PATCH v4 07/16] ArmPkg: introduce PCD >> gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress >> >> Introduce gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress, which will be >> used by >> virtual machine ports that discover the system configuration from a >> flattened >> device tree DTB image. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Reviewed-by: Laszlo Ersek <lersek@redhat.com> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> --- >> ArmPkg/ArmPkg.dec | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec >> index 43eff6641294..9408b321d45e 100644 >> --- a/ArmPkg/ArmPkg.dec >> +++ b/ArmPkg/ArmPkg.dec >> @@ -154,6 +154,8 @@ >> gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum|26|UINT32|0x00000040 >> gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|27|UINT32|0x00000041 >> >> + gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress|0x0|UINT64|0x00000042 >> + >> [PcdsFixedAtBuild.ARM] >> # >> # ARM Security Extension >> -- >> 1.8.3.2 >> > > > > ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/
diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index 43eff6641294..9408b321d45e 100644 --- a/ArmPkg/ArmPkg.dec +++ b/ArmPkg/ArmPkg.dec @@ -154,6 +154,8 @@ gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum|26|UINT32|0x00000040 gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|27|UINT32|0x00000041 + gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress|0x0|UINT64|0x00000042 + [PcdsFixedAtBuild.ARM] # # ARM Security Extension