diff mbox series

arm64: dts: broadcom: bcm4908: describe PMB block

Message ID 20210112192723.751-1-zajec5@gmail.com
State Superseded
Headers show
Series arm64: dts: broadcom: bcm4908: describe PMB block | expand

Commit Message

Rafał Miłecki Jan. 12, 2021, 7:27 p.m. UTC
From: Rafał Miłecki <rafal@milecki.pl>

PMB (Power Management Bus) controls powering connected devices (e.g.
PCIe, USB, SATA). In BCM4908 it's a part of the PROCMON block.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
Florian: this patch is based on top of the
[PATCH] arm64: dts: broadcom: bcm4908: describe internal switch
one. Both modify "ranges".
---
 .../boot/dts/broadcom/bcm4908/bcm4908.dtsi      | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Comments

Florian Fainelli Jan. 13, 2021, 4:49 a.m. UTC | #1
On 1/12/2021 11:27 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>

> 

> PMB (Power Management Bus) controls powering connected devices (e.g.

> PCIe, USB, SATA). In BCM4908 it's a part of the PROCMON block.

> 

> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

> ---

> Florian: this patch is based on top of the

> [PATCH] arm64: dts: broadcom: bcm4908: describe internal switch

> one. Both modify "ranges".

> ---

>  .../boot/dts/broadcom/bcm4908/bcm4908.dtsi      | 17 ++++++++++++++++-

>  1 file changed, 16 insertions(+), 1 deletion(-)

> 

> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi

> index 0b44f32fdef1..882953885bfc 100644

> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi

> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi

> @@ -108,7 +108,7 @@ soc {

>  		compatible = "simple-bus";

>  		#address-cells = <1>;

>  		#size-cells = <1>;

> -		ranges = <0x00 0x00 0x80000000 0xd0000>;

> +		ranges = <0x00 0x00 0x80000000 0x281000>;

>  

>  		usb@c300 {

>  			compatible = "generic-ehci";

> @@ -213,6 +213,21 @@ phy12: phy@c {

>  				};

>  			};

>  		};

> +

> +		procmon: syscon@280000 {

> +			compatible = "simple-mfd";


Likewise, I would use "simple-bus" here instead of "simple-mfd" even if
this does not create a functional difference.
-- 
Florian
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index 0b44f32fdef1..882953885bfc 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -108,7 +108,7 @@  soc {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-		ranges = <0x00 0x00 0x80000000 0xd0000>;
+		ranges = <0x00 0x00 0x80000000 0x281000>;
 
 		usb@c300 {
 			compatible = "generic-ehci";
@@ -213,6 +213,21 @@  phy12: phy@c {
 				};
 			};
 		};
+
+		procmon: syscon@280000 {
+			compatible = "simple-mfd";
+			reg = <0x280000 0x1000>;
+			ranges;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			power-controller@2800c0 {
+				compatible = "brcm,bcm4908-pmb";
+				reg = <0x2800c0 0x40>;
+				#power-domain-cells = <1>;
+			};
+		};
 	};
 
 	bus@ff800000 {