diff mbox series

dmaengine: qcom: Always inline gpi_update_reg

Message ID 20210112191214.1264793-1-natechancellor@gmail.com
State Accepted
Commit 0a6d3038d914b51d6860f23ea2b508590e8340de
Headers show
Series dmaengine: qcom: Always inline gpi_update_reg | expand

Commit Message

Nathan Chancellor Jan. 12, 2021, 7:12 p.m. UTC 
When building with CONFIG_UBSAN_UNSIGNED_OVERFLOW, clang decides not to
inline gpi_update_reg, which causes a linkage failure around __bad_mask:

ld.lld: error: undefined symbol: __bad_mask
>>> referenced by bitfield.h:119 (include/linux/bitfield.h:119)
>>>               dma/qcom/gpi.o:(gpi_update_reg) in archive drivers/built-in.a
>>> referenced by bitfield.h:119 (include/linux/bitfield.h:119)
>>>               dma/qcom/gpi.o:(gpi_update_reg) in archive drivers/built-in.a

If gpi_update_reg is not inlined, the mask value will not be known at
compile time so the check in field_multiplier stays in the final
object file, causing the above linkage failure. Always inline
gpi_update_reg so that this check can never fail.

Fixes: 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1243
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
 drivers/dma/qcom/gpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837

Comments

Vinod Koul Jan. 13, 2021, 11:21 a.m. UTC | #1 
On 12-01-21, 12:12, Nathan Chancellor wrote:
> When building with CONFIG_UBSAN_UNSIGNED_OVERFLOW, clang decides not to

> inline gpi_update_reg, which causes a linkage failure around __bad_mask:

> 

> ld.lld: error: undefined symbol: __bad_mask

> >>> referenced by bitfield.h:119 (include/linux/bitfield.h:119)

> >>>               dma/qcom/gpi.o:(gpi_update_reg) in archive drivers/built-in.a

> >>> referenced by bitfield.h:119 (include/linux/bitfield.h:119)

> >>>               dma/qcom/gpi.o:(gpi_update_reg) in archive drivers/built-in.a

> 

> If gpi_update_reg is not inlined, the mask value will not be known at

> compile time so the check in field_multiplier stays in the final

> object file, causing the above linkage failure. Always inline

> gpi_update_reg so that this check can never fail.


Applied, thanks

-- 
~Vinod
patchwork-bot+linux-arm-msm@kernel.org March 1, 2021, 7:59 p.m. UTC | #2 
Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Tue, 12 Jan 2021 12:12:14 -0700 you wrote:
> When building with CONFIG_UBSAN_UNSIGNED_OVERFLOW, clang decides not to

> inline gpi_update_reg, which causes a linkage failure around __bad_mask:

> 

> ld.lld: error: undefined symbol: __bad_mask

> >>> referenced by bitfield.h:119 (include/linux/bitfield.h:119)

> >>>               dma/qcom/gpi.o:(gpi_update_reg) in archive drivers/built-in.a

> >>> referenced by bitfield.h:119 (include/linux/bitfield.h:119)

> >>>               dma/qcom/gpi.o:(gpi_update_reg) in archive drivers/built-in.a

> 

> [...]


Here is the summary with links:
  - dmaengine: qcom: Always inline gpi_update_reg
    https://git.kernel.org/qcom/c/0a6d3038d914

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 1a0bf6b0567a..e48eb397f433 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -584,7 +584,7 @@  static inline void gpi_write_reg_field(struct gpii *gpii, void __iomem *addr,
 	gpi_write_reg(gpii, addr, val);
 }
 
-static inline void
+static __always_inline void
 gpi_update_reg(struct gpii *gpii, u32 offset, u32 mask, u32 val)
 {
 	void __iomem *addr = gpii->regs + offset;