diff mbox series

[5.4,41/92] CDC-NCM: remove "connected" log message

Message ID	20210111130041.131012429@linuxfoundation.org
State	New
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Roland Dreier <roland@kernel.org>, Jakub Kicinski <kuba@kernel.org> Subject: [PATCH 5.4 41/92] CDC-NCM: remove "connected" log message Date: Mon, 11 Jan 2021 14:01:45 +0100 Message-Id: <20210111130041.131012429@linuxfoundation.org> In-Reply-To: <20210111130039.165470698@linuxfoundation.org> References: <20210111130039.165470698@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [5.4,04/92] scsi: ide: Do not set the RQF_PREEMPT flag for sense requests [5.4,05/92] scsi: scsi_transport_spi: Set RQF_PM for domain validation commands [5.4,12/92] net: mvpp2: Add TCAM entry to drop flow control pause frames [5.4,13/92] net: mvpp2: prs: fix PPPoE with ipv6 packet parse [5.4,14/92] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE [5.4,19/92] ibmvnic: continue fatal error reset after passive init [5.4,20/92] net: ethernet: mvneta: Fix error handling in mvneta_probe [5.4,24/92] net/ncsi: Use real net-device for response handler [5.4,25/92] net: ethernet: Fix memleak in ethoc_probe [5.4,27/92] net-sysfs: take the rtnl lock when accessing xps_cpus_map and num_tc [5.4,28/92] net-sysfs: take the rtnl lock when storing xps_rxqs [5.4,29/92] net-sysfs: take the rtnl lock when accessing xps_rxqs_map and num_tc [5.4,30/92] net: ethernet: ti: cpts: fix ethtool output when no ptp_clock registered [5.4,33/92] ipv4: Ignore ECN bits for fib lookups in fib_compute_spec_dst() [5.4,36/92] erspan: fix version 1 check in gre_parse_header() [5.4,38/92] r8169: work around power-saving bug on some chip versions [5.4,40/92] net: dsa: lantiq_gswip: Fix GSWIP_MII_CFG(p) register access [5.4,41/92] CDC-NCM: remove "connected" log message [5.4,48/92] video: hyperv_fb: Fix the mmap() regression for v5.4.y and older [5.4,49/92] crypto: ecdh - avoid buffer overflow in ecdh_set_secret() [5.4,50/92] crypto: asym_tpm: correct zero out potential secrets [5.4,52/92] staging: mt7621-dma: Fix a resource leak in an error handling path [5.4,54/92] USB: cdc-acm: blacklist another IR Droid device [5.4,55/92] USB: cdc-wdm: Fix use after free in service_outstanding_interrupt(). [5.4,56/92] usb: dwc3: ulpi: Use VStsDone to detect PHY regs access completion [5.4,57/92] usb: chipidea: ci_hdrc_imx: add missing put_device() call in usbmisc_get_init_data() [5.4,58/92] USB: xhci: fix U1/U2 handling for hardware with XHCI_INTEL_HOST quirk set [5.4,59/92] usb: usbip: vhci_hcd: protect shift size [5.4,60/92] usb: uas: Add PNY USB Portable SSD to unusual_uas [5.4,61/92] USB: serial: iuu_phoenix: fix DMA from stack [5.4,63/92] USB: serial: option: add Quectel EM160R-GL [5.4,64/92] USB: yurex: fix control-URB timeout handling [5.4,65/92] USB: usblp: fix DMA to stack [5.4,66/92] ALSA: usb-audio: Fix UBSAN warnings for MIDI jacks [5.4,67/92] usb: gadget: select CONFIG_CRC32 [5.4,68/92] usb: gadget: f_uac2: reset wMaxPacketSize [5.4,71/92] USB: gadget: legacy: fix return error code in acm_ms_bind() [5.4,72/92] usb: gadget: Fix spinlock lockup on usb_function_deactivate [5.4,73/92] usb: gadget: configfs: Preserve function ordering after bind failure [5.4,75/92] USB: serial: keyspan_pda: remove unused variable [5.4,77/92] kvm: check tlbs_dirty directly [5.4,79/92] ALSA: hda/conexant: add a new hda codec CX11970 [5.4,81/92] ALSA: hda/realtek: Enable mute and micmute LED on HP EliteBook 850 G7 [5.4,84/92] Revert "device property: Keep secondary firmware node secondary by type" [5.4,88/92] netfilter: ipset: fix shift-out-of-bounds in htable_bits() [5.4,92/92] KVM: x86: fix shift out of bounds reported by UBSAN

Commit Message

Greg Kroah-Hartman Jan. 11, 2021, 1:01 p.m. UTC

From: Roland Dreier <roland@kernel.org>

[ Upstream commit 59b4a8fa27f5a895582ada1ae5034af7c94a57b5 ]

The cdc_ncm driver passes network connection notifications up to
usbnet_link_change(), which is the right place for any logging.
Remove the netdev_info() duplicating this from the driver itself.

This stops devices such as my "TRENDnet USB 10/100/1G/2.5G LAN"
(ID 20f4:e02b) adapter from spamming the kernel log with

    cdc_ncm 2-2:2.0 enp0s2u2c2: network connection: connected

messages every 60 msec or so.

Signed-off-by: Roland Dreier <roland@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20201224032116.2453938-1-roland@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/net/usb/cdc_ncm.c |    3 ---
 1 file changed, 3 deletions(-)

diff mbox series

Patch

--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1625,9 +1625,6 @@  static void cdc_ncm_status(struct usbnet
 		 * USB_CDC_NOTIFY_NETWORK_CONNECTION notification shall be
 		 * sent by device after USB_CDC_NOTIFY_SPEED_CHANGE.
 		 */
-		netif_info(dev, link, dev->net,
-			   "network connection: %sconnected\n",
-			   !!event->wValue ? "" : "dis");
 		usbnet_link_change(dev, !!event->wValue, 0);
 		break;