| Message ID | 20210111085932.28680-1-m.felsch@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | net: phy: smsc: fix clk error handling | expand |
On Mon, Jan 11, 2021 at 09:59:32AM +0100, Marco Felsch wrote: > Commit bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in > support") added the phy clk support. The commit already checks if > clk_get_optional() throw an error but instead of returning the error it > ignores it. > > Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support") > Suggested-by: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Mon, 11 Jan 2021 15:17:05 +0100 Andrew Lunn wrote: > On Mon, Jan 11, 2021 at 09:59:32AM +0100, Marco Felsch wrote: > > Commit bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in > > support") added the phy clk support. The commit already checks if > > clk_get_optional() throw an error but instead of returning the error it > > ignores it. > > > > Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support") > > Suggested-by: Jakub Kicinski <kuba@kernel.org> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Applied, thanks!
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 0fc39ac5ca88..10722fed666d 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -284,7 +284,8 @@ static int smsc_phy_probe(struct phy_device *phydev) /* Make clk optional to keep DTB backward compatibility. */ priv->refclk = clk_get_optional(dev, NULL); if (IS_ERR(priv->refclk)) - dev_err_probe(dev, PTR_ERR(priv->refclk), "Failed to request clock\n"); + return dev_err_probe(dev, PTR_ERR(priv->refclk), + "Failed to request clock\n"); ret = clk_prepare_enable(priv->refclk); if (ret)
Commit bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support") added the phy clk support. The commit already checks if clk_get_optional() throw an error but instead of returning the error it ignores it. Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support") Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- drivers/net/phy/smsc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)