Message ID | CAD57uCfdEcjrvyYPASp1VPR-LRr=3fxMuMuXgVjZhzDwafT4cA@mail.gmail.com |
---|---|
State | New |
Headers | show |
On 27/08/14 09:04, Yvan Roux wrote: > Hi, > > as reported in PR62248 there is a typo in gcc/config.gcc where > --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in > config.gcc). Here is the patch to fix it. > > Thanks, > Yvan > > 2014-08-27 Yvan Roux <yvan.roux@linaro.org> > > * config.gcc: Fix fp-armv8 option for arm*-*-* targets. > > > pr62248.diff > > > diff --git a/gcc/config.gcc b/gcc/config.gcc > index 6862c127..3f68e3e 100644 > --- a/gcc/config.gcc > +++ b/gcc/config.gcc > @@ -3528,7 +3528,7 @@ case "${target}" in > | vfp | vfp3 | vfpv3 \ > | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \ > | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \ > - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \ > + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \ > | crypto-neon-fp-armv8) > # OK > ;; > Ok; but better still would be to change this to use the official list in arm-fpus.def (like we do for CPU names). R.
On 27 August 2014 11:24, Richard Earnshaw <rearnsha@arm.com> wrote: > On 27/08/14 09:04, Yvan Roux wrote: >> Hi, >> >> as reported in PR62248 there is a typo in gcc/config.gcc where >> --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in >> config.gcc). Here is the patch to fix it. >> >> Thanks, >> Yvan >> >> 2014-08-27 Yvan Roux <yvan.roux@linaro.org> >> >> * config.gcc: Fix fp-armv8 option for arm*-*-* targets. >> >> >> pr62248.diff >> >> >> diff --git a/gcc/config.gcc b/gcc/config.gcc >> index 6862c127..3f68e3e 100644 >> --- a/gcc/config.gcc >> +++ b/gcc/config.gcc >> @@ -3528,7 +3528,7 @@ case "${target}" in >> | vfp | vfp3 | vfpv3 \ >> | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \ >> | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \ >> - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \ >> + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \ >> | crypto-neon-fp-armv8) >> # OK >> ;; >> > > Ok; but better still would be to change this to use the official list in > arm-fpus.def (like we do for CPU names). Yes indeed, I'll do it that way.
diff --git a/gcc/config.gcc b/gcc/config.gcc index 6862c127..3f68e3e 100644 --- a/gcc/config.gcc +++ b/gcc/config.gcc @@ -3528,7 +3528,7 @@ case "${target}" in | vfp | vfp3 | vfpv3 \ | vfpv3-fp16 | vfpv3-d16 | vfpv3-d16-fp16 | vfpv3xd \ | vfpv3xd-fp16 | neon | neon-fp16 | vfpv4 | vfpv4-d16 \ - | fpv4-sp-d16 | neon-vfpv4 | fp-arm-v8 | neon-fp-armv8 \ + | fpv4-sp-d16 | neon-vfpv4 | fp-armv8 | neon-fp-armv8 \ | crypto-neon-fp-armv8) # OK ;;