| Message ID | 20210106150525.15403-4-andre.przywara@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/7] arm64: dts: allwinner: H6/A64: properly connect USB PHY to port 0 | expand |
On Wed, Jan 6, 2021 at 11:05 PM Andre Przywara <andre.przywara@arm.com> wrote: > > The SD card on the SoPine SoM module is somewhat concealed, so was > originally defined as "non-removable". > However there is a working card-detect pin, and in certain SoM base > boards it might be actually accessible at runtime. > Also the Pine64-LTS shares the SoPine base .dtsi, so inherited the > non-removable flag, even though the SD card slot is perfectly accessible > and usable there. (It turns out that just *my* board has a broken card > detect switch, so I originally thought CD wouldn't work on the LTS.) > > Drop the "non-removable" flag to describe the SD card slot properly. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Please add a fixes tag. This helps with finding the original commit that introduced the issue and backporting. ChenYu
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi index c48692b06e1f..3402cec87035 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi @@ -32,7 +32,6 @@ pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>; vmmc-supply = <®_dcdc1>; - non-removable; disable-wp; bus-width = <4>; cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
The SD card on the SoPine SoM module is somewhat concealed, so was originally defined as "non-removable". However there is a working card-detect pin, and in certain SoM base boards it might be actually accessible at runtime. Also the Pine64-LTS shares the SoPine base .dtsi, so inherited the non-removable flag, even though the SD card slot is perfectly accessible and usable there. (It turns out that just *my* board has a broken card detect switch, so I originally thought CD wouldn't work on the LTS.) Drop the "non-removable" flag to describe the SD card slot properly. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi | 1 - 1 file changed, 1 deletion(-)