diff mbox series

[v2,07/18] ARM: dts: qcom: sdx55: Add support for TCSR Mutex

Message ID 20210105122649.13581-8-manivannan.sadhasivam@linaro.org
State New
Headers show
Series Devicetree update for SDX55 platform | expand

Commit Message

Manivannan Sadhasivam Jan. 5, 2021, 12:26 p.m. UTC
Add TCSR Mutex node to support Qualcomm Hardware Mutex block on SDX55
platform.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

-- 
2.25.1

Comments

Vinod Koul Jan. 5, 2021, 3:52 p.m. UTC | #1
On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> Add TCSR Mutex node to support Qualcomm Hardware Mutex block on SDX55

> platform.


Reviewed-by: Vinod Koul <vkoul@kernel.org>


> 

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> ---

>  arch/arm/boot/dts/qcom-sdx55.dtsi | 11 +++++++++++

>  1 file changed, 11 insertions(+)

> 

> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi

> index 927f43a7414c..e48ec7a1971b 100644

> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi

> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi

> @@ -166,6 +166,17 @@ sdhc_1: sdhci@8804000 {

>  			status = "disabled";

>  		};

>  

> +		tcsr_mutex_block: syscon@1f40000 {

> +			compatible = "syscon";

> +			reg = <0x1f40000 0x20000>;

> +		};

> +

> +		tcsr_mutex: hwlock {

> +			compatible = "qcom,tcsr-mutex";

> +			syscon = <&tcsr_mutex_block 0 0x1000>;

> +			#hwlock-cells = <1>;

> +		};

> +

>  		pdc: interrupt-controller@b210000 {

>  			compatible = "qcom,sdx55-pdc", "qcom,pdc";

>  			reg = <0x0b210000 0x30000>;

> -- 

> 2.25.1


-- 
~Vinod
Bjorn Andersson Jan. 5, 2021, 6:20 p.m. UTC | #2
On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:

> Add TCSR Mutex node to support Qualcomm Hardware Mutex block on SDX55

> platform.

> 

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> ---

>  arch/arm/boot/dts/qcom-sdx55.dtsi | 11 +++++++++++

>  1 file changed, 11 insertions(+)

> 

> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi

> index 927f43a7414c..e48ec7a1971b 100644

> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi

> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi

> @@ -166,6 +166,17 @@ sdhc_1: sdhci@8804000 {

>  			status = "disabled";

>  		};

>  

> +		tcsr_mutex_block: syscon@1f40000 {

> +			compatible = "syscon";


It was recently determined that simply "syscon" isn't a valid
compatible.

> +			reg = <0x1f40000 0x20000>;

> +		};

> +

> +		tcsr_mutex: hwlock {

> +			compatible = "qcom,tcsr-mutex";


And in some platforms the tcsr_mutex_block seems to be single use
anyways, so I rewrote this binding a while ago.

So, this will still work in Linux, please update the patch to match the
new binding
(Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml)

Thanks,
Bjorn

> +			syscon = <&tcsr_mutex_block 0 0x1000>;

> +			#hwlock-cells = <1>;

> +		};

> +

>  		pdc: interrupt-controller@b210000 {

>  			compatible = "qcom,sdx55-pdc", "qcom,pdc";

>  			reg = <0x0b210000 0x30000>;

> -- 

> 2.25.1

>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 927f43a7414c..e48ec7a1971b 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -166,6 +166,17 @@  sdhc_1: sdhci@8804000 {
 			status = "disabled";
 		};
 
+		tcsr_mutex_block: syscon@1f40000 {
+			compatible = "syscon";
+			reg = <0x1f40000 0x20000>;
+		};
+
+		tcsr_mutex: hwlock {
+			compatible = "qcom,tcsr-mutex";
+			syscon = <&tcsr_mutex_block 0 0x1000>;
+			#hwlock-cells = <1>;
+		};
+
 		pdc: interrupt-controller@b210000 {
 			compatible = "qcom,sdx55-pdc", "qcom,pdc";
 			reg = <0x0b210000 0x30000>;