| Message ID | 1609836975-5758-1-git-send-email-loic.poulain@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] mhi: unconstify mhi_event_config | expand |
On Tue, Jan 05, 2021 at 09:56:14AM +0100, Loic Poulain wrote: > Some parameters may have to be determined at runtime. > It is the case for the event ring MSI vector. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > include/linux/mhi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index 62da830..48b1b2a 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -290,7 +290,7 @@ struct mhi_controller_config { > u32 num_channels; > const struct mhi_channel_config *ch_cfg; > u32 num_events; > - const struct mhi_event_config *event_cfg; > + struct mhi_event_config *event_cfg; > bool use_bounce_buf; > bool m2_no_db; > }; > -- > 2.7.4 >
Hi Loic, On 1/5/21 7:26 AM, Manivannan Sadhasivam wrote: > On Tue, Jan 05, 2021 at 09:56:14AM +0100, Loic Poulain wrote: >> Some parameters may have to be determined at runtime. >> It is the case for the event ring MSI vector. >> >> Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Thanks, > Mani > >> --- >> include/linux/mhi.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/mhi.h b/include/linux/mhi.h >> index 62da830..48b1b2a 100644 >> --- a/include/linux/mhi.h >> +++ b/include/linux/mhi.h >> @@ -290,7 +290,7 @@ struct mhi_controller_config { >> u32 num_channels; >> const struct mhi_channel_config *ch_cfg; >> u32 num_events; >> - const struct mhi_event_config *event_cfg; >> + struct mhi_event_config *event_cfg; Do we need to update mhi controller driver like ath11k and generic pci driver to avoid compiler warnings? >> bool use_bounce_buf; >> bool m2_no_db; >> }; >> -- >> 2.7.4 >> -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
diff --git a/include/linux/mhi.h b/include/linux/mhi.h index 62da830..48b1b2a 100644 --- a/include/linux/mhi.h +++ b/include/linux/mhi.h @@ -290,7 +290,7 @@ struct mhi_controller_config { u32 num_channels; const struct mhi_channel_config *ch_cfg; u32 num_events; - const struct mhi_event_config *event_cfg; + struct mhi_event_config *event_cfg; bool use_bounce_buf; bool m2_no_db; };
Some parameters may have to be determined at runtime. It is the case for the event ring MSI vector. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> --- include/linux/mhi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4