diff mbox series

[v2,1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector

Message ID 20210104124103.30930-2-kishon@ti.com
State New
Headers show
Series AM64: Add PCIe bindings and driver support | expand

Commit Message

Kishon Vijay Abraham I Jan. 4, 2021, 12:41 p.m. UTC
Add binding to represent refclk to the PCIe connector.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

---
 .../bindings/pci/ti,j721e-pci-host.yaml         | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

-- 
2.17.1

Comments

Rob Herring (Arm) Jan. 11, 2021, 10:31 p.m. UTC | #1
On Mon, Jan 04, 2021 at 06:11:00PM +0530, Kishon Vijay Abraham I wrote:
> Add binding to represent refclk to the PCIe connector.

> 

> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

> ---

>  .../bindings/pci/ti,j721e-pci-host.yaml         | 17 +++++++++++++----

>  1 file changed, 13 insertions(+), 4 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml

> index 0880a613ece6..7607018a115b 100644

> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml

> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml

> @@ -46,12 +46,21 @@ properties:

>      maxItems: 1

>  

>    clocks:

> -    maxItems: 1

> -    description: clock-specifier to represent input to the PCIe

> +    minItems: 1

> +    maxItems: 2

> +    description: clock-specifier to represent input to the PCIe for 1 item.

> +      2nd item if present represents reference clock to the connector.

>  

>    clock-names:

> -    items:

> -      - const: fck

> +    oneOf:

> +      - description: Represent input clock to the PCIe

> +        items:

> +          - const: fck

> +      - description: Represent input clock to the PCIe and reference clock to

> +          the connector.

> +        items:

> +          - const: fck

> +          - const: pcie_refclk


Can be just:

minItems: 1
items:
  - const: fck
  - const: pcie_refclk
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 0880a613ece6..7607018a115b 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -46,12 +46,21 @@  properties:
     maxItems: 1
 
   clocks:
-    maxItems: 1
-    description: clock-specifier to represent input to the PCIe
+    minItems: 1
+    maxItems: 2
+    description: clock-specifier to represent input to the PCIe for 1 item.
+      2nd item if present represents reference clock to the connector.
 
   clock-names:
-    items:
-      - const: fck
+    oneOf:
+      - description: Represent input clock to the PCIe
+        items:
+          - const: fck
+      - description: Represent input clock to the PCIe and reference clock to
+          the connector.
+        items:
+          - const: fck
+          - const: pcie_refclk
 
   vendor-id:
     const: 0x104c