diff mbox series

remoteproc: qcom: pil_info: avoid 64-bit division

Message ID 20210103135628.3702427-1-arnd@kernel.org
State Superseded
Headers show
Series remoteproc: qcom: pil_info: avoid 64-bit division | expand

Commit Message

Arnd Bergmann Jan. 3, 2021, 1:56 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>


On 32-bit machines with 64-bit resource_size_t, the driver causes
a link failure because of the 64-bit division:

arm-linux-gnueabi-ld: drivers/remoteproc/qcom_pil_info.o: in function `qcom_pil_info_store':
qcom_pil_info.c:(.text+0x1ec): undefined reference to `__aeabi_uldivmod'

Add a cast to an u32 to avoid this. If the resource exceeds 4GB,
there are bigger problems.

Fixes: 549b67da660d ("remoteproc: qcom: Introduce helper to store pil info in IMEM")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/remoteproc/qcom_pil_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.29.2

Comments

patchwork-bot+linux-arm-msm@kernel.org May 26, 2021, 7:03 p.m. UTC | #1 
Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Sun,  3 Jan 2021 14:56:12 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> 

> On 32-bit machines with 64-bit resource_size_t, the driver causes

> a link failure because of the 64-bit division:

> 

> arm-linux-gnueabi-ld: drivers/remoteproc/qcom_pil_info.o: in function `qcom_pil_info_store':

> qcom_pil_info.c:(.text+0x1ec): undefined reference to `__aeabi_uldivmod'

> 

> [...]


Here is the summary with links:
  - remoteproc: qcom: pil_info: avoid 64-bit division
    https://git.kernel.org/qcom/c/7029e7830277

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/remoteproc/qcom_pil_info.c b/drivers/remoteproc/qcom_pil_info.c
index 5521c4437ffa..7c007dd7b200 100644
--- a/drivers/remoteproc/qcom_pil_info.c
+++ b/drivers/remoteproc/qcom_pil_info.c
@@ -56,7 +56,7 @@  static int qcom_pil_info_init(void)
 	memset_io(base, 0, resource_size(&imem));
 
 	_reloc.base = base;
-	_reloc.num_entries = resource_size(&imem) / PIL_RELOC_ENTRY_SIZE;
+	_reloc.num_entries = (u32)resource_size(&imem) / PIL_RELOC_ENTRY_SIZE;
 
 	return 0;
 }