diff mbox series

ALSA: usb-audio: Add quirk for RC-505

Message ID 20210102190039.14494-1-tirei@agon.one
State New
Headers show
Series ALSA: usb-audio: Add quirk for RC-505 | expand

Commit Message

Timon Reinold Jan. 2, 2021, 7 p.m. UTC 
BOSS RC-505 (shown by lsusb as "Roland Corp. RC-505") does require the
same quirk as these other BOSS devices.

Without this quirk it is neither possible to capture audio from nor to
write audio to the RC-505. Both just result in an empty audio
stream. With these changes both capture and playback seem to work
quite fine. MIDI funtionality was not tested.

Tested-by: Harry Reinold <harry.reinold@posteo.de>
Signed-off-by: Timon Reinold <tirei@agon.one>
---

We found the hint to enable the same quirk as reqired by the BOSS
Katana for the RC-505 in this post:
https://old.reddit.com/r/linuxaudio/comments/fom7z4/roland_rc505_usb_audio_interface/frfgrfw/
But none of the code posted there was used (since that predates
implicit.c), so I think that shouldn't create any copyright
problems.

We're currently running the older version of this patch (without
implicit.c) on Linux Mint and it seems quite stable so far. We did
also test this version of the patch and that seems to work fine, too.

Yours sincerely,
Timon Reinold

 sound/usb/implicit.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Takashi Iwai Jan. 3, 2021, 8 a.m. UTC | #1 
On Sat, 02 Jan 2021 22:08:35 +0100,
Timon Reinold wrote:
> 
> BOSS RC-505 (shown by lsusb as "Roland Corp. RC-505") does require the
> same quirk as these other BOSS devices.
> 
> Without this quirk it is neither possible to capture audio from nor to
> write audio to the RC-505. Both just result in an empty audio
> stream. With these changes both capture and playback seem to work
> quite fine. MIDI funtionality was not tested.
> 
> Tested-by: Harry Reinold <harry.reinold@posteo.de>
> Signed-off-by: Timon Reinold <tirei@agon.one>
> ---
> 
> I just noticed that these entries should be sorted by ID. Sorry for that.

Thanks, applied now.


Takashi
diff mbox series

Patch

diff --git a/sound/usb/implicit.c b/sound/usb/implicit.c
index 70b9777b2e63..2d7f747c0237 100644
--- a/sound/usb/implicit.c
+++ b/sound/usb/implicit.c
@@ -79,6 +79,7 @@  static const struct snd_usb_implicit_fb_match playback_implicit_fb_quirks[] = {
 	IMPLICIT_FB_SKIP_DEV(0x0582, 0x01d8),	/* BOSS Katana */
 	IMPLICIT_FB_SKIP_DEV(0x0582, 0x01e5),	/* BOSS GT-001 */
 	IMPLICIT_FB_SKIP_DEV(0x0582, 0x0203),   /* BOSS AD-10 */
+	IMPLICIT_FB_SKIP_DEV(0x0582, 0x0171),   /* BOSS RC-505 */
 
 	{} /* terminator */
 };
@@ -91,6 +92,7 @@  static const struct snd_usb_implicit_fb_match capture_implicit_fb_quirks[] = {
 	IMPLICIT_FB_FIXED_DEV(0x0582, 0x01d8, 0x0d, 0x01), /* BOSS Katana */
 	IMPLICIT_FB_FIXED_DEV(0x0582, 0x01e5, 0x0d, 0x01), /* BOSS GT-001 */
 	IMPLICIT_FB_FIXED_DEV(0x0582, 0x0203, 0x0d, 0x01), /* BOSS AD-10 */
+	IMPLICIT_FB_FIXED_DEV(0x0582, 0x0171, 0x0d, 0x01), /* BOSS RC-505 */
 
 	{} /* terminator */
 };