| Message ID | cover.1408436940.git.riku.voipio@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On 19 August 2014 09:32, <riku.voipio@linaro.org> wrote: > From: Riku Voipio <riku.voipio@linaro.org> > > The same as previous series, except the patch "make binfmt flag O require P" > has been dropped. > > The following changes since commit 142f4ac5d5e024670ef4725e8943702b027e4218: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-08-15' into staging (2014-08-15 18:44:48 +0100) > > are available in the git repository at: > > git://git.linaro.org/people/riku.voipio/qemu.git linux-user-for-upstream > > for you to fetch changes up to 8349027af60e861fcc401c928eb76f9f418815d7: Hi. I'm afraid this doesn't build on my ARM board: /root/qemu/linux-user/syscall.c: In function 'do_open_by_handle_at': /root/qemu/linux-user/syscall.c:5475:16: error: 'p' may be used uninitialized in this function [-Werror=uninitialized] The compiler seems to be correct here -- we should be passing 'fh' to unlock_user(), not 'p' (which seems to be completely useless and should be deleted). This function and name_to_handle_at() also both seem to be missing the necessary guest-to-host byteswaps on the fields in struct file_handle. thanks -- PMM
On 19 August 2014 14:59, Peter Maydell <peter.maydell@linaro.org> wrote: > Hi. I'm afraid this doesn't build on my ARM board: > > /root/qemu/linux-user/syscall.c: In function 'do_open_by_handle_at': > /root/qemu/linux-user/syscall.c:5475:16: error: 'p' may be used > uninitialized in this function [-Werror=uninitialized] > The compiler seems to be correct here -- we should > be passing 'fh' to unlock_user(), not 'p' (which seems > to be completely useless and should be deleted). rat. I wonder how your older gcc on arm catches these regularly while the brand new gcc 4.9.1 from debian doesn't. > This function and name_to_handle_at() also both seem > to be missing the necessary guest-to-host byteswaps > on the fields in struct file_handle. ack, will fix. Riku
From: Riku Voipio <riku.voipio@linaro.org> The same as previous series, except the patch "make binfmt flag O require P" has been dropped. The following changes since commit 142f4ac5d5e024670ef4725e8943702b027e4218: Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-08-15' into staging (2014-08-15 18:44:48 +0100) are available in the git repository at: git://git.linaro.org/people/riku.voipio/qemu.git linux-user-for-upstream for you to fetch changes up to 8349027af60e861fcc401c928eb76f9f418815d7: linux-user: check return value of malloc() (2014-08-18 14:03:29 +0300) Jincheng Miao (1): linux-user: Fix syscall instruction usermode emulation on X86_64 Mike Frysinger (1): linux-user: fix readlink handling with magic exe symlink Mikhail Ilyin (1): linux-user: /proc/self/maps content Paul Burton (1): linux-user: support ioprio_{get, set} syscalls Peter Maydell (1): linux-user: Fix conversion of sigevent argument to timer_create Riku Voipio (4): linux-user: redirect openat calls linux-user: support timerfd_{create, gettime, settime} syscalls linux-user: support {name_to,open_by}_handle_at syscalls linux-user: add setns and unshare Tom Musta (13): linux-user: PPC64 semid_ds Doesnt Include _unused1 and _unused2 linux-user: Dereference Pointer Argument to ipc/semctl Sys Call linux-user: Properly Handle semun Structure In Cross-Endian Situations linux-user: Make ipc syscall's third argument an abi_long linux-user: Conditionally Pass Attribute Pointer to mq_open() linux-user: Detect Negative Message Sizes in msgsnd System Call linux-user: Handle NULL sched_param argument to sched_* linux-user: Detect fault in sched_rr_get_interval linux-user: Move get_ppc64_abi linux-user: Minimum Sig Handler Stack Size for PPC64 ELF V2 linux-user: clock_nanosleep errno Handling on PPC linux-user: Support target-to-host translation of mlockall argument linux-user: writev Partial Writes zhanghailiang (1): linux-user: check return value of malloc() configure | 37 +++++ include/exec/cpu-all.h | 2 + linux-user/aarch64/syscall.h | 3 + linux-user/alpha/syscall.h | 3 + linux-user/arm/syscall.h | 4 + linux-user/cris/syscall.h | 3 + linux-user/elfload.c | 9 -- linux-user/i386/syscall.h | 3 + linux-user/m68k/syscall.h | 4 + linux-user/main.c | 1 - linux-user/microblaze/syscall.h | 3 + linux-user/mips/syscall.h | 3 + linux-user/mips64/syscall.h | 3 + linux-user/openrisc/syscall.h | 4 + linux-user/ppc/syscall.h | 4 + linux-user/ppc/target_cpu.h | 10 ++ linux-user/s390x/syscall.h | 3 + linux-user/sh4/syscall.h | 4 + linux-user/signal.c | 12 +- linux-user/sparc/syscall.h | 3 + linux-user/sparc64/syscall.h | 3 + linux-user/strace.c | 30 ++++ linux-user/strace.list | 18 +++ linux-user/syscall.c | 347 ++++++++++++++++++++++++++++++++++------ linux-user/unicore32/syscall.h | 4 + linux-user/x86_64/syscall.h | 3 + target-i386/seg_helper.c | 4 +- 27 files changed, 462 insertions(+), 65 deletions(-)