diff mbox series

[net] selftests: mlxsw: Set headroom size of correct port

Message ID 20201230114251.394009-1-idosch@idosch.org
State New
Headers show
Series [net] selftests: mlxsw: Set headroom size of correct port | expand

Commit Message

Ido Schimmel Dec. 30, 2020, 11:42 a.m. UTC 
From: Ido Schimmel <idosch@nvidia.com>

The test was setting the headroom size of the wrong port. This was not
visible because of a firmware bug that canceled this bug.

Set the headroom size of the correct port, so that the test will pass
with both old and new firmware versions.

Fixes: bfa804784e32 ("selftests: mlxsw: Add a PFC test")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
---
 tools/testing/selftests/drivers/net/mlxsw/qos_pfc.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 4, 2021, 9:40 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 30 Dec 2020 13:42:51 +0200 you wrote:
> From: Ido Schimmel <idosch@nvidia.com>

> 

> The test was setting the headroom size of the wrong port. This was not

> visible because of a firmware bug that canceled this bug.

> 

> Set the headroom size of the correct port, so that the test will pass

> with both old and new firmware versions.

> 

> [...]


Here is the summary with links:
  - [net] selftests: mlxsw: Set headroom size of correct port
    https://git.kernel.org/netdev/net/c/2ff2c7e27439

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/tools/testing/selftests/drivers/net/mlxsw/qos_pfc.sh b/tools/testing/selftests/drivers/net/mlxsw/qos_pfc.sh
index 4d900bc1f76c..5c7700212f75 100755
--- a/tools/testing/selftests/drivers/net/mlxsw/qos_pfc.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/qos_pfc.sh
@@ -230,7 +230,7 @@  switch_create()
 	__mlnx_qos -i $swp4 --pfc=0,1,0,0,0,0,0,0 >/dev/null
 	# PG0 will get autoconfigured to Xoff, give PG1 arbitrarily 100K, which
 	# is (-2*MTU) about 80K of delay provision.
-	__mlnx_qos -i $swp3 --buffer_size=0,$_100KB,0,0,0,0,0,0 >/dev/null
+	__mlnx_qos -i $swp4 --buffer_size=0,$_100KB,0,0,0,0,0,0 >/dev/null
 
 	# bridges
 	# -------