diff mbox series

[1/2] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Add support for RZ/G2 M/N/H

Message ID 20201228202221.2327468-1-aford173@gmail.com
State Accepted
Commit c706121386fe8414ac0a0acab37c74aac698c51d
Headers show
Series [1/2] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Add support for RZ/G2 M/N/H | expand

Commit Message

Adam Ford Dec. 28, 2020, 8:22 p.m. UTC
The datasheet for the RZ/G2 Series show the bit for choosing between a crystal
oscillator and an external oscillator is present.  Add the bindings for
r8a774a1 (RZ/G2M), r8a774b1 (RZ/G2N), and r8a774e1 (RZ/G2H)

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Geert Uytterhoeven Jan. 8, 2021, 2:03 p.m. UTC | #1
On Mon, Dec 28, 2020 at 9:22 PM Adam Ford <aford173@gmail.com> wrote:
> The datasheet for the RZ/G2 Series show the bit for choosing between a crystal

> oscillator and an external oscillator is present.  Add the bindings for

> r8a774a1 (RZ/G2M), r8a774b1 (RZ/G2N), and r8a774e1 (RZ/G2H)

>

> Signed-off-by: Adam Ford <aford173@gmail.com>


Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Geert Uytterhoeven Jan. 8, 2021, 2:10 p.m. UTC | #2
On Mon, Dec 28, 2020 at 9:22 PM Adam Ford <aford173@gmail.com> wrote:
> Per the reference manal for the RZ/G Series, 2nd Generation,


manual

> the RZ/G2M, RZ/G2N, and RZ/G2H have a bit that can be set to

> choose between a crystal oscillator and an external oscillator.

>

> Because only boards that need this should enable it, it's marked

> as disabled by default for backwards compatibility with existing

> boards.

>

> Signed-off-by: Adam Ford <aford173@gmail.com>


Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

i.e. will queue in renesas-devel for v5.12 (with the typo fixed).


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Geert Uytterhoeven Jan. 9, 2021, 9:29 a.m. UTC | #3
On Fri, Jan 8, 2021 at 3:10 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, Dec 28, 2020 at 9:22 PM Adam Ford <aford173@gmail.com> wrote:

> > Per the reference manal for the RZ/G Series, 2nd Generation,

>

> manual

>

> > the RZ/G2M, RZ/G2N, and RZ/G2H have a bit that can be set to

> > choose between a crystal oscillator and an external oscillator.

> >

> > Because only boards that need this should enable it, it's marked

> > as disabled by default for backwards compatibility with existing

> > boards.

> >

> > Signed-off-by: Adam Ford <aford173@gmail.com>

>

> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> i.e. will queue in renesas-devel for v5.12 (with the typo fixed).


(and the unneeded 'status = "disabled"' dropped).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Geert Uytterhoeven Jan. 9, 2021, 9:30 a.m. UTC | #4
On Sat, Jan 9, 2021 at 10:29 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Fri, Jan 8, 2021 at 3:10 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> > On Mon, Dec 28, 2020 at 9:22 PM Adam Ford <aford173@gmail.com> wrote:

> > > Per the reference manal for the RZ/G Series, 2nd Generation,

> >

> > manual

> >

> > > the RZ/G2M, RZ/G2N, and RZ/G2H have a bit that can be set to

> > > choose between a crystal oscillator and an external oscillator.

> > >

> > > Because only boards that need this should enable it, it's marked

> > > as disabled by default for backwards compatibility with existing

> > > boards.

> > >

> > > Signed-off-by: Adam Ford <aford173@gmail.com>

> >

> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> > i.e. will queue in renesas-devel for v5.12 (with the typo fixed).

>

> (and the unneeded 'status = "disabled"' dropped).


Please disregard that. Lazy Saturday morning...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Rob Herring Jan. 11, 2021, 8:14 p.m. UTC | #5
On Mon, 28 Dec 2020 14:22:20 -0600, Adam Ford wrote:
> The datasheet for the RZ/G2 Series show the bit for choosing between a crystal

> oscillator and an external oscillator is present.  Add the bindings for

> r8a774a1 (RZ/G2M), r8a774b1 (RZ/G2N), and r8a774e1 (RZ/G2H)

> 

> Signed-off-by: Adam Ford <aford173@gmail.com>

> 


Acked-by: Rob Herring <robh@kernel.org>
Geert Uytterhoeven Jan. 12, 2021, 8:39 a.m. UTC | #6
On Mon, Jan 11, 2021 at 9:14 PM Rob Herring <robh@kernel.org> wrote:
> On Mon, 28 Dec 2020 14:22:20 -0600, Adam Ford wrote:

> > The datasheet for the RZ/G2 Series show the bit for choosing between a crystal

> > oscillator and an external oscillator is present.  Add the bindings for

> > r8a774a1 (RZ/G2M), r8a774b1 (RZ/G2N), and r8a774e1 (RZ/G2H)

> >

> > Signed-off-by: Adam Ford <aford173@gmail.com>

> >

>

> Acked-by: Rob Herring <robh@kernel.org>


Thanks, will queue in renesas-clk-for-v5.12.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml
index 5be1229b3d6e..6eaabb4d82ec 100644
--- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml
+++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.yaml
@@ -35,6 +35,9 @@  properties:
   compatible:
     items:
       - enum:
+          - renesas,r8a774a1-rcar-usb2-clock-sel # RZ/G2M
+          - renesas,r8a774b1-rcar-usb2-clock-sel # RZ/G2N
+          - renesas,r8a774e1-rcar-usb2-clock-sel # RZ/G2H
           - renesas,r8a7795-rcar-usb2-clock-sel  # R-Car H3
           - renesas,r8a7796-rcar-usb2-clock-sel  # R-Car M3-W
           - renesas,r8a77961-rcar-usb2-clock-sel # R-Car M3-W+