diff mbox series

[1/3] common: Makefile: drop duplicated line

Message ID 20201228121313.16520-1-peng.fan@oss.nxp.com
State New
Headers show
Series [1/3] common: Makefile: drop duplicated line | expand

Commit Message

Peng Fan (OSS) Dec. 28, 2020, 12:13 p.m. UTC
From: Peng Fan <peng.fan@nxp.com>


obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there,
no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o

Signed-off-by: Peng Fan <peng.fan@nxp.com>

---
 common/Makefile | 1 -
 1 file changed, 1 deletion(-)

-- 
2.28.0

Comments

Simon Glass Dec. 29, 2020, 3:32 a.m. UTC | #1
On Mon, 28 Dec 2020 at 04:44, Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>

> From: Peng Fan <peng.fan@nxp.com>

>

> obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there,

> no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o

>

> Signed-off-by: Peng Fan <peng.fan@nxp.com>

> ---

>  common/Makefile | 1 -

>  1 file changed, 1 deletion(-)


Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Jan. 18, 2021, 1:01 p.m. UTC | #2
On Mon, Dec 28, 2020 at 08:13:11PM +0800, Peng Fan (OSS) wrote:

> From: Peng Fan <peng.fan@nxp.com>

> 

> obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there,

> no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o

> 

> Signed-off-by: Peng Fan <peng.fan@nxp.com>

> Reviewed-by: Simon Glass <sjg@chromium.org>


Applied to u-boot/master, thanks!

-- 
Tom
diff mbox series

Patch

diff --git a/common/Makefile b/common/Makefile
index bcf352d016..daeea67cf2 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -68,7 +68,6 @@  obj-$(CONFIG_DFU_OVER_USB) += dfu.o
 endif
 obj-$(CONFIG_SPL_HASH_SUPPORT) += hash.o
 obj-$(CONFIG_TPL_HASH_SUPPORT) += hash.o
-obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o
 obj-$(CONFIG_SPL_LOAD_FIT) += common_fit.o
 obj-$(CONFIG_SPL_NET_SUPPORT) += miiphyutil.o
 obj-$(CONFIG_$(SPL_TPL_)OF_LIBFDT) += fdt_support.o