diff mbox series

[1/5] dt-bindings: i2c: renesas,i2c: add r8a779a0 (V3U) support

Message ID 20201223172505.34736-2-wsa+renesas@sang-engineering.com
State Accepted
Commit 8627537ce04483641ca783c10578d0fb33bd239a
Headers show
Series v3u: enable I2C0-6 | expand

Commit Message

Wolfram Sang Dec. 23, 2020, 5:25 p.m. UTC
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 Documentation/devicetree/bindings/i2c/renesas,i2c.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven Jan. 5, 2021, 12:30 p.m. UTC | #1
On Wed, Dec 23, 2020 at 6:27 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>


> --- a/Documentation/devicetree/bindings/i2c/renesas,i2c.txt

> +++ b/Documentation/devicetree/bindings/i2c/renesas,i2c.txt

> @@ -26,6 +26,7 @@ Required properties:

>         "renesas,i2c-r8a77980" if the device is a part of a R8A77980 SoC.

>         "renesas,i2c-r8a77990" if the device is a part of a R8A77990 SoC.

>         "renesas,i2c-r8a77995" if the device is a part of a R8A77995 SoC.

> +       "renesas,i2c-r8a779a0" if the device is a part of a R8A779A0 SoC.

>         "renesas,rcar-gen1-i2c" for a generic R-Car Gen1 compatible device.

>         "renesas,rcar-gen2-i2c" for a generic R-Car Gen2 or RZ/G1 compatible

>                                 device.


Note that this doesn't say anything about (in)compatibility with generic
R-Car Gen3 compatible devices (hint: yaml conversion?).

New features:
  - Slave Clock Stretch Select,
  - Fast Mode+ Enable,
  - Enhanced First Bit Setup Cycle configuration.

Looks like the R-Car V3U variant can be treated as a generic R-Car Gen3
variant (lacking the new features, of course).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Rob Herring (Arm) Jan. 8, 2021, 2:38 a.m. UTC | #2
On Wed, 23 Dec 2020 18:25:00 +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  Documentation/devicetree/bindings/i2c/renesas,i2c.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Wolfram Sang Jan. 17, 2021, 11:34 a.m. UTC | #3
On Wed, Dec 23, 2020 at 06:25:00PM +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied to for-next, thanks!
Wolfram Sang Jan. 17, 2021, 11:44 a.m. UTC | #4
> New features:
>   - Slave Clock Stretch Select,
>   - Fast Mode+ Enable,
>   - Enhanced First Bit Setup Cycle configuration.
> 
> Looks like the R-Car V3U variant can be treated as a generic R-Car Gen3
> variant (lacking the new features, of course).

FM+ doesn't need an update. It will just handle higher values for the
bus frequency. This is also the most likely one to be supported in
Linux. First Bit setup is not even supported yet in the basic version.
Configuration via Linux is unclear same as SlaveClockStretch. Use cases
are unclear, too, which we would need for implementating any of this.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/renesas,i2c.txt b/Documentation/devicetree/bindings/i2c/renesas,i2c.txt
index 96d869ac3839..5762d2d1ab9c 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,i2c.txt
+++ b/Documentation/devicetree/bindings/i2c/renesas,i2c.txt
@@ -26,6 +26,7 @@  Required properties:
 	"renesas,i2c-r8a77980" if the device is a part of a R8A77980 SoC.
 	"renesas,i2c-r8a77990" if the device is a part of a R8A77990 SoC.
 	"renesas,i2c-r8a77995" if the device is a part of a R8A77995 SoC.
+	"renesas,i2c-r8a779a0" if the device is a part of a R8A779A0 SoC.
 	"renesas,rcar-gen1-i2c" for a generic R-Car Gen1 compatible device.
 	"renesas,rcar-gen2-i2c" for a generic R-Car Gen2 or RZ/G1 compatible
 				device.