| Message ID | 20201222001103.3112306-1-bjorn.andersson@linaro.org |
|---|---|
| State | Accepted |
| Commit | 93f2a11580a9732c1d90f9e01a7e9facc825658f |
| Headers | show |
| Series | arm64: dts: qcom: sdm845: Reserve LPASS clocks in gcc | expand |
On 21-12-20, 16:11, Bjorn Andersson wrote: > The GCC_LPASS_Q6_AXI_CLK and GCC_LPASS_SWAY_CLK clocks may not be > touched on a typical UEFI based SDM845 device, but when the kernel is > built with CONFIG_SDM_LPASSCC_845 this happens, unless they are marked > as protected-clocks in the DT. > > This was done for the MTP and the Pocophone, but not for DB845c and the > Lenovo Yoga C630 - causing these to fail to boot if the LPASS clock > controller is enabled (which it typically isn't). Reviewed-by: Vinod Koul <vkoul@kernel.org> Tested-by: Vinod Koul <vkoul@kernel.org> #on db845c -- ~Vinod
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Mon, 21 Dec 2020 16:11:03 -0800 you wrote: > The GCC_LPASS_Q6_AXI_CLK and GCC_LPASS_SWAY_CLK clocks may not be > touched on a typical UEFI based SDM845 device, but when the kernel is > built with CONFIG_SDM_LPASSCC_845 this happens, unless they are marked > as protected-clocks in the DT. > > This was done for the MTP and the Pocophone, but not for DB845c and the > Lenovo Yoga C630 - causing these to fail to boot if the LPASS clock > controller is enabled (which it typically isn't). > > [...] Here is the summary with links: - arm64: dts: qcom: sdm845: Reserve LPASS clocks in gcc https://git.kernel.org/qcom/c/93f2a11580a9 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index 7cc236575ee2..c0b93813ea9a 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -415,7 +415,9 @@ &dsi0_phy { &gcc { protected-clocks = <GCC_QSPI_CORE_CLK>, <GCC_QSPI_CORE_CLK_SRC>, - <GCC_QSPI_CNOC_PERIPH_AHB_CLK>; + <GCC_QSPI_CNOC_PERIPH_AHB_CLK>, + <GCC_LPASS_Q6_AXI_CLK>, + <GCC_LPASS_SWAY_CLK>; }; &gpu { diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts index 13fdd02cffe6..87ffbb89fbc7 100644 --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts @@ -302,7 +302,9 @@ &dsi0_phy { &gcc { protected-clocks = <GCC_QSPI_CORE_CLK>, <GCC_QSPI_CORE_CLK_SRC>, - <GCC_QSPI_CNOC_PERIPH_AHB_CLK>; + <GCC_QSPI_CNOC_PERIPH_AHB_CLK>, + <GCC_LPASS_Q6_AXI_CLK>, + <GCC_LPASS_SWAY_CLK>; }; &gpu {
The GCC_LPASS_Q6_AXI_CLK and GCC_LPASS_SWAY_CLK clocks may not be touched on a typical UEFI based SDM845 device, but when the kernel is built with CONFIG_SDM_LPASSCC_845 this happens, unless they are marked as protected-clocks in the DT. This was done for the MTP and the Pocophone, but not for DB845c and the Lenovo Yoga C630 - causing these to fail to boot if the LPASS clock controller is enabled (which it typically isn't). Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 +++- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) -- 2.29.2