| Message ID | a930ccca2f9a5dc49f24c46c3f4280c4de960f9d.1608216796.git.agx@sigxcpu.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Config and device tree updates for the Librem 5 devkit | expand |
On Thu, Dec 17, 2020 at 04:13:13PM +0100, Guido Günther wrote: > BUCK3 needs a regulator-enable-ramp-delay since otherwise the board > freezes on etnaviv probe. With this pgc_gpu suspends and resumes as > expected. This must have been always broken since gpcv2 support was > enabled. > > We also enable all the regulators needed for Deep Sleep Mode (DSM) as > always-on: > > - VDD_SOC supplied by BUCK1 > - VDDA_1P8 supplied by BUCK7 > - VDDA_0P9 supplied by LDO4 > - VDDA_DRAM supplied by LDO3 > - NVCC_DRAM supplied by BUCK8 > - VDD_DRAM supplied by BUCK5 > > Finally LDO5 and LDO6 provide VDD_PHY_1V8 and VDD_PHY_0V9 used by the > SOCs MIPI, HDMI and USB IP cores. While we would in theory be able to > turn these off (and I've tested that or LDO6 and mipi with USB disabled) > it is of little practical use atm since USB doesn't runtime suspend so > let's revisit this at a later point. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > --- > .../boot/dts/freescale/imx8mq-librem5-devkit.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Thu, Dec 17, 2020 at 04:13:13PM +0100, Guido Günther wrote: > BUCK3 needs a regulator-enable-ramp-delay since otherwise the board > freezes on etnaviv probe. With this pgc_gpu suspends and resumes as > expected. This must have been always broken since gpcv2 support was > enabled. > > We also enable all the regulators needed for Deep Sleep Mode (DSM) as > always-on: > > - VDD_SOC supplied by BUCK1 > - VDDA_1P8 supplied by BUCK7 > - VDDA_0P9 supplied by LDO4 > - VDDA_DRAM supplied by LDO3 > - NVCC_DRAM supplied by BUCK8 > - VDD_DRAM supplied by BUCK5 > > Finally LDO5 and LDO6 provide VDD_PHY_1V8 and VDD_PHY_0V9 used by the > SOCs MIPI, HDMI and USB IP cores. While we would in theory be able to > turn these off (and I've tested that or LDO6 and mipi with USB disabled) > it is of little practical use atm since USB doesn't runtime suspend so > let's revisit this at a later point. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> Applied, thanks.
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts index af139b283daf..f35d6897fbf7 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts @@ -298,6 +298,7 @@ buck1_reg: BUCK1 { regulator-min-microvolt = <700000>; regulator-max-microvolt = <1300000>; regulator-boot-on; + regulator-always-on; regulator-ramp-delay = <1250>; rohm,dvs-run-voltage = <900000>; rohm,dvs-idle-voltage = <850000>; @@ -319,6 +320,7 @@ buck3_reg: BUCK3 { regulator-min-microvolt = <700000>; regulator-max-microvolt = <1300000>; regulator-boot-on; + regulator-enable-ramp-delay = <200>; rohm,dvs-run-voltage = <900000>; }; @@ -334,6 +336,7 @@ buck5_reg: BUCK5 { regulator-min-microvolt = <700000>; regulator-max-microvolt = <1350000>; regulator-boot-on; + regulator-always-on; }; buck6_reg: BUCK6 { @@ -341,6 +344,7 @@ buck6_reg: BUCK6 { regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3300000>; regulator-boot-on; + regulator-always-on; }; buck7_reg: BUCK7 { @@ -348,6 +352,7 @@ buck7_reg: BUCK7 { regulator-min-microvolt = <1605000>; regulator-max-microvolt = <1995000>; regulator-boot-on; + regulator-always-on; }; buck8_reg: BUCK8 { @@ -355,6 +360,7 @@ buck8_reg: BUCK8 { regulator-min-microvolt = <800000>; regulator-max-microvolt = <1400000>; regulator-boot-on; + regulator-always-on; }; ldo1_reg: LDO1 { @@ -380,6 +386,7 @@ ldo3_reg: LDO3 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; regulator-boot-on; + regulator-always-on; }; ldo4_reg: LDO4 { @@ -387,12 +394,14 @@ ldo4_reg: LDO4 { regulator-min-microvolt = <900000>; regulator-max-microvolt = <1800000>; regulator-boot-on; + regulator-always-on; }; ldo5_reg: LDO5 { regulator-name = "ldo5"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; + regulator-always-on; }; ldo6_reg: LDO6 { @@ -400,6 +409,7 @@ ldo6_reg: LDO6 { regulator-min-microvolt = <900000>; regulator-max-microvolt = <1800000>; regulator-boot-on; + regulator-always-on; }; ldo7_reg: LDO7 { @@ -407,6 +417,7 @@ ldo7_reg: LDO7 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; regulator-boot-on; + regulator-always-on; }; }; };
BUCK3 needs a regulator-enable-ramp-delay since otherwise the board freezes on etnaviv probe. With this pgc_gpu suspends and resumes as expected. This must have been always broken since gpcv2 support was enabled. We also enable all the regulators needed for Deep Sleep Mode (DSM) as always-on: - VDD_SOC supplied by BUCK1 - VDDA_1P8 supplied by BUCK7 - VDDA_0P9 supplied by LDO4 - VDDA_DRAM supplied by LDO3 - NVCC_DRAM supplied by BUCK8 - VDD_DRAM supplied by BUCK5 Finally LDO5 and LDO6 provide VDD_PHY_1V8 and VDD_PHY_0V9 used by the SOCs MIPI, HDMI and USB IP cores. While we would in theory be able to turn these off (and I've tested that or LDO6 and mipi with USB disabled) it is of little practical use atm since USB doesn't runtime suspend so let's revisit this at a later point. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- .../boot/dts/freescale/imx8mq-librem5-devkit.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)