| Message ID | 20201217151200.1179555-1-robert.foss@linaro.org |
|---|---|
| State | Accepted |
| Commit | d4863ef399a29cae3001b3fedfd2864e651055ba |
| Headers | show |
| Series | [v1] arm64: dts: qcom: sdm845-db845c: Fix reset-pin of ov8856 node | expand |
On Thu 17 Dec 07:12 PST 2020, Robert Foss wrote: > Switch reset pin of ov8856 node from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW, > this issue prevented the ov8856 from probing properly as it does not respond > to I2C messages. > > Fixes: d4919a44564b ("arm64: dts: qcom: sdm845-db845c: Add ov8856 & ov7251 > camera nodes") > > Signed-off-by: Robert Foss <robert.foss@linaro.org> > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index 7cc236575ee2..a943b3f353ce 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -1112,11 +1112,11 @@ camera@10 { > reg = <0x10>; > > // CAM0_RST_N > - reset-gpios = <&tlmm 9 0>; > + reset-gpios = <&tlmm 9 1>; Please do use GPIO_ACTIVE_LOW as the argument... Regards, Bjorn > pinctrl-names = "default"; > pinctrl-0 = <&cam0_default>; > gpios = <&tlmm 13 0>, > - <&tlmm 9 0>; > + <&tlmm 9 1>; > > clocks = <&clock_camcc CAM_CC_MCLK0_CLK>; > clock-names = "xvclk"; > -- > 2.27.0 >
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index 7cc236575ee2..a943b3f353ce 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -1112,11 +1112,11 @@ camera@10 { reg = <0x10>; // CAM0_RST_N - reset-gpios = <&tlmm 9 0>; + reset-gpios = <&tlmm 9 1>; pinctrl-names = "default"; pinctrl-0 = <&cam0_default>; gpios = <&tlmm 13 0>, - <&tlmm 9 0>; + <&tlmm 9 1>; clocks = <&clock_camcc CAM_CC_MCLK0_CLK>; clock-names = "xvclk";
Switch reset pin of ov8856 node from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW, this issue prevented the ov8856 from probing properly as it does not respond to I2C messages. Fixes: d4919a44564b ("arm64: dts: qcom: sdm845-db845c: Add ov8856 & ov7251 camera nodes") Signed-off-by: Robert Foss <robert.foss@linaro.org> --- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0