| Message ID | 20201216131639.4128-5-stanley.chu@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | None | expand |
On 2020-12-16 21:16, Stanley Chu wrote: > Fix build warnings as below due to incorrect function description > of ufshcd_try_to_abort_task(). > > ufshcd.c:6651: warning: Function parameter or member 'hba' not > described in 'ufshcd_try_to_abort_task' > ufshcd.c:6651: warning: Function parameter or member 'tag' not > described in 'ufshcd_try_to_abort_task' > ufshcd.c:6651: warning: Excess function parameter 'cmd' description in > 'ufshcd_try_to_abort_task' > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- > drivers/scsi/ufs/ufshcd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index ce0528f2e2ed..79287fdd049b 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -6652,7 +6652,8 @@ static void ufshcd_set_req_abort_skip(struct > ufs_hba *hba, unsigned long bitmap) > > /** > * ufshcd_try_to_abort_task - abort a specific task > - * @cmd: SCSI command pointer > + * @hba: per adapter instance > + * @tag: position of the bit to be aborted > * > * Abort the pending command in device by sending UFS_ABORT_TASK task > management > * command, and in host controller by clearing the door-bell > register. There can Thanks for the fix. Reviewed-by: Can Guo <cang@codeaurora.org>
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index ce0528f2e2ed..79287fdd049b 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6652,7 +6652,8 @@ static void ufshcd_set_req_abort_skip(struct ufs_hba *hba, unsigned long bitmap) /** * ufshcd_try_to_abort_task - abort a specific task - * @cmd: SCSI command pointer + * @hba: per adapter instance + * @tag: position of the bit to be aborted * * Abort the pending command in device by sending UFS_ABORT_TASK task management * command, and in host controller by clearing the door-bell register. There can
Fix build warnings as below due to incorrect function description of ufshcd_try_to_abort_task(). ufshcd.c:6651: warning: Function parameter or member 'hba' not described in 'ufshcd_try_to_abort_task' ufshcd.c:6651: warning: Function parameter or member 'tag' not described in 'ufshcd_try_to_abort_task' ufshcd.c:6651: warning: Excess function parameter 'cmd' description in 'ufshcd_try_to_abort_task' Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> --- drivers/scsi/ufs/ufshcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)