| Message ID | 20201215020004.731239-1-swboyd@chromium.org |
|---|---|
| State | Accepted |
| Commit | 8d079bf20410aeb2cc714d8781d3a0930f85448f |
| Headers | show |
| Series | arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det | expand |
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Mon, 14 Dec 2020 18:00:04 -0800 you wrote: > We shouldn't put any pinconf here in case someone decides to invert this > HPD signal or remove an external pull-down. It's better to leave that to > the board pinconf nodes, so drop it here. > > Reported-by: Douglas Anderson <dianders@chromium.org> > Cc: Tanmay Shah <tanmay@codeaurora.org> > Fixes: 681a607ad21a ("arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node") > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > [...] Here is the summary with links: - arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det https://git.kernel.org/qcom/c/8d079bf20410 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 22b832fc62e3..268fa40a1774 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1468,12 +1468,6 @@ pinmux { pins = "gpio117"; function = "dp_hot"; }; - - pinconf { - pins = "gpio117"; - bias-disable; - input-enable; - }; }; qspi_clk: qspi-clk {
We shouldn't put any pinconf here in case someone decides to invert this HPD signal or remove an external pull-down. It's better to leave that to the board pinconf nodes, so drop it here. Reported-by: Douglas Anderson <dianders@chromium.org> Cc: Tanmay Shah <tanmay@codeaurora.org> Fixes: 681a607ad21a ("arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node") Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ------ 1 file changed, 6 deletions(-)