[5.9,061/105] soc: fsl: dpio: Get the cpumask through cpumask_of(cpu)

From: Hao Si <si.hao@zte.com.cn>

From: Hao Si <si.hao@zte.com.cn>

[ Upstream commit 2663b3388551230cbc4606a40fabf3331ceb59e4 ]

The local variable 'cpumask_t mask' is in the stack memory, and its address
is assigned to 'desc->affinity' in 'irq_set_affinity_hint()'.
But the memory area where this variable is located is at risk of being
modified.

During LTP testing, the following error was generated:

Unable to handle kernel paging request at virtual address ffff000012e9b790
Mem abort info:
  ESR = 0x96000007
  Exception class = DABT (current EL), IL = 32 bits
  SET = 0, FnV = 0
  EA = 0, S1PTW = 0
Data abort info:
  ISV = 0, ISS = 0x00000007
  CM = 0, WnR = 0
swapper pgtable: 4k pages, 48-bit VAs, pgdp = 0000000075ac5e07
[ffff000012e9b790] pgd=00000027dbffe003, pud=00000027dbffd003,
pmd=00000027b6d61003, pte=0000000000000000
Internal error: Oops: 96000007 [#1] PREEMPT SMP
Modules linked in: xt_conntrack
Process read_all (pid: 20171, stack limit = 0x0000000044ea4095)
CPU: 14 PID: 20171 Comm: read_all Tainted: G    B   W
Hardware name: NXP Layerscape LX2160ARDB (DT)
pstate: 80000085 (Nzcv daIf -PAN -UAO)
pc : irq_affinity_hint_proc_show+0x54/0xb0
lr : irq_affinity_hint_proc_show+0x4c/0xb0
sp : ffff00001138bc10
x29: ffff00001138bc10 x28: 0000ffffd131d1e0
x27: 00000000007000c0 x26: ffff8025b9480dc0
x25: ffff8025b9480da8 x24: 00000000000003ff
x23: ffff8027334f8300 x22: ffff80272e97d000
x21: ffff80272e97d0b0 x20: ffff8025b9480d80
x19: ffff000009a49000 x18: 0000000000000000
x17: 0000000000000000 x16: 0000000000000000
x15: 0000000000000000 x14: 0000000000000000
x13: 0000000000000000 x12: 0000000000000040
x11: 0000000000000000 x10: ffff802735b79b88
x9 : 0000000000000000 x8 : 0000000000000000
x7 : ffff000009a49848 x6 : 0000000000000003
x5 : 0000000000000000 x4 : ffff000008157d6c
x3 : ffff00001138bc10 x2 : ffff000012e9b790
x1 : 0000000000000000 x0 : 0000000000000000
Call trace:
 irq_affinity_hint_proc_show+0x54/0xb0
 seq_read+0x1b0/0x440
 proc_reg_read+0x80/0xd8
 __vfs_read+0x60/0x178
 vfs_read+0x94/0x150
 ksys_read+0x74/0xf0
 __arm64_sys_read+0x24/0x30
 el0_svc_common.constprop.0+0xd8/0x1a0
 el0_svc_handler+0x34/0x88
 el0_svc+0x10/0x14
Code: f9001bbf 943e0732 f94066c2 b4000062 (f9400041)
---[ end trace b495bdcb0b3b732b ]---
Kernel panic - not syncing: Fatal exception
SMP: stopping secondary CPUs
SMP: failed to stop secondary CPUs 0,2-4,6,8,11,13-15
Kernel Offset: disabled
CPU features: 0x0,21006008
Memory Limit: none
---[ end Kernel panic - not syncing: Fatal exception ]---

Fix it by using 'cpumask_of(cpu)' to get the cpumask.

Signed-off-by: Hao Si <si.hao@zte.com.cn>
Signed-off-by: Lin Chen <chen.lin5@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/soc/fsl/dpio/dpio-driver.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Message ID	20201214172558.202616005@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Hao Si <si.hao@zte.com.cn>, Lin Chen <chen.lin5@zte.com.cn>, Yi Wang <wang.yi59@zte.com.cn>, Li Yang <leoyang.li@nxp.com>, Sasha Levin <sashal@kernel.org> Subject: [PATCH 5.9 061/105] soc: fsl: dpio: Get the cpumask through cpumask_of(cpu) Date: Mon, 14 Dec 2020 18:28:35 +0100 Message-Id: <20201214172558.202616005@linuxfoundation.org> In-Reply-To: <20201214172555.280929671@linuxfoundation.org> References: <20201214172555.280929671@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [5.9,002/105] mm/zsmalloc.c: drop ZSMALLOC_PGTABLE_MAPPING [5.9,005/105] ASoC: Intel: bytcr_rt5640: Fix HP Pavilion x2 Detachable quirks [5.9,007/105] net, xsk: Avoid taking multiple skbuff references [5.9,008/105] bpftool: Fix error return value in build_btf_type_table [5.9,009/105] vhost-vdpa: fix page pinning leakage in error path (rework) [5.9,011/105] batman-adv: Consider fragmentation for needed_headroom [5.9,014/105] ipvs: fix possible memory leak in ip_vs_control_net_init [5.9,015/105] ibmvnic: handle inconsistent login with reset [5.9,016/105] ibmvnic: stop free_all_rwi on failed reset [5.9,021/105] ibmvnic: reduce wait for completion time [5.9,022/105] drm/rockchip: Avoid uninitialized use of endpoint id in LVDS [5.9,023/105] drm/panel: sony-acx565akm: Fix race condition in probe [5.9,025/105] can: sja1000: sja1000_err(): dont count arbitration lose as an error [5.9,027/105] can: c_can: c_can_power_up(): fix error handling [5.9,028/105] can: kvaser_pciefd: kvaser_pciefd_open(): fix error handling [5.9,029/105] samples/ftrace: Mark my_tramp[12]? global [5.9,030/105] scsi: storvsc: Fix error return in storvsc_probe() [5.9,033/105] iwlwifi: pcie: invert values of NO_160 device config entries [5.9,035/105] usb: ohci-omap: Fix descriptor conversion [5.9,037/105] mm/mmap.c: fix mmap return value when vma is merged after call_mmap() [5.9,038/105] phy: usb: Fix incorrect clearing of tca_drv_sel bit in SETUP reg for 7211 [5.9,040/105] iwlwifi: pcie: limit memory read spin time [5.9,041/105] arm64: dts: rockchip: Assign a fixed index to mmc devices on rk3399 boards. [5.9,045/105] iwlwifi: mvm: fix kernel panic in case of assert during CSA [5.9,047/105] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges [5.9,048/105] ARC: stack unwinding: dont assume non-current task is sleeping [5.9,050/105] scsi: ufs: Make sure clk scaling happens only when HBA is runtime ACTIVE [5.9,051/105] interconnect: qcom: msm8916: Remove rpm-ids from non-RPM nodes [5.9,052/105] interconnect: qcom: qcs404: Remove GPU and display RPM IDs [5.9,055/105] drm/exynos: depend on COMMON_CLK to fix compile tests [5.9,056/105] spi: spi-nxp-fspi: fix fspi panic by unexpected interrupts [5.9,061/105] soc: fsl: dpio: Get the cpumask through cpumask_of(cpu) [5.9,064/105] arm64: tegra: Disable the ACONNECT for Jetson TX2 [5.9,068/105] platform/x86: thinkpad_acpi: Whitelist P15 firmware for dual fan control [5.9,071/105] platform/x86: touchscreen_dmi: Add info for the Predia Basic tablet [5.9,073/105] can: m_can: m_can_dev_setup(): add support for bosch mcan version 3.3.0 [5.9,074/105] s390: fix irq state tracing [5.9,075/105] intel_idle: Build fix [5.9,076/105] media: pulse8-cec: fix duplicate free at disconnect or probe error [5.9,077/105] media: pulse8-cec: add support for FW v10 and up [5.9,081/105] xen: add helpers for caching grant mapping pages [5.9,082/105] xen: dont use page->lru for ZONE_DEVICE memory [5.9,083/105] Input: cm109 - do not stomp on control URB [5.9,085/105] pinctrl: jasperlake: Fix HOSTSW_OWN offset [5.9,086/105] pinctrl: amd: remove debounce filter setting in IRQ type setting [5.9,090/105] drm/i915/gem: Propagate error from cancelled submit due to context closure [5.9,091/105] drm/i915/display/dp: Compute the correct slice count for VDSC on DP [5.9,093/105] drm/i915/gt: Ignore repeated attempts to suspend request flow across reset [5.9,094/105] drm/i915/gt: Cancel the preemption timeout on responding to it [5.9,096/105] kbuild: avoid static_assert for genksyms [5.9,097/105] proc: use untagged_addr() for pagemap_read addresses [5.9,098/105] mm/hugetlb: clear compound_nr before freeing gigantic pages [5.9,101/105] x86/mm/mem_encrypt: Fix definition of PMD_FLAGS_DEC_WP [5.9,102/105] x86/membarrier: Get rid of a dubious optimization [5.9,103/105] x86/apic/vector: Fix ordering in vector assignment

[5.9,061/105] soc: fsl: dpio: Get the cpumask through cpumask_of(cpu)

Commit Message

Patch