diff mbox

[v15,06/12] document: dt: add the binding on HiP04 clock

Message ID 1406555876-11989-7-git-send-email-haojian.zhuang@linaro.org
State Changes Requested
Headers show

Commit Message

Haojian Zhuang July 28, 2014, 1:57 p.m. UTC
The DT binding for Hisilicon HiP04 clock driver.

Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
---
 .../devicetree/bindings/clock/hip04-clock.txt        | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/hip04-clock.txt

Comments

Mark Rutland July 28, 2014, 5:54 p.m. UTC | #1
On Mon, Jul 28, 2014 at 02:57:50PM +0100, Haojian Zhuang wrote:
> The DT binding for Hisilicon HiP04 clock driver.
> 
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> ---
>  .../devicetree/bindings/clock/hip04-clock.txt        | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/hip04-clock.txt
> 
> diff --git a/Documentation/devicetree/bindings/clock/hip04-clock.txt b/Documentation/devicetree/bindings/clock/hip04-clock.txt
> new file mode 100644
> index 0000000..4d31ae3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/hip04-clock.txt
> @@ -0,0 +1,20 @@
> +* Hisilicon HiP04 Clock Controller
> +
> +The HiP04 clock controller generates and supplies clock to various
> +controllers within the HiP04 SoC.
> +
> +Required Properties:
> +
> +- compatible: should be one of the following.
> +  - "hisilicon,hip04-clock" - controller compatible with HiP04 SoC.

There's only one clock controller on-board and it's custom for HiP04?

> +
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +
> +- #clock-cells: should be 1.
> +
> +
> +Each clock is assigned an identifier and client nodes use this identifier
> +to specify the clock which they consume.
> +
> +All these identifier could be found in <dt-bindings/clock/hip04-clock.h>.

This must come in the same patch.

Mark.
Haojian Zhuang July 29, 2014, 2:25 a.m. UTC | #2
On 29 July 2014 01:54, Mark Rutland <mark.rutland@arm.com> wrote:
> On Mon, Jul 28, 2014 at 02:57:50PM +0100, Haojian Zhuang wrote:
>> The DT binding for Hisilicon HiP04 clock driver.
>>
>> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
>> ---
>>  .../devicetree/bindings/clock/hip04-clock.txt        | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/clock/hip04-clock.txt
>>
>> diff --git a/Documentation/devicetree/bindings/clock/hip04-clock.txt b/Documentation/devicetree/bindings/clock/hip04-clock.txt
>> new file mode 100644
>> index 0000000..4d31ae3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/hip04-clock.txt
>> @@ -0,0 +1,20 @@
>> +* Hisilicon HiP04 Clock Controller
>> +
>> +The HiP04 clock controller generates and supplies clock to various
>> +controllers within the HiP04 SoC.
>> +
>> +Required Properties:
>> +
>> +- compatible: should be one of the following.
>> +  - "hisilicon,hip04-clock" - controller compatible with HiP04 SoC.
>
> There's only one clock controller on-board and it's custom for HiP04?
>

Since all those PLL settings are configured in bootloader, kernel
don't need to configure it again.

By the way, I don't have the manual to configure those PLLs. All the clocks
are defined as fixed in kernel side.

>> +
>> +- reg: physical base address of the controller and length of memory mapped
>> +  region.
>> +
>> +- #clock-cells: should be 1.
>> +
>> +
>> +Each clock is assigned an identifier and client nodes use this identifier
>> +to specify the clock which they consume.
>> +
>> +All these identifier could be found in <dt-bindings/clock/hip04-clock.h>.
>
> This must come in the same patch.
>
> Mark.

HiP04 clock driver is already merged into mainline.

Regards
Haojian
Arnd Bergmann July 29, 2014, 9:55 a.m. UTC | #3
On Tuesday 29 July 2014 10:25:49 Haojian Zhuang wrote:
> On 29 July 2014 01:54, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Mon, Jul 28, 2014 at 02:57:50PM +0100, Haojian Zhuang wrote:
> >> The DT binding for Hisilicon HiP04 clock driver.
> >>
> >> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> >> ---
> >>  .../devicetree/bindings/clock/hip04-clock.txt        | 20 ++++++++++++++++++++
> >>  1 file changed, 20 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/clock/hip04-clock.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/clock/hip04-clock.txt b/Documentation/devicetree/bindings/clock/hip04-clock.txt
> >> new file mode 100644
> >> index 0000000..4d31ae3
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/clock/hip04-clock.txt
> >> @@ -0,0 +1,20 @@
> >> +* Hisilicon HiP04 Clock Controller
> >> +
> >> +The HiP04 clock controller generates and supplies clock to various
> >> +controllers within the HiP04 SoC.
> >> +
> >> +Required Properties:
> >> +
> >> +- compatible: should be one of the following.
> >> +  - "hisilicon,hip04-clock" - controller compatible with HiP04 SoC.
> >
> > There's only one clock controller on-board and it's custom for HiP04?
> >
> 
> Since all those PLL settings are configured in bootloader, kernel
> don't need to configure it again.
> 
> By the way, I don't have the manual to configure those PLLs. All the clocks
> are defined as fixed in kernel side.
> 

If all the clocks are fixed-rate, you don't actually need a driver
for them, just use the regular fixed-rate clock and define one
node per clock.

	Arnd
Haojian Zhuang July 29, 2014, 10:40 a.m. UTC | #4
On 29 July 2014 17:55, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 29 July 2014 10:25:49 Haojian Zhuang wrote:
>> On 29 July 2014 01:54, Mark Rutland <mark.rutland@arm.com> wrote:
>> > On Mon, Jul 28, 2014 at 02:57:50PM +0100, Haojian Zhuang wrote:
>> >> The DT binding for Hisilicon HiP04 clock driver.
>> >>
>> >> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
>> >> ---
>> >>  .../devicetree/bindings/clock/hip04-clock.txt        | 20 ++++++++++++++++++++
>> >>  1 file changed, 20 insertions(+)
>> >>  create mode 100644 Documentation/devicetree/bindings/clock/hip04-clock.txt
>> >>
>> >> diff --git a/Documentation/devicetree/bindings/clock/hip04-clock.txt b/Documentation/devicetree/bindings/clock/hip04-clock.txt
>> >> new file mode 100644
>> >> index 0000000..4d31ae3
>> >> --- /dev/null
>> >> +++ b/Documentation/devicetree/bindings/clock/hip04-clock.txt
>> >> @@ -0,0 +1,20 @@
>> >> +* Hisilicon HiP04 Clock Controller
>> >> +
>> >> +The HiP04 clock controller generates and supplies clock to various
>> >> +controllers within the HiP04 SoC.
>> >> +
>> >> +Required Properties:
>> >> +
>> >> +- compatible: should be one of the following.
>> >> +  - "hisilicon,hip04-clock" - controller compatible with HiP04 SoC.
>> >
>> > There's only one clock controller on-board and it's custom for HiP04?
>> >
>>
>> Since all those PLL settings are configured in bootloader, kernel
>> don't need to configure it again.
>>
>> By the way, I don't have the manual to configure those PLLs. All the clocks
>> are defined as fixed in kernel side.
>>
>
> If all the clocks are fixed-rate, you don't actually need a driver
> for them, just use the regular fixed-rate clock and define one
> node per clock.
>
>         Arnd

OK. I'll update it.

Regards
Haojian
Mark Rutland July 29, 2014, 12:38 p.m. UTC | #5
On Tue, Jul 29, 2014 at 03:25:49AM +0100, Haojian Zhuang wrote:
> On 29 July 2014 01:54, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Mon, Jul 28, 2014 at 02:57:50PM +0100, Haojian Zhuang wrote:
> >> The DT binding for Hisilicon HiP04 clock driver.
> >>
> >> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> >> ---
> >>  .../devicetree/bindings/clock/hip04-clock.txt        | 20 ++++++++++++++++++++
> >>  1 file changed, 20 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/clock/hip04-clock.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/clock/hip04-clock.txt b/Documentation/devicetree/bindings/clock/hip04-clock.txt
> >> new file mode 100644
> >> index 0000000..4d31ae3
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/clock/hip04-clock.txt
> >> @@ -0,0 +1,20 @@
> >> +* Hisilicon HiP04 Clock Controller
> >> +
> >> +The HiP04 clock controller generates and supplies clock to various
> >> +controllers within the HiP04 SoC.
> >> +
> >> +Required Properties:
> >> +
> >> +- compatible: should be one of the following.
> >> +  - "hisilicon,hip04-clock" - controller compatible with HiP04 SoC.
> >
> > There's only one clock controller on-board and it's custom for HiP04?
> >
> 
> Since all those PLL settings are configured in bootloader, kernel
> don't need to configure it again.
> 
> By the way, I don't have the manual to configure those PLLs. All the clocks
> are defined as fixed in kernel side.

Given that, per Arnd's suggestion these should probably just be
fixed-clock nodes, and we don't need the driver at all until we know how
to handle these PLLs and their parents.

> >> +
> >> +- reg: physical base address of the controller and length of memory mapped
> >> +  region.
> >> +
> >> +- #clock-cells: should be 1.
> >> +
> >> +
> >> +Each clock is assigned an identifier and client nodes use this identifier
> >> +to specify the clock which they consume.
> >> +
> >> +All these identifier could be found in <dt-bindings/clock/hip04-clock.h>.
> >
> > This must come in the same patch.
> >
> > Mark.
> 
> HiP04 clock driver is already merged into mainline.

I see. This was not obvious from the commit message.

Mark.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/clock/hip04-clock.txt b/Documentation/devicetree/bindings/clock/hip04-clock.txt
new file mode 100644
index 0000000..4d31ae3
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/hip04-clock.txt
@@ -0,0 +1,20 @@ 
+* Hisilicon HiP04 Clock Controller
+
+The HiP04 clock controller generates and supplies clock to various
+controllers within the HiP04 SoC.
+
+Required Properties:
+
+- compatible: should be one of the following.
+  - "hisilicon,hip04-clock" - controller compatible with HiP04 SoC.
+
+- reg: physical base address of the controller and length of memory mapped
+  region.
+
+- #clock-cells: should be 1.
+
+
+Each clock is assigned an identifier and client nodes use this identifier
+to specify the clock which they consume.
+
+All these identifier could be found in <dt-bindings/clock/hip04-clock.h>.