| Message ID | 20201213052948.308263-1-swboyd@chromium.org |
|---|---|
| State | Accepted |
| Commit | eaecba8767835783bdd2f4e72406668cda7d8d54 |
| Headers | show |
| Series | spi: spi-qcom-qspi: Use irq trigger flags from firmware | expand |
Hi, On Sat, Dec 12, 2020 at 9:29 PM Stephen Boyd <swboyd@chromium.org> wrote: > > We don't need to force this to be trigger high here, as the firmware > properly configures the irq flags already. Drop it to save a line. > > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Rajendra Nayak <rnayak@codeaurora.org> > Cc: Mukesh Kumar Savaliya <msavaliy@codeaurora.org> > Cc: Akash Asthana <akashast@codeaurora.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/spi/spi-qcom-qspi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c > index 5eed88af6899..8e70f5e63e0b 100644 > --- a/drivers/spi/spi-qcom-qspi.c > +++ b/drivers/spi/spi-qcom-qspi.c > @@ -516,8 +516,7 @@ static int qcom_qspi_probe(struct platform_device *pdev) > ret = platform_get_irq(pdev, 0); > if (ret < 0) > goto exit_probe_master_put; > - ret = devm_request_irq(dev, ret, qcom_qspi_irq, > - IRQF_TRIGGER_HIGH, dev_name(dev), ctrl); > + ret = devm_request_irq(dev, ret, qcom_qspi_irq, 0, dev_name(dev), ctrl); I don't feel that the old code is really wrong, but I guess it is weird that it's double-specified (both in the code and in the dts). ...so this is OK w/ me. Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Sat, Dec 12, 2020 at 09:29:48PM -0800, Stephen Boyd wrote: > We don't need to force this to be trigger high here, as the firmware > properly configures the irq flags already. Drop it to save a line. This doesn't apply against current code, please check and resend.
diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index 5eed88af6899..8e70f5e63e0b 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -516,8 +516,7 @@ static int qcom_qspi_probe(struct platform_device *pdev) ret = platform_get_irq(pdev, 0); if (ret < 0) goto exit_probe_master_put; - ret = devm_request_irq(dev, ret, qcom_qspi_irq, - IRQF_TRIGGER_HIGH, dev_name(dev), ctrl); + ret = devm_request_irq(dev, ret, qcom_qspi_irq, 0, dev_name(dev), ctrl); if (ret) { dev_err(dev, "Failed to request irq %d\n", ret); goto exit_probe_master_put;
We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line. Cc: Douglas Anderson <dianders@chromium.org> Cc: Rajendra Nayak <rnayak@codeaurora.org> Cc: Mukesh Kumar Savaliya <msavaliy@codeaurora.org> Cc: Akash Asthana <akashast@codeaurora.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- drivers/spi/spi-qcom-qspi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) base-commit: b65054597872ce3aefbc6a666385eabdf9e288da