| Message ID | 1607704424-16223-2-git-send-email-u0084500@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/3] mfd: rt4831: Adds support for Richtek RT4831 MFD core | expand |
Hi CY On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > From: ChiYuan Huang <cy_huang@richtek.com> > > Adds DT binding document for Richtek RT4831 backlight. > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> This patch got keyword filtered and brought to my attention but the rest of the series did not. If it was a backlight patch series you need to send it To: the all the backlight maintainers. Daniel. > --- > since v3 > - Move inlcude/dt-bindings/leds/rt4831-backlight.h from v3 mfd binding patch to here. > - Add dual license tag in header and backlight binding document. > - Left backlight dt-binding example only. > --- > .../leds/backlight/richtek,rt4831-backlight.yaml | 76 ++++++++++++++++++++++ > include/dt-bindings/leds/rt4831-backlight.h | 23 +++++++ > 2 files changed, 99 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > create mode 100644 include/dt-bindings/leds/rt4831-backlight.h > > diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > new file mode 100644 > index 00000000..f24c8d1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/backlight/richtek,rt4831-backlight.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Richtek RT4831 Backlight > + > +maintainers: > + - ChiYuan Huang <cy_huang@richtek.com> > + > +description: | > + RT4831 is a mutifunctional device that can provide power to the LCD display > + and LCD backlight. > + > + For the LCD backlight, it can provide four channel WLED driving capability. > + Each channel driving current is up to 30mA > + > + Datasheet is available at > + https://www.richtek.com/assets/product_file/RT4831A/DS4831A-05.pdf > + > +properties: > + compatible: > + const: richtek,rt4831-backlight > + > + default-brightness: > + description: | > + The default brightness that applied to the system on start-up. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 2048 > + > + max-brightness: > + description: | > + The max brightness for the H/W limit > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 2048 > + > + richtek,pwm-enable: > + description: | > + Specify the backlight dimming following by PWM duty or by SW control. > + type: boolean > + > + richtek,bled-ovp-sel: > + description: | > + Backlight OVP level selection, currently support 17V/21V/25V/29V. > + $ref: /schemas/types.yaml#/definitions/uint8 > + default: 1 > + minimum: 0 > + maximum: 3 > + > + richtek,channel-use: > + description: | > + Backlight LED channel to be used. > + BIT 0/1/2/3 is used to indicate led channel 1/2/3/4 enable or disable. > + $ref: /schemas/types.yaml#/definitions/uint8 > + minimum: 1 > + maximum: 15 > + > +required: > + - compatible > + - richtek,channel-use > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/leds/rt4831-backlight.h> > + backlight { > + compatible = "richtek,rt4831-backlight"; > + default-brightness = <1024>; > + max-brightness = <2048>; > + richtek,bled-ovp-sel = /bits/ 8 <RT4831_BLOVPLVL_21V>; > + richtek,channel-use = /bits/ 8 <RT4831_BLED_ALLCHEN>; > + }; > diff --git a/include/dt-bindings/leds/rt4831-backlight.h b/include/dt-bindings/leds/rt4831-backlight.h > new file mode 100644 > index 00000000..125c635 > --- /dev/null > +++ b/include/dt-bindings/leds/rt4831-backlight.h > @@ -0,0 +1,23 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * This header provides constants for rt4831 backlight bindings. > + * > + * Copyright (C) 2020, Richtek Technology Corp. > + * Author: ChiYuan Huang <cy_huang@richtek.com> > + */ > + > +#ifndef _DT_BINDINGS_RT4831_BACKLIGHT_H > +#define _DT_BINDINGS_RT4831_BACKLIGHT_H > + > +#define RT4831_BLOVPLVL_17V 0 > +#define RT4831_BLOVPLVL_21V 1 > +#define RT4831_BLOVPLVL_25V 2 > +#define RT4831_BLOVPLVL_29V 3 > + > +#define RT4831_BLED_CH1EN (1 << 0) > +#define RT4831_BLED_CH2EN (1 << 1) > +#define RT4831_BLED_CH3EN (1 << 2) > +#define RT4831_BLED_CH4EN (1 << 3) > +#define RT4831_BLED_ALLCHEN ((1 << 4) - 1) > + > +#endif /* _DT_BINDINGS_RT4831_BACKLIGHT_H */ > -- > 2.7.4 >
Hi, Daniel Thompson <daniel.thompson@linaro.org> 於 2020年12月14日 週一 下午5:59寫道： > > Hi CY > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > Adds DT binding document for Richtek RT4831 backlight. > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > This patch got keyword filtered and brought to my attention > but the rest of the series did not. > > If it was a backlight patch series you need to send it To: the > all the backlight maintainers. > Yes, I'm waiting for mfd reviewing. Due to mfd patch, I need to add backlight dt-binding patch prior to backlight source code. Or autobuild robot will said mfd dt-binding build fail from Rob. That's why I send the backlight dt-binding prior to the source code. I still have backlight/regulator source code patch after mfd reviewing. Do you want me to send all the patches without waiting for mfd reviewing? > > Daniel. > > > > --- > > since v3 > > - Move inlcude/dt-bindings/leds/rt4831-backlight.h from v3 mfd binding patch to here. > > - Add dual license tag in header and backlight binding document. > > - Left backlight dt-binding example only. > > --- > > .../leds/backlight/richtek,rt4831-backlight.yaml | 76 ++++++++++++++++++++++ > > include/dt-bindings/leds/rt4831-backlight.h | 23 +++++++ > > 2 files changed, 99 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > > create mode 100644 include/dt-bindings/leds/rt4831-backlight.h > > > > diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > > new file mode 100644 > > index 00000000..f24c8d1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/backlight/richtek,rt4831-backlight.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Richtek RT4831 Backlight > > + > > +maintainers: > > + - ChiYuan Huang <cy_huang@richtek.com> > > + > > +description: | > > + RT4831 is a mutifunctional device that can provide power to the LCD display > > + and LCD backlight. > > + > > + For the LCD backlight, it can provide four channel WLED driving capability. > > + Each channel driving current is up to 30mA > > + > > + Datasheet is available at > > + https://www.richtek.com/assets/product_file/RT4831A/DS4831A-05.pdf > > + > > +properties: > > + compatible: > > + const: richtek,rt4831-backlight > > + > > + default-brightness: > > + description: | > > + The default brightness that applied to the system on start-up. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 0 > > + maximum: 2048 > > + > > + max-brightness: > > + description: | > > + The max brightness for the H/W limit > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 0 > > + maximum: 2048 > > + > > + richtek,pwm-enable: > > + description: | > > + Specify the backlight dimming following by PWM duty or by SW control. > > + type: boolean > > + > > + richtek,bled-ovp-sel: > > + description: | > > + Backlight OVP level selection, currently support 17V/21V/25V/29V. > > + $ref: /schemas/types.yaml#/definitions/uint8 > > + default: 1 > > + minimum: 0 > > + maximum: 3 > > + > > + richtek,channel-use: > > + description: | > > + Backlight LED channel to be used. > > + BIT 0/1/2/3 is used to indicate led channel 1/2/3/4 enable or disable. > > + $ref: /schemas/types.yaml#/definitions/uint8 > > + minimum: 1 > > + maximum: 15 > > + > > +required: > > + - compatible > > + - richtek,channel-use > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/leds/rt4831-backlight.h> > > + backlight { > > + compatible = "richtek,rt4831-backlight"; > > + default-brightness = <1024>; > > + max-brightness = <2048>; > > + richtek,bled-ovp-sel = /bits/ 8 <RT4831_BLOVPLVL_21V>; > > + richtek,channel-use = /bits/ 8 <RT4831_BLED_ALLCHEN>; > > + }; > > diff --git a/include/dt-bindings/leds/rt4831-backlight.h b/include/dt-bindings/leds/rt4831-backlight.h > > new file mode 100644 > > index 00000000..125c635 > > --- /dev/null > > +++ b/include/dt-bindings/leds/rt4831-backlight.h > > @@ -0,0 +1,23 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > > +/* > > + * This header provides constants for rt4831 backlight bindings. > > + * > > + * Copyright (C) 2020, Richtek Technology Corp. > > + * Author: ChiYuan Huang <cy_huang@richtek.com> > > + */ > > + > > +#ifndef _DT_BINDINGS_RT4831_BACKLIGHT_H > > +#define _DT_BINDINGS_RT4831_BACKLIGHT_H > > + > > +#define RT4831_BLOVPLVL_17V 0 > > +#define RT4831_BLOVPLVL_21V 1 > > +#define RT4831_BLOVPLVL_25V 2 > > +#define RT4831_BLOVPLVL_29V 3 > > + > > +#define RT4831_BLED_CH1EN (1 << 0) > > +#define RT4831_BLED_CH2EN (1 << 1) > > +#define RT4831_BLED_CH3EN (1 << 2) > > +#define RT4831_BLED_CH4EN (1 << 3) > > +#define RT4831_BLED_ALLCHEN ((1 << 4) - 1) > > + > > +#endif /* _DT_BINDINGS_RT4831_BACKLIGHT_H */ > > -- > > 2.7.4 > >
On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > Hi, > > Daniel Thompson <daniel.thompson@linaro.org> 於 2020年12月14日 週一 下午5:59寫道： > > > > Hi CY > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > > > Adds DT binding document for Richtek RT4831 backlight. > > > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > > > This patch got keyword filtered and brought to my attention > > but the rest of the series did not. > > > > If it was a backlight patch series you need to send it To: the > > all the backlight maintainers. > > > Yes, I'm waiting for mfd reviewing. > Due to mfd patch, I need to add backlight dt-binding patch prior to > backlight source code. > Or autobuild robot will said mfd dt-binding build fail from Rob. > That's why I send the backlight dt-binding prior to the source code. > > I still have backlight/regulator source code patch after mfd reviewing. > Do you want me to send all the patches without waiting for mfd reviewing? To some extent it's up to you. I think I would have shared all the pieces at once (although not it Lee, as mfd maintainer, had suggested otherwise). Daniel. > > > > Daniel. > > > > > > > --- > > > since v3 > > > - Move inlcude/dt-bindings/leds/rt4831-backlight.h from v3 mfd binding patch to here. > > > - Add dual license tag in header and backlight binding document. > > > - Left backlight dt-binding example only. > > > --- > > > .../leds/backlight/richtek,rt4831-backlight.yaml | 76 ++++++++++++++++++++++ > > > include/dt-bindings/leds/rt4831-backlight.h | 23 +++++++ > > > 2 files changed, 99 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > > > create mode 100644 include/dt-bindings/leds/rt4831-backlight.h > > > > > > diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > > > new file mode 100644 > > > index 00000000..f24c8d1 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > > > @@ -0,0 +1,76 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/leds/backlight/richtek,rt4831-backlight.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Richtek RT4831 Backlight > > > + > > > +maintainers: > > > + - ChiYuan Huang <cy_huang@richtek.com> > > > + > > > +description: | > > > + RT4831 is a mutifunctional device that can provide power to the LCD display > > > + and LCD backlight. > > > + > > > + For the LCD backlight, it can provide four channel WLED driving capability. > > > + Each channel driving current is up to 30mA > > > + > > > + Datasheet is available at > > > + https://www.richtek.com/assets/product_file/RT4831A/DS4831A-05.pdf > > > + > > > +properties: > > > + compatible: > > > + const: richtek,rt4831-backlight > > > + > > > + default-brightness: > > > + description: | > > > + The default brightness that applied to the system on start-up. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + minimum: 0 > > > + maximum: 2048 > > > + > > > + max-brightness: > > > + description: | > > > + The max brightness for the H/W limit > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + minimum: 0 > > > + maximum: 2048 > > > + > > > + richtek,pwm-enable: > > > + description: | > > > + Specify the backlight dimming following by PWM duty or by SW control. > > > + type: boolean > > > + > > > + richtek,bled-ovp-sel: > > > + description: | > > > + Backlight OVP level selection, currently support 17V/21V/25V/29V. > > > + $ref: /schemas/types.yaml#/definitions/uint8 > > > + default: 1 > > > + minimum: 0 > > > + maximum: 3 > > > + > > > + richtek,channel-use: > > > + description: | > > > + Backlight LED channel to be used. > > > + BIT 0/1/2/3 is used to indicate led channel 1/2/3/4 enable or disable. > > > + $ref: /schemas/types.yaml#/definitions/uint8 > > > + minimum: 1 > > > + maximum: 15 > > > + > > > +required: > > > + - compatible > > > + - richtek,channel-use > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + #include <dt-bindings/leds/rt4831-backlight.h> > > > + backlight { > > > + compatible = "richtek,rt4831-backlight"; > > > + default-brightness = <1024>; > > > + max-brightness = <2048>; > > > + richtek,bled-ovp-sel = /bits/ 8 <RT4831_BLOVPLVL_21V>; > > > + richtek,channel-use = /bits/ 8 <RT4831_BLED_ALLCHEN>; > > > + }; > > > diff --git a/include/dt-bindings/leds/rt4831-backlight.h b/include/dt-bindings/leds/rt4831-backlight.h > > > new file mode 100644 > > > index 00000000..125c635 > > > --- /dev/null > > > +++ b/include/dt-bindings/leds/rt4831-backlight.h > > > @@ -0,0 +1,23 @@ > > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > > > +/* > > > + * This header provides constants for rt4831 backlight bindings. > > > + * > > > + * Copyright (C) 2020, Richtek Technology Corp. > > > + * Author: ChiYuan Huang <cy_huang@richtek.com> > > > + */ > > > + > > > +#ifndef _DT_BINDINGS_RT4831_BACKLIGHT_H > > > +#define _DT_BINDINGS_RT4831_BACKLIGHT_H > > > + > > > +#define RT4831_BLOVPLVL_17V 0 > > > +#define RT4831_BLOVPLVL_21V 1 > > > +#define RT4831_BLOVPLVL_25V 2 > > > +#define RT4831_BLOVPLVL_29V 3 > > > + > > > +#define RT4831_BLED_CH1EN (1 << 0) > > > +#define RT4831_BLED_CH2EN (1 << 1) > > > +#define RT4831_BLED_CH3EN (1 << 2) > > > +#define RT4831_BLED_CH4EN (1 << 3) > > > +#define RT4831_BLED_ALLCHEN ((1 << 4) - 1) > > > + > > > +#endif /* _DT_BINDINGS_RT4831_BACKLIGHT_H */ > > > -- > > > 2.7.4 > > >
On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > Hi, > > Daniel Thompson <daniel.thompson@linaro.org> 於 2020年12月14日 週一 下午5:59寫道： > > > > Hi CY > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > > > Adds DT binding document for Richtek RT4831 backlight. > > > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > > > This patch got keyword filtered and brought to my attention > > but the rest of the series did not. > > > > If it was a backlight patch series you need to send it To: the > > all the backlight maintainers. > > > Yes, I'm waiting for mfd reviewing. > Due to mfd patch, I need to add backlight dt-binding patch prior to > backlight source code. > Or autobuild robot will said mfd dt-binding build fail from Rob. > That's why I send the backlight dt-binding prior to the source code. > > I still have backlight/regulator source code patch after mfd reviewing. > Do you want me to send all the patches without waiting for mfd reviewing? What happened to the regulator part of the binding? I said you could merge it into the mfd schema, not drop it. Bindings should be complete so we get a full picture of a device. Rob
On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > From: ChiYuan Huang <cy_huang@richtek.com> > > Adds DT binding document for Richtek RT4831 backlight. > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > --- > since v3 > - Move inlcude/dt-bindings/leds/rt4831-backlight.h from v3 mfd binding patch to here. > - Add dual license tag in header and backlight binding document. > - Left backlight dt-binding example only. > --- > .../leds/backlight/richtek,rt4831-backlight.yaml | 76 ++++++++++++++++++++++ > include/dt-bindings/leds/rt4831-backlight.h | 23 +++++++ > 2 files changed, 99 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > create mode 100644 include/dt-bindings/leds/rt4831-backlight.h > > diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > new file mode 100644 > index 00000000..f24c8d1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/backlight/richtek,rt4831-backlight.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Richtek RT4831 Backlight > + > +maintainers: > + - ChiYuan Huang <cy_huang@richtek.com> > + > +description: | > + RT4831 is a mutifunctional device that can provide power to the LCD display > + and LCD backlight. > + > + For the LCD backlight, it can provide four channel WLED driving capability. > + Each channel driving current is up to 30mA > + > + Datasheet is available at > + https://www.richtek.com/assets/product_file/RT4831A/DS4831A-05.pdf > + > +properties: > + compatible: > + const: richtek,rt4831-backlight > + > + default-brightness: > + description: | > + The default brightness that applied to the system on start-up. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 2048 > + > + max-brightness: > + description: | > + The max brightness for the H/W limit > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 2048 > + > + richtek,pwm-enable: > + description: | > + Specify the backlight dimming following by PWM duty or by SW control. > + type: boolean > + > + richtek,bled-ovp-sel: > + description: | > + Backlight OVP level selection, currently support 17V/21V/25V/29V. > + $ref: /schemas/types.yaml#/definitions/uint8 > + default: 1 > + minimum: 0 > + maximum: 3 > + > + richtek,channel-use: > + description: | > + Backlight LED channel to be used. > + BIT 0/1/2/3 is used to indicate led channel 1/2/3/4 enable or disable. > + $ref: /schemas/types.yaml#/definitions/uint8 > + minimum: 1 > + maximum: 15 > + > +required: > + - compatible > + - richtek,channel-use > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/leds/rt4831-backlight.h> > + backlight { > + compatible = "richtek,rt4831-backlight"; > + default-brightness = <1024>; > + max-brightness = <2048>; > + richtek,bled-ovp-sel = /bits/ 8 <RT4831_BLOVPLVL_21V>; > + richtek,channel-use = /bits/ 8 <RT4831_BLED_ALLCHEN>; This is in the MFD schema already, so drop the example. > + }; > diff --git a/include/dt-bindings/leds/rt4831-backlight.h b/include/dt-bindings/leds/rt4831-backlight.h > new file mode 100644 > index 00000000..125c635 > --- /dev/null > +++ b/include/dt-bindings/leds/rt4831-backlight.h > @@ -0,0 +1,23 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * This header provides constants for rt4831 backlight bindings. > + * > + * Copyright (C) 2020, Richtek Technology Corp. > + * Author: ChiYuan Huang <cy_huang@richtek.com> > + */ > + > +#ifndef _DT_BINDINGS_RT4831_BACKLIGHT_H > +#define _DT_BINDINGS_RT4831_BACKLIGHT_H > + > +#define RT4831_BLOVPLVL_17V 0 > +#define RT4831_BLOVPLVL_21V 1 > +#define RT4831_BLOVPLVL_25V 2 > +#define RT4831_BLOVPLVL_29V 3 > + > +#define RT4831_BLED_CH1EN (1 << 0) > +#define RT4831_BLED_CH2EN (1 << 1) > +#define RT4831_BLED_CH3EN (1 << 2) > +#define RT4831_BLED_CH4EN (1 << 3) > +#define RT4831_BLED_ALLCHEN ((1 << 4) - 1) > + > +#endif /* _DT_BINDINGS_RT4831_BACKLIGHT_H */ > -- > 2.7.4 >
On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > > Hi, > > Daniel Thompson <daniel.thompson@linaro.org> 於 2020年12月14日 週一 > 下午5:59寫道： > > > > > > Hi CY > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > > > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > > > Adds DT binding document for Richtek RT4831 backlight. > > > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > This patch got keyword filtered and brought to my attention > > but the rest of the series did not. > > > > If it was a backlight patch series you need to send it To: the > > all the backlight maintainers. > > > Yes, I'm waiting for mfd reviewing. > Due to mfd patch, I need to add backlight dt-binding patch prior to > backlight source code. > Or autobuild robot will said mfd dt-binding build fail from Rob. > That's why I send the backlight dt-binding prior to the source code. > > I still have backlight/regulator source code patch after mfd > reviewing. > Do you want me to send all the patches without waiting for mfd > reviewing? What happened to the regulator part of the binding? I said you could merge it into the mfd schema, not drop it. Bindings should be complete so we get a full picture of a device. Yes, I remove the regulator dt-binding and directly merge into mfd schema. Could you check the v4 3/3 patch? Or you just want me to remove regulator dt-binding example in regulator dt-binding patch? Sorry, please also loop my gmail account. Due to my company mailbox, I'm not sure whether the reply format is correct or not. Rob ************* Email Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!
> On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > Adds DT binding document for Richtek RT4831 backlight. > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > --- > > since v3 > > - Move inlcude/dt-bindings/leds/rt4831-backlight.h from v3 mfd > > binding patch to here. > > - Add dual license tag in header and backlight binding document. > > - Left backlight dt-binding example only. > > --- > > .../leds/backlight/richtek,rt4831-backlight.yaml | 76 > > ++++++++++++++++++++++ > > include/dt-bindings/leds/rt4831-backlight.h | 23 +++++++ > > 2 files changed, 99 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/leds/backlight/richtek,rt4831- > > backlight.yaml > > create mode 100644 include/dt-bindings/leds/rt4831-backlight.h > > > > diff --git > > a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831- > > backlight.yaml > > b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831- > > backlight.yaml > > new file mode 100644 > > index 00000000..f24c8d1 > > --- /dev/null > > +++ > > b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831- > > backlight.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/backlight/richtek,rt4831-b > > acklight.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Richtek RT4831 Backlight > > + > > +maintainers: > > + - ChiYuan Huang <cy_huang@richtek.com> > > + > > +description: | > > + RT4831 is a mutifunctional device that can provide power to the > > LCD display > > + and LCD backlight. > > + > > + For the LCD backlight, it can provide four channel WLED driving > > capability. > > + Each channel driving current is up to 30mA > > + > > + Datasheet is available at > > + https://www.richtek.com/assets/product_file/RT4831A/DS4831A-05.p > > df > > + > > +properties: > > + compatible: > > + const: richtek,rt4831-backlight > > + > > + default-brightness: > > + description: | > > + The default brightness that applied to the system on start- > > up. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 0 > > + maximum: 2048 > > + > > + max-brightness: > > + description: | > > + The max brightness for the H/W limit > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 0 > > + maximum: 2048 > > + > > + richtek,pwm-enable: > > + description: | > > + Specify the backlight dimming following by PWM duty or by SW > > control. > > + type: boolean > > + > > + richtek,bled-ovp-sel: > > + description: | > > + Backlight OVP level selection, currently support > > 17V/21V/25V/29V. > > + $ref: /schemas/types.yaml#/definitions/uint8 > > + default: 1 > > + minimum: 0 > > + maximum: 3 > > + > > + richtek,channel-use: > > + description: | > > + Backlight LED channel to be used. > > + BIT 0/1/2/3 is used to indicate led channel 1/2/3/4 enable > > or disable. > > + $ref: /schemas/types.yaml#/definitions/uint8 > > + minimum: 1 > > + maximum: 15 > > + > > +required: > > + - compatible > > + - richtek,channel-use > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/leds/rt4831-backlight.h> > > + backlight { > > + compatible = "richtek,rt4831-backlight"; > > + default-brightness = <1024>; > > + max-brightness = <2048>; > > + richtek,bled-ovp-sel = /bits/ 8 <RT4831_BLOVPLVL_21V>; > > + richtek,channel-use = /bits/ 8 <RT4831_BLED_ALLCHEN>; > This is in the MFD schema already, so drop the example. > Will ack in next series patch. > > > > + }; > > diff --git a/include/dt-bindings/leds/rt4831-backlight.h > > b/include/dt-bindings/leds/rt4831-backlight.h > > new file mode 100644 > > index 00000000..125c635 > > --- /dev/null > > +++ b/include/dt-bindings/leds/rt4831-backlight.h > > @@ -0,0 +1,23 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > > +/* > > + * This header provides constants for rt4831 backlight bindings. > > + * > > + * Copyright (C) 2020, Richtek Technology Corp. > > + * Author: ChiYuan Huang <cy_huang@richtek.com> > > + */ > > + > > +#ifndef _DT_BINDINGS_RT4831_BACKLIGHT_H > > +#define _DT_BINDINGS_RT4831_BACKLIGHT_H > > + > > +#define RT4831_BLOVPLVL_17V0 > > +#define RT4831_BLOVPLVL_21V1 > > +#define RT4831_BLOVPLVL_25V2 > > +#define RT4831_BLOVPLVL_29V3 > > + > > +#define RT4831_BLED_CH1EN(1 << 0) > > +#define RT4831_BLED_CH2EN(1 << 1) > > +#define RT4831_BLED_CH3EN(1 << 2) > > +#define RT4831_BLED_CH4EN(1 << 3) > > +#define RT4831_BLED_ALLCHEN((1 << 4) - 1) > > + > > +#endif /* _DT_BINDINGS_RT4831_BACKLIGHT_H */ ************* Email Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!
cy_huang(黃啟原) <cy_huang@richtek.com> 於 2020年12月15日 週二 下午1:08寫道： > > On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > > > > Hi, > > > > Daniel Thompson <daniel.thompson@linaro.org> 於 2020年12月14日 週一 > > 下午5:59寫道： > > > > > > > > > Hi CY > > > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > > > > > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > > > > > Adds DT binding document for Richtek RT4831 backlight. > > > > > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > > This patch got keyword filtered and brought to my attention > > > but the rest of the series did not. > > > > > > If it was a backlight patch series you need to send it To: the > > > all the backlight maintainers. > > > > > Yes, I'm waiting for mfd reviewing. > > Due to mfd patch, I need to add backlight dt-binding patch prior to > > backlight source code. > > Or autobuild robot will said mfd dt-binding build fail from Rob. > > That's why I send the backlight dt-binding prior to the source code. > > > > I still have backlight/regulator source code patch after mfd > > reviewing. > > Do you want me to send all the patches without waiting for mfd > > reviewing? > What happened to the regulator part of the binding? I said you could > merge it into the mfd schema, not drop it. Bindings should be complete > so we get a full picture of a device. > Sorry I found the gmail account already loop in. Just my gmail problem. I cannot see the email in it..... The reply is below. Yes, I remove the regulator dt-binding and directly merge into mfd schema. Could you check the v4 3/3 patch? Or you just want me to remove regulator dt-binding example, not whole dt-binding file? > > Rob > ************* Email Confidentiality Notice ******************** > > The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!
On Mon, 14 Dec 2020, Daniel Thompson wrote: > On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > > Hi, > > > > Daniel Thompson <daniel.thompson@linaro.org> 於 2020年12月14日 週一 下午5:59寫道： > > > > > > Hi CY > > > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > > > > > Adds DT binding document for Richtek RT4831 backlight. > > > > > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > > > > > This patch got keyword filtered and brought to my attention > > > but the rest of the series did not. > > > > > > If it was a backlight patch series you need to send it To: the > > > all the backlight maintainers. > > > > > Yes, I'm waiting for mfd reviewing. > > Due to mfd patch, I need to add backlight dt-binding patch prior to > > backlight source code. > > Or autobuild robot will said mfd dt-binding build fail from Rob. > > That's why I send the backlight dt-binding prior to the source code. > > > > I still have backlight/regulator source code patch after mfd reviewing. > > Do you want me to send all the patches without waiting for mfd reviewing? > > To some extent it's up to you. > > I think I would have shared all the pieces at once (although not it Lee, > as mfd maintainer, had suggested otherwise). You should not need to concern yourself with patch ordering outside of the realms of the set i.e. [PATCH 1/x], [PATCH 2/x], etc. If you just send the whole patch set and you do not specify otherwise, it will be applied, in order, as a set. Sending subsystem patches without the correct maintainers as recipients is bad form. Many of us have filters on, so this tactic will seldom work in any case. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Hi, Lee: Lee Jones <lee.jones@linaro.org> 於 2020年12月15日 週二 下午3:53寫道： > > On Mon, 14 Dec 2020, Daniel Thompson wrote: > > > On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > > > Hi, > > > > > > Daniel Thompson <daniel.thompson@linaro.org> 於 2020年12月14日 週一 下午5:59寫道： > > > > > > > > Hi CY > > > > > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > > > > > > > Adds DT binding document for Richtek RT4831 backlight. > > > > > > > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > > > > > > > This patch got keyword filtered and brought to my attention > > > > but the rest of the series did not. > > > > > > > > If it was a backlight patch series you need to send it To: the > > > > all the backlight maintainers. > > > > > > > Yes, I'm waiting for mfd reviewing. > > > Due to mfd patch, I need to add backlight dt-binding patch prior to > > > backlight source code. > > > Or autobuild robot will said mfd dt-binding build fail from Rob. > > > That's why I send the backlight dt-binding prior to the source code. > > > > > > I still have backlight/regulator source code patch after mfd reviewing. > > > Do you want me to send all the patches without waiting for mfd reviewing? > > > > To some extent it's up to you. > > > > I think I would have shared all the pieces at once (although not it Lee, > > as mfd maintainer, had suggested otherwise). > > You should not need to concern yourself with patch ordering outside > of the realms of the set i.e. [PATCH 1/x], [PATCH 2/x], etc. > > If you just send the whole patch set and you do not specify otherwise, > it will be applied, in order, as a set. > > Sending subsystem patches without the correct maintainers as recipients > is bad form. Many of us have filters on, so this tactic will seldom > work in any case. > In my case, there're mfd/backlight/regulator for RT4831. You mean I can just send the whole patch set directly to whole mfd/backlight/regulator maintainers. And you can filter like as the keyword to review the related contents, right? From my original thought, the order is mfd -> backlight-> regulator, one by one due to different maintainers. Maybe I think too much about the patch ordering If so, after getting the comment from Rob, I'll send the whole patch to you. Thanks for the notice. > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog
On Tue, 15 Dec 2020, ChiYuan Huang wrote: > Hi, Lee: > > Lee Jones <lee.jones@linaro.org> 於 2020年12月15日 週二 下午3:53寫道： > > > > On Mon, 14 Dec 2020, Daniel Thompson wrote: > > > > > On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > > > > Hi, > > > > > > > > Daniel Thompson <daniel.thompson@linaro.org> 於 2020年12月14日 週一 下午5:59寫道： > > > > > > > > > > Hi CY > > > > > > > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > > > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > > > > > > > > > Adds DT binding document for Richtek RT4831 backlight. > > > > > > > > > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > > > > > > > > > This patch got keyword filtered and brought to my attention > > > > > but the rest of the series did not. > > > > > > > > > > If it was a backlight patch series you need to send it To: the > > > > > all the backlight maintainers. > > > > > > > > > Yes, I'm waiting for mfd reviewing. > > > > Due to mfd patch, I need to add backlight dt-binding patch prior to > > > > backlight source code. > > > > Or autobuild robot will said mfd dt-binding build fail from Rob. > > > > That's why I send the backlight dt-binding prior to the source code. > > > > > > > > I still have backlight/regulator source code patch after mfd reviewing. > > > > Do you want me to send all the patches without waiting for mfd reviewing? > > > > > > To some extent it's up to you. > > > > > > I think I would have shared all the pieces at once (although not it Lee, > > > as mfd maintainer, had suggested otherwise). > > > > You should not need to concern yourself with patch ordering outside > > of the realms of the set i.e. [PATCH 1/x], [PATCH 2/x], etc. > > > > If you just send the whole patch set and you do not specify otherwise, > > it will be applied, in order, as a set. > > > > Sending subsystem patches without the correct maintainers as recipients > > is bad form. Many of us have filters on, so this tactic will seldom > > work in any case. > > > > In my case, there're mfd/backlight/regulator for RT4831. > You mean I can just send the whole patch set directly to whole > mfd/backlight/regulator maintainers. > And you can filter like as the keyword to review the related contents, right? > > From my original thought, the order is mfd -> backlight-> regulator, > one by one due to different maintainers. > Maybe I think too much about the patch ordering > > If so, after getting the comment from Rob, I'll send the whole patch to you. > Thanks for the notice. Simply send them all as a single patch-set. It's a good idea to add all maintainers to all patches. We will then coordinate amongst ourselves and come up with the best merge strategy. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml new file mode 100644 index 00000000..f24c8d1 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml @@ -0,0 +1,76 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/richtek,rt4831-backlight.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Richtek RT4831 Backlight + +maintainers: + - ChiYuan Huang <cy_huang@richtek.com> + +description: | + RT4831 is a mutifunctional device that can provide power to the LCD display + and LCD backlight. + + For the LCD backlight, it can provide four channel WLED driving capability. + Each channel driving current is up to 30mA + + Datasheet is available at + https://www.richtek.com/assets/product_file/RT4831A/DS4831A-05.pdf + +properties: + compatible: + const: richtek,rt4831-backlight + + default-brightness: + description: | + The default brightness that applied to the system on start-up. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 2048 + + max-brightness: + description: | + The max brightness for the H/W limit + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0 + maximum: 2048 + + richtek,pwm-enable: + description: | + Specify the backlight dimming following by PWM duty or by SW control. + type: boolean + + richtek,bled-ovp-sel: + description: | + Backlight OVP level selection, currently support 17V/21V/25V/29V. + $ref: /schemas/types.yaml#/definitions/uint8 + default: 1 + minimum: 0 + maximum: 3 + + richtek,channel-use: + description: | + Backlight LED channel to be used. + BIT 0/1/2/3 is used to indicate led channel 1/2/3/4 enable or disable. + $ref: /schemas/types.yaml#/definitions/uint8 + minimum: 1 + maximum: 15 + +required: + - compatible + - richtek,channel-use + +additionalProperties: false + +examples: + - | + #include <dt-bindings/leds/rt4831-backlight.h> + backlight { + compatible = "richtek,rt4831-backlight"; + default-brightness = <1024>; + max-brightness = <2048>; + richtek,bled-ovp-sel = /bits/ 8 <RT4831_BLOVPLVL_21V>; + richtek,channel-use = /bits/ 8 <RT4831_BLED_ALLCHEN>; + }; diff --git a/include/dt-bindings/leds/rt4831-backlight.h b/include/dt-bindings/leds/rt4831-backlight.h new file mode 100644 index 00000000..125c635 --- /dev/null +++ b/include/dt-bindings/leds/rt4831-backlight.h @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * This header provides constants for rt4831 backlight bindings. + * + * Copyright (C) 2020, Richtek Technology Corp. + * Author: ChiYuan Huang <cy_huang@richtek.com> + */ + +#ifndef _DT_BINDINGS_RT4831_BACKLIGHT_H +#define _DT_BINDINGS_RT4831_BACKLIGHT_H + +#define RT4831_BLOVPLVL_17V 0 +#define RT4831_BLOVPLVL_21V 1 +#define RT4831_BLOVPLVL_25V 2 +#define RT4831_BLOVPLVL_29V 3 + +#define RT4831_BLED_CH1EN (1 << 0) +#define RT4831_BLED_CH2EN (1 << 1) +#define RT4831_BLED_CH3EN (1 << 2) +#define RT4831_BLED_CH4EN (1 << 3) +#define RT4831_BLED_ALLCHEN ((1 << 4) - 1) + +#endif /* _DT_BINDINGS_RT4831_BACKLIGHT_H */