diff mbox series

[1/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5

Message ID 20201210212903.216728-1-krzk@kernel.org
State Accepted
Commit cb31334687db31c691901269d65074a7ffaecb18
Headers show
Series [1/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5 | expand

Commit Message

Krzysztof Kozlowski Dec. 10, 2020, 9:28 p.m. UTC
The Samsung PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Fixes: b004a34bd0ff ("ARM: dts: exynos: Add exynos3250-artik5 dtsi file for ARTIK5 module")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Szyprowski Dec. 11, 2020, 3:49 p.m. UTC | #1
On 10.12.2020 22:28, Krzysztof Kozlowski wrote:
> The Samsung PMIC datasheets describe the interrupt line as active low
> with a requirement of acknowledge from the CPU.  Without specifying the
> interrupt type in Devicetree, kernel might apply some fixed
> configuration, not necessarily working for this hardware.
>
> Fixes: b004a34bd0ff ("ARM: dts: exynos: Add exynos3250-artik5 dtsi file for ARTIK5 module")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>   arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +-
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
> index 04290ec4583a..829c05b2c405 100644
> --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
> +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
> @@ -79,7 +79,7 @@ &i2c_0 {
>   	pmic@66 {
>   		compatible = "samsung,s2mps14-pmic";
>   		interrupt-parent = <&gpx3>;
> -		interrupts = <5 IRQ_TYPE_NONE>;
> +		interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&s2mps14_irq>;
>   		reg = <0x66>;

Best regards
Marek Szyprowski Dec. 11, 2020, 3:49 p.m. UTC | #2
On 10.12.2020 22:29, Krzysztof Kozlowski wrote:
> The Samsung PMIC datasheets describe the interrupt line as active low

> with a requirement of acknowledge from the CPU.  The falling edge

> interrupt will mostly work but it's not correct.

>

> Fixes: aac4e0615341 ("ARM: dts: odroidxu3: Enable wake alarm of S2MPS11 RTC")

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

> ---

>   arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +-

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

>   1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi

> index d0df560eb0db..6d690b1db099 100644

> --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi

> +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi

> @@ -509,7 +509,7 @@ pmic@66 {

>   		samsung,s2mps11-acokb-ground;

>   

>   		interrupt-parent = <&gpx0>;

> -		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;

> +		interrupts = <4 IRQ_TYPE_LEVEL_LOW>;

>   		pinctrl-names = "default";

>   		pinctrl-0 = <&s2mps11_irq>;

>   


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Marek Szyprowski Dec. 11, 2020, 3:51 p.m. UTC | #3
On 10.12.2020 22:28, Krzysztof Kozlowski wrote:
> The Samsung PMIC datasheets describe the interrupt line as active low

> with a requirement of acknowledge from the CPU.  The falling edge

> interrupt will mostly work but it's not correct.

>

> Fixes: 1fed2252713e ("ARM: dts: fix pinctrl for s2mps11-irq on exynos5420-arndale-octa")

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

> ---

>   arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +-

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

>   1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts

> index bf457d0c02eb..1aad4859c5f1 100644

> --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts

> +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts

> @@ -349,7 +349,7 @@ pmic@66 {

>   		reg = <0x66>;

>   

>   		interrupt-parent = <&gpx3>;

> -		interrupts = <2 IRQ_TYPE_EDGE_FALLING>;

> +		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;

>   		pinctrl-names = "default";

>   		pinctrl-0 = <&s2mps11_irq>;

>   


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Krzysztof Kozlowski Dec. 29, 2020, 3:59 p.m. UTC | #4
On Thu, 10 Dec 2020 22:28:55 +0100, Krzysztof Kozlowski wrote:
> The Samsung PMIC datasheets describe the interrupt line as active low
> with a requirement of acknowledge from the CPU.  Without specifying the
> interrupt type in Devicetree, kernel might apply some fixed
> configuration, not necessarily working for this hardware.

Applied, thanks!

[1/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5
      commit: 58139a7837133538099dc59447f33765b61f5c27
[2/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Monk
      commit: c9b260c91ab61d4094a3c152546d88d41259d647
[3/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Rinato
      commit: 2c9f52d2b09abd25bd00ef2a5a35d9246fc92d88
[4/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Spring
      commit: 1d6f6eee94da4f60ddb2107ffcf55629083711df
[5/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Arndale Octa
      commit: 4a96ea5cf0550766397f5e9221c4f2a949492ee6
[6/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid XU3 family
      commit: 0274326ce6796813842998141174bd5a0e9ff908
[7/9] arm64: dts: exynos: correct PMIC interrupt trigger level on TM2
      commit: 9fd8f10d119c6c48899ace33ff0f7e8702ad1d66
[8/9] arm64: dts: exynos: correct PMIC interrupt trigger level on Espresso
      commit: acdd83e384c41d20d66bc0045f5eb67b6d67ed69

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
index 04290ec4583a..829c05b2c405 100644
--- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
+++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
@@ -79,7 +79,7 @@  &i2c_0 {
 	pmic@66 {
 		compatible = "samsung,s2mps14-pmic";
 		interrupt-parent = <&gpx3>;
-		interrupts = <5 IRQ_TYPE_NONE>;
+		interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&s2mps14_irq>;
 		reg = <0x66>;