diff mbox series

[git:media_tree/master] media: gspca: Fix memory leak in probe

Message ID E1kmHBh-009CER-0L@www.linuxtv.org
State Accepted
Commit e469d0b09a19496e1972a20974bbf55b728151eb
Headers show
Series [git:media_tree/master] media: gspca: Fix memory leak in probe | expand

Commit Message

Mauro Carvalho Chehab Dec. 7, 2020, 2 p.m. UTC 
This is an automatic generated email to let you know that the following patch were queued:

Subject: media: gspca: Fix memory leak in probe
Author:  Alan Stern <stern@rowland.harvard.edu>
Date:    Wed Dec 2 18:20:04 2020 +0100

The gspca driver leaks memory when a probe fails.  gspca_dev_probe2()
calls v4l2_device_register(), which takes a reference to the
underlying device node (in this case, a USB interface).  But the
failure pathway neglects to call v4l2_device_unregister(), the routine
responsible for dropping this reference.  Consequently the memory for
the USB interface and its device never gets released.

This patch adds the missing function call.

Reported-and-tested-by: syzbot+44e64397bd81d5e84cba@syzkaller.appspotmail.com

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: <stable@vger.kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

 drivers/media/usb/gspca/gspca.c | 1 +
 1 file changed, 1 insertion(+)

---
diff mbox series

Patch

diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gspca.c
index c295f642d352..158c8e28ed2c 100644
--- a/drivers/media/usb/gspca/gspca.c
+++ b/drivers/media/usb/gspca/gspca.c
@@ -1575,6 +1575,7 @@  out:
 		input_unregister_device(gspca_dev->input_dev);
 #endif
 	v4l2_ctrl_handler_free(gspca_dev->vdev.ctrl_handler);
+	v4l2_device_unregister(&gspca_dev->v4l2_dev);
 	kfree(gspca_dev->usb_buf);
 	kfree(gspca_dev);
 	return ret;