| Message ID | 1607311260-13983-5-git-send-email-victor.liu@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/imx: Introduce i.MX8qm/qxp DPU DRM | expand |
On Mon, Dec 07, 2020 at 11:20:58AM +0800, Liu Ying wrote: > Artifically use 'plane' and 'old_plane_state' to avoid 'not used' warning. > The precedent has already been set by other macros in the same file. > > Signed-off-by: Liu Ying <victor.liu@nxp.com> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> I'm assuming someone will push this to drm-misc or some other tree. Should probably land sooner than later. -Daniel > --- > v2->v3: > * Add a missing blank line. > > v1->v2: > * No change. > > include/drm/drm_atomic.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index 54e051a..2e087d7 100644 > --- a/include/drm/drm_atomic.h > +++ b/include/drm/drm_atomic.h > @@ -888,7 +888,10 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > (__i)++) \ > for_each_if ((__state)->planes[__i].ptr && \ > ((plane) = (__state)->planes[__i].ptr, \ > - (old_plane_state) = (__state)->planes[__i].old_state, 1)) > + (void)(plane) /* Only to avoid unused-but-set-variable warning */, \ > + (old_plane_state) = (__state)->planes[__i].old_state, \ > + (void)(old_plane_state) /* Only to avoid unused-but-set-variable warning */, 1)) > + > /** > * for_each_new_plane_in_state - iterate over all planes in an atomic update > * @__state: &struct drm_atomic_state pointer > -- > 2.7.4 >
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index 54e051a..2e087d7 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -888,7 +888,10 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); (__i)++) \ for_each_if ((__state)->planes[__i].ptr && \ ((plane) = (__state)->planes[__i].ptr, \ - (old_plane_state) = (__state)->planes[__i].old_state, 1)) + (void)(plane) /* Only to avoid unused-but-set-variable warning */, \ + (old_plane_state) = (__state)->planes[__i].old_state, \ + (void)(old_plane_state) /* Only to avoid unused-but-set-variable warning */, 1)) + /** * for_each_new_plane_in_state - iterate over all planes in an atomic update * @__state: &struct drm_atomic_state pointer
Artifically use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Signed-off-by: Liu Ying <victor.liu@nxp.com> --- v2->v3: * Add a missing blank line. v1->v2: * No change. include/drm/drm_atomic.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)