diff mbox series

[v5,19/19] dt-bindings: usb: intel,keembay-dwc3: Validate DWC3 sub-node

Message ID 20201205152427.29537-20-Sergey.Semin@baikalelectronics.ru
State Superseded
Headers show
Series dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema | expand

Commit Message

Serge Semin Dec. 5, 2020, 3:24 p.m. UTC
Intel Keem Bay DWC3 compatible DT nodes are supposed to have a DWC USB3
compatible sub-node to describe a fully functioning USB interface. Let's
use the available DWC USB3 DT schema to validate the Qualcomm DWC3
sub-nodes.

Note since the generic DWC USB3 DT node is supposed to be named as generic
USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub-nodes name
regexp and fix the DT node example.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

---

Changelog v5:
- This is a new patch created for the new Intel Keem Bay bindings file,
  which has been added just recently.
---
 .../devicetree/bindings/usb/intel,keembay-dwc3.yaml      | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Wan Ahmad Zainie Dec. 6, 2020, 9:56 a.m. UTC | #1
Hi Serge.

> -----Original Message-----

> From: Serge Semin <Sergey.Semin@baikalelectronics.ru>

> Sent: Saturday, December 5, 2020 11:24 PM

> To: Nyman, Mathias <mathias.nyman@intel.com>; Felipe Balbi

> <balbi@kernel.org>; Krzysztof Kozlowski <krzk@kernel.org>; Greg Kroah-

> Hartman <gregkh@linuxfoundation.org>; Rob Herring

> <robh+dt@kernel.org>; Chunfeng Yun <chunfeng.yun@mediatek.com>;

> Wan Mohamad, Wan Ahmad Zainie

> <wan.ahmad.zainie.wan.mohamad@intel.com>

> Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>; Serge Semin

> <fancer.lancer@gmail.com>; Alexey Malahov

> <Alexey.Malahov@baikalelectronics.ru>; Pavel Parkhomenko

> <Pavel.Parkhomenko@baikalelectronics.ru>; Andy Gross

> <agross@kernel.org>; Bjorn Andersson <bjorn.andersson@linaro.org>;

> Manu Gautam <mgautam@codeaurora.org>; Roger Quadros

> <rogerq@ti.com>; Lad Prabhakar <prabhakar.mahadev-

> lad.rj@bp.renesas.com>; Yoshihiro Shimoda

> <yoshihiro.shimoda.uh@renesas.com>; narmstrong

> <narmstrong@baylibre.com>; Kevin Hilman <khilman@baylibre.com>;

> Martin Blumenstingl <martin.blumenstingl@googlemail.com>; linux-arm-

> kernel@lists.infradead.org; linux-snps-arc@lists.infradead.org; linux-

> mips@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-

> usb@vger.kernel.org; devicetree@vger.kernel.org; linux-

> kernel@vger.kernel.org

> Subject: [PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate

> DWC3 sub-node

> 

> Intel Keem Bay DWC3 compatible DT nodes are supposed to have a DWC

> USB3 compatible sub-node to describe a fully functioning USB interface. Let's

> use the available DWC USB3 DT schema to validate the Qualcomm DWC3 sub-

> nodes.

> 

> Note since the generic DWC USB3 DT node is supposed to be named as

> generic USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub-

> nodes name regexp and fix the DT node example.

> 

> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>


LGTM. With minor change to fix the typo above, Qualcomm to Intel
Keem Bay,
Acked-by: Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>


> 

> ---

> 

> Changelog v5:

> - This is a new patch created for the new Intel Keem Bay bindings file,

>   which has been added just recently.

> ---

>  .../devicetree/bindings/usb/intel,keembay-dwc3.yaml      | 9 +++------

>  1 file changed, 3 insertions(+), 6 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/usb/intel,keembay-

> dwc3.yaml b/Documentation/devicetree/bindings/usb/intel,keembay-

> dwc3.yaml

> index dd32c10ce6c7..43b91ab62004 100644

> --- a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml

> +++ b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml

> @@ -34,11 +34,8 @@ properties:

>  # Required child node:

> 

>  patternProperties:

> -  "^dwc3@[0-9a-f]+$":

> -    type: object

> -    description:

> -      A child node must exist to represent the core DWC3 IP block.

> -      The content of the node is defined in dwc3.txt.

> +  "^usb@[0-9a-f]+$":

> +    $ref: snps,dwc3.yaml#

> 

>  required:

>    - compatible

> @@ -68,7 +65,7 @@ examples:

>            #address-cells = <1>;

>            #size-cells = <1>;

> 

> -          dwc3@34000000 {

> +          usb@34000000 {

>                  compatible = "snps,dwc3";

>                  reg = <0x34000000 0x10000>;

>                  interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;

> --

> 2.29.2


Best regards,
Zainie
Serge Semin Dec. 6, 2020, 10:05 a.m. UTC | #2
Hi Wan,

On Sun, Dec 06, 2020 at 09:56:47AM +0000, Wan Mohamad, Wan Ahmad Zainie wrote:
> Hi Serge.

> 

> > -----Original Message-----

> > From: Serge Semin <Sergey.Semin@baikalelectronics.ru>

> > Sent: Saturday, December 5, 2020 11:24 PM

> > To: Nyman, Mathias <mathias.nyman@intel.com>; Felipe Balbi

> > <balbi@kernel.org>; Krzysztof Kozlowski <krzk@kernel.org>; Greg Kroah-

> > Hartman <gregkh@linuxfoundation.org>; Rob Herring

> > <robh+dt@kernel.org>; Chunfeng Yun <chunfeng.yun@mediatek.com>;

> > Wan Mohamad, Wan Ahmad Zainie

> > <wan.ahmad.zainie.wan.mohamad@intel.com>

> > Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>; Serge Semin

> > <fancer.lancer@gmail.com>; Alexey Malahov

> > <Alexey.Malahov@baikalelectronics.ru>; Pavel Parkhomenko

> > <Pavel.Parkhomenko@baikalelectronics.ru>; Andy Gross

> > <agross@kernel.org>; Bjorn Andersson <bjorn.andersson@linaro.org>;

> > Manu Gautam <mgautam@codeaurora.org>; Roger Quadros

> > <rogerq@ti.com>; Lad Prabhakar <prabhakar.mahadev-

> > lad.rj@bp.renesas.com>; Yoshihiro Shimoda

> > <yoshihiro.shimoda.uh@renesas.com>; narmstrong

> > <narmstrong@baylibre.com>; Kevin Hilman <khilman@baylibre.com>;

> > Martin Blumenstingl <martin.blumenstingl@googlemail.com>; linux-arm-

> > kernel@lists.infradead.org; linux-snps-arc@lists.infradead.org; linux-

> > mips@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-

> > usb@vger.kernel.org; devicetree@vger.kernel.org; linux-

> > kernel@vger.kernel.org

> > Subject: [PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate

> > DWC3 sub-node

> > 

> > Intel Keem Bay DWC3 compatible DT nodes are supposed to have a DWC

> > USB3 compatible sub-node to describe a fully functioning USB interface. Let's

> > use the available DWC USB3 DT schema to validate the Qualcomm DWC3 sub-

> > nodes.

> > 

> > Note since the generic DWC USB3 DT node is supposed to be named as

> > generic USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub-

> > nodes name regexp and fix the DT node example.

> > 

> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

> 


> LGTM. With minor change to fix the typo above, Qualcomm to Intel

> Keem Bay,

> Acked-by: Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>


Ah, right. Thanks for noticing that. A probability of copy-paste mistakes
increases proportionally to the number sleepless hours.)

-Sergey

> 

> > 

> > ---

> > 

> > Changelog v5:

> > - This is a new patch created for the new Intel Keem Bay bindings file,

> >   which has been added just recently.

> > ---

> >  .../devicetree/bindings/usb/intel,keembay-dwc3.yaml      | 9 +++------

> >  1 file changed, 3 insertions(+), 6 deletions(-)

> > 

> > diff --git a/Documentation/devicetree/bindings/usb/intel,keembay-

> > dwc3.yaml b/Documentation/devicetree/bindings/usb/intel,keembay-

> > dwc3.yaml

> > index dd32c10ce6c7..43b91ab62004 100644

> > --- a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml

> > +++ b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml

> > @@ -34,11 +34,8 @@ properties:

> >  # Required child node:

> > 

> >  patternProperties:

> > -  "^dwc3@[0-9a-f]+$":

> > -    type: object

> > -    description:

> > -      A child node must exist to represent the core DWC3 IP block.

> > -      The content of the node is defined in dwc3.txt.

> > +  "^usb@[0-9a-f]+$":

> > +    $ref: snps,dwc3.yaml#

> > 

> >  required:

> >    - compatible

> > @@ -68,7 +65,7 @@ examples:

> >            #address-cells = <1>;

> >            #size-cells = <1>;

> > 

> > -          dwc3@34000000 {

> > +          usb@34000000 {

> >                  compatible = "snps,dwc3";

> >                  reg = <0x34000000 0x10000>;

> >                  interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;

> > --

> > 2.29.2

> 

> Best regards,

> Zainie
Rob Herring (Arm) Dec. 7, 2020, 4:53 p.m. UTC | #3
On Sat, 05 Dec 2020 18:24:26 +0300, Serge Semin wrote:
> Intel Keem Bay DWC3 compatible DT nodes are supposed to have a DWC USB3

> compatible sub-node to describe a fully functioning USB interface. Let's

> use the available DWC USB3 DT schema to validate the Qualcomm DWC3

> sub-nodes.

> 

> Note since the generic DWC USB3 DT node is supposed to be named as generic

> USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub-nodes name

> regexp and fix the DT node example.

> 

> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

> 

> ---

> 

> Changelog v5:

> - This is a new patch created for the new Intel Keem Bay bindings file,

>   which has been added just recently.

> ---

>  .../devicetree/bindings/usb/intel,keembay-dwc3.yaml      | 9 +++------

>  1 file changed, 3 insertions(+), 6 deletions(-)

> 


Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml
index dd32c10ce6c7..43b91ab62004 100644
--- a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml
@@ -34,11 +34,8 @@  properties:
 # Required child node:
 
 patternProperties:
-  "^dwc3@[0-9a-f]+$":
-    type: object
-    description:
-      A child node must exist to represent the core DWC3 IP block.
-      The content of the node is defined in dwc3.txt.
+  "^usb@[0-9a-f]+$":
+    $ref: snps,dwc3.yaml#
 
 required:
   - compatible
@@ -68,7 +65,7 @@  examples:
           #address-cells = <1>;
           #size-cells = <1>;
 
-          dwc3@34000000 {
+          usb@34000000 {
                 compatible = "snps,dwc3";
                 reg = <0x34000000 0x10000>;
                 interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;