diff mbox series

[2/3] platform/chrome: cros_ec_spi: Drop bits_per_word assignment

Message ID 20201204193540.3047030-3-swboyd@chromium.org
State Accepted
Commit 7a5172b7990d97ab9ef64e6d9063aa68099ea023
Headers show
Series spi: spi-geni-qcom: Use gpio descriptors for CS | expand

Commit Message

Stephen Boyd Dec. 4, 2020, 7:35 p.m. UTC
This is already handed by default in spi_setup() if the bits_per_word is
0, so just drop it to shave off a line.

Cc: Simon Glass <sjg@chromium.org>
Cc: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Alexandru M Stan <amstan@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 drivers/platform/chrome/cros_ec_spi.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Simon Glass Dec. 9, 2020, 4:41 p.m. UTC | #1
On Fri, 4 Dec 2020 at 12:35, Stephen Boyd <swboyd@chromium.org> wrote:
>

> This is already handed by default in spi_setup() if the bits_per_word is

> 0, so just drop it to shave off a line.

>

> Cc: Simon Glass <sjg@chromium.org>

> Cc: Gwendal Grignou <gwendal@chromium.org>

> Reviewed-by: Douglas Anderson <dianders@chromium.org>

> Tested-by: Douglas Anderson <dianders@chromium.org>

> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> Cc: Alexandru M Stan <amstan@chromium.org>

> Signed-off-by: Stephen Boyd <swboyd@chromium.org>

> ---

>  drivers/platform/chrome/cros_ec_spi.c | 1 -

>  1 file changed, 1 deletion(-)


Reviewed-by: Simon Glass <sjg@chromium.org>



>

> diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c

> index f9df218fc2bb..14c4046fa04d 100644

> --- a/drivers/platform/chrome/cros_ec_spi.c

> +++ b/drivers/platform/chrome/cros_ec_spi.c

> @@ -741,7 +741,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)

>         struct cros_ec_spi *ec_spi;

>         int err;

>

> -       spi->bits_per_word = 8;

>         spi->rt = true;

>         err = spi_setup(spi);

>         if (err < 0)

> --

> https://chromeos.dev

>
diff mbox series

Patch

diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
index f9df218fc2bb..14c4046fa04d 100644
--- a/drivers/platform/chrome/cros_ec_spi.c
+++ b/drivers/platform/chrome/cros_ec_spi.c
@@ -741,7 +741,6 @@  static int cros_ec_spi_probe(struct spi_device *spi)
 	struct cros_ec_spi *ec_spi;
 	int err;
 
-	spi->bits_per_word = 8;
 	spi->rt = true;
 	err = spi_setup(spi);
 	if (err < 0)