diff mbox series

[net] net: mvpp2: Fix error return code in mvpp2_open()

Message ID 20201203141806.37966-1-wanghai38@huawei.com
State New
Headers show
Series [net] net: mvpp2: Fix error return code in mvpp2_open() | expand

Commit Message

Wang Hai Dec. 3, 2020, 2:18 p.m. UTC
Fix to return negative error code -ENOENT from invalid configuration
error handling case instead of 0, as done elsewhere in this function.

Fixes: 4bb043262878 ("net: mvpp2: phylink support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jakub Kicinski Dec. 3, 2020, 6:59 p.m. UTC | #1
On Thu, 3 Dec 2020 16:23:46 +0100 Andrew Lunn wrote:
> On Thu, Dec 03, 2020 at 10:18:06PM +0800, Wang Hai wrote:
> > Fix to return negative error code -ENOENT from invalid configuration
> > error handling case instead of 0, as done elsewhere in this function.
> > 
> > Fixes: 4bb043262878 ("net: mvpp2: phylink support")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Wang Hai <wanghai38@huawei.com>  
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Applied, thanks!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index f6616c8933ca..cea886c5bcb5 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -4426,6 +4426,7 @@  static int mvpp2_open(struct net_device *dev)
 	if (!valid) {
 		netdev_err(port->dev,
 			   "invalid configuration: no dt or link IRQ");
+		err = -ENOENT;
 		goto err_free_irq;
 	}