| Message ID | 6185f3fc-35ed-4de2-8bf7-fb991555580c@EXC03-ATKLA.omicron.at |
|---|---|
| State | Accepted |
| Commit | dc4e10b62695558a39aafa65210f5980125285b3 |
| Headers | show |
| Series | i2c: ocores: Avoid false-positive error log message. | expand |
On Thu, Dec 03, 2020 at 04:02:52PM +0100, Stefan Lässer wrote: > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to > platform_get_irq*()"), platform_get_irq() will call dev_err() on an error. > In case of i2c ocores this leads to a false-positive error being logged: > > [ 4.173989] 007: ocores-i2c ocores-i2c: IRQ index 0 not found > > i2c ocores already handles the case when the IRQ cannot be found and > therefore there is no benefit in having this error message being logged. > > This commit switches to platform_get_irq_optional(), which does not log > in case the IRQ cannot be found. > > Signed-off-by: Stefan Lässer <stefan.laesser@omicronenergy.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
> > Signed-off-by: Stefan Lässer <stefan.laesser@omicronenergy.com> > > Applied to for-current, thanks! I meant for-next (because of a dependency), sorry for the noise.
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index a97cbaabd..273222e38 100644 --- a/drivers/i2c/busses/i2c-ocores.c +++ b/drivers/i2c/busses/i2c-ocores.c @@ -682,7 +682,7 @@ static int ocores_i2c_probe(struct platform_device *pdev) init_waitqueue_head(&i2c->wait); - irq = platform_get_irq(pdev, 0); + irq = platform_get_irq_optional(pdev, 0); /* * Since the SoC does have an interrupt, its DT has an interrupt * property - But this should be bypassed as the IRQ logic in this
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()"), platform_get_irq() will call dev_err() on an error. In case of i2c ocores this leads to a false-positive error being logged: [ 4.173989] 007: ocores-i2c ocores-i2c: IRQ index 0 not found i2c ocores already handles the case when the IRQ cannot be found and therefore there is no benefit in having this error message being logged. This commit switches to platform_get_irq_optional(), which does not log in case the IRQ cannot be found. Signed-off-by: Stefan Lässer <stefan.laesser@omicronenergy.com> --- drivers/i2c/busses/i2c-ocores.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)