diff mbox series

cpufreq: scmi: add COMMON_CLK dependency

Message ID 20201203225550.1478195-1-arnd@kernel.org
State Superseded
Headers show
Series cpufreq: scmi: add COMMON_CLK dependency | expand

Commit Message

Arnd Bergmann Dec. 3, 2020, 10:55 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de>


Wtihout CONFIG_COMMON_CLK, the scmi driver fails to link:

arm-linux-gnueabi-ld: drivers/cpufreq/scmi-cpufreq.o: in function `scmi_cpufreq_probe':
scmi-cpufreq.c:(.text+0x20c): undefined reference to `devm_of_clk_add_hw_provider'
arm-linux-gnueabi-ld: scmi-cpufreq.c:(.text+0x22c): undefined reference to `of_clk_hw_simple_get'

Add a Kconfig dependency for it.

Fixes: 8410e7f3b31e ("cpufreq: scmi: Fix OPP addition failure with a dummy clock provider")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/cpufreq/Kconfig.arm | 1 +
 1 file changed, 1 insertion(+)

-- 
2.27.0

Comments

Viresh Kumar Dec. 7, 2020, 6:33 a.m. UTC | #1
On 03-12-20, 23:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> 

> Wtihout CONFIG_COMMON_CLK, the scmi driver fails to link:

> 

> arm-linux-gnueabi-ld: drivers/cpufreq/scmi-cpufreq.o: in function `scmi_cpufreq_probe':

> scmi-cpufreq.c:(.text+0x20c): undefined reference to `devm_of_clk_add_hw_provider'

> arm-linux-gnueabi-ld: scmi-cpufreq.c:(.text+0x22c): undefined reference to `of_clk_hw_simple_get'

> 

> Add a Kconfig dependency for it.

> 

> Fixes: 8410e7f3b31e ("cpufreq: scmi: Fix OPP addition failure with a dummy clock provider")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  drivers/cpufreq/Kconfig.arm | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm

> index 1f73fa75b1a0..434ef03d2762 100644

> --- a/drivers/cpufreq/Kconfig.arm

> +++ b/drivers/cpufreq/Kconfig.arm

> @@ -264,6 +264,7 @@ config ARM_SA1110_CPUFREQ

>  config ARM_SCMI_CPUFREQ

>  	tristate "SCMI based CPUfreq driver"

>  	depends on ARM_SCMI_PROTOCOL || COMPILE_TEST

> +	depends on COMMON_CLK

>  	select PM_OPP

>  	help

>  	  This adds the CPUfreq driver support for ARM platforms using SCMI


This is already fixed by:

commit f943849f7206 ("cpufreq: scmi: Fix build for !CONFIG_COMMON_CLK")

-- 
viresh
diff mbox series

Patch

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 1f73fa75b1a0..434ef03d2762 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -264,6 +264,7 @@  config ARM_SA1110_CPUFREQ
 config ARM_SCMI_CPUFREQ
 	tristate "SCMI based CPUfreq driver"
 	depends on ARM_SCMI_PROTOCOL || COMPILE_TEST
+	depends on COMMON_CLK
 	select PM_OPP
 	help
 	  This adds the CPUfreq driver support for ARM platforms using SCMI