Message ID | 20201203222828.1029943-1-arnd@kernel.org |
---|---|
State | New |
Headers | show |
Series | media: smiapp: avoid printing an uninitialized variable | expand |
Hi Arnd, Thanks for the patch. On Thu, Dec 03, 2020 at 11:28:16PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > There is no intialization for the 'reg' variable, so printing > it produces undefined behavior as well as a compile-time warning: > > drivers/media/i2c/ccs/ccs-core.c:314:49: error: variable 'reg' is uninitialized when used here [-Werror,-Wuninitialized] > "0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg, > > Remove the variable and stop printing it. > > Fixes: b24cc2a18c50 ("media: smiapp: Rename as "ccs"") The patch introducing this was fd9065812c7b ("media: smiapp: Obtain frame descriptor from CCS limits") so I'll use it instead. Also s/smiapp/ccs/ in the subject. Interesting that GCC 8.3 didn't complain. -- Kind regards, Sakari Ailus
diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c index 69e7990c65f3..58a42459109d 100644 --- a/drivers/media/i2c/ccs/ccs-core.c +++ b/drivers/media/i2c/ccs/ccs-core.c @@ -257,7 +257,6 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor) u32 pixels; char *which; char *what; - u32 reg; if (fmt_model_type == CCS_FRAME_FORMAT_MODEL_TYPE_2_BYTE) { desc = CCS_LIM_AT(sensor, FRAME_FORMAT_DESCRIPTOR, i); @@ -311,7 +310,7 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor) } dev_dbg(&client->dev, - "0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg, + "%s pixels: %d %s (pixelcode %u)\n", what, pixels, which, pixelcode); if (i < ncol_desc) {