[4.14,26/50] phy: tegra: xusb: Fix dangling pointer on probe failure

From: Marc Zyngier <maz@kernel.org>

From: Marc Zyngier <maz@kernel.org>

[ Upstream commit eb9c4dd9bdfdebaa13846c16a8c79b5b336066b6 ]

If, for some reason, the xusb PHY fails to probe, it leaves
a dangling pointer attached to the platform device structure.

This would normally be harmless, but the Tegra XHCI driver then
goes and extract that pointer from the PHY device. Things go
downhill from there:

    8.752082] [004d554e5145533c] address between user and kernel address ranges
[    8.752085] Internal error: Oops: 96000004 [#1] PREEMPT SMP
[    8.752088] Modules linked in: max77620_regulator(E+) xhci_tegra(E+) sdhci_tegra(E+) xhci_hcd(E) sdhci_pltfm(E) cqhci(E) fixed(E) usbcore(E) scsi_mod(E) sdhci(E) host1x(E+)
[    8.752103] CPU: 4 PID: 158 Comm: systemd-udevd Tainted: G S      W   E     5.9.0-rc7-00298-gf6337624c4fe #1980
[    8.752105] Hardware name: NVIDIA Jetson TX2 Developer Kit (DT)
[    8.752108] pstate: 20000005 (nzCv daif -PAN -UAO BTYPE=--)
[    8.752115] pc : kobject_put+0x1c/0x21c
[    8.752120] lr : put_device+0x20/0x30
[    8.752121] sp : ffffffc012eb3840
[    8.752122] x29: ffffffc012eb3840 x28: ffffffc010e82638
[    8.752125] x27: ffffffc008d56440 x26: 0000000000000000
[    8.752128] x25: ffffff81eb508200 x24: 0000000000000000
[    8.752130] x23: ffffff81eb538800 x22: 0000000000000000
[    8.752132] x21: 00000000fffffdfb x20: ffffff81eb538810
[    8.752134] x19: 3d4d554e51455300 x18: 0000000000000020
[    8.752136] x17: ffffffc008d00270 x16: ffffffc008d00c94
[    8.752138] x15: 0000000000000004 x14: ffffff81ebd4ae90
[    8.752140] x13: 0000000000000000 x12: ffffff81eb86a4e8
[    8.752142] x11: ffffff81eb86a480 x10: ffffff81eb862fea
[    8.752144] x9 : ffffffc01055fb28 x8 : ffffff81eb86a4a8
[    8.752146] x7 : 0000000000000001 x6 : 0000000000000001
[    8.752148] x5 : ffffff81dff8bc38 x4 : 0000000000000000
[    8.752150] x3 : 0000000000000001 x2 : 0000000000000001
[    8.752152] x1 : 0000000000000002 x0 : 3d4d554e51455300
[    8.752155] Call trace:
[    8.752157]  kobject_put+0x1c/0x21c
[    8.752160]  put_device+0x20/0x30
[    8.752164]  tegra_xusb_padctl_put+0x24/0x3c
[    8.752170]  tegra_xusb_probe+0x8b0/0xd10 [xhci_tegra]
[    8.752174]  platform_drv_probe+0x60/0xb4
[    8.752176]  really_probe+0xf0/0x504
[    8.752179]  driver_probe_device+0x100/0x170
[    8.752181]  device_driver_attach+0xcc/0xd4
[    8.752183]  __driver_attach+0xb0/0x17c
[    8.752185]  bus_for_each_dev+0x7c/0xd4
[    8.752187]  driver_attach+0x30/0x3c
[    8.752189]  bus_add_driver+0x154/0x250
[    8.752191]  driver_register+0x84/0x140
[    8.752193]  __platform_driver_register+0x54/0x60
[    8.752197]  tegra_xusb_init+0x40/0x1000 [xhci_tegra]
[    8.752201]  do_one_initcall+0x54/0x2d0
[    8.752205]  do_init_module+0x68/0x29c
[    8.752207]  load_module+0x2178/0x26c0
[    8.752209]  __do_sys_finit_module+0xb0/0x120
[    8.752211]  __arm64_sys_finit_module+0x2c/0x40
[    8.752215]  el0_svc_common.constprop.0+0x80/0x240
[    8.752218]  do_el0_svc+0x30/0xa0
[    8.752220]  el0_svc+0x18/0x50
[    8.752223]  el0_sync_handler+0x90/0x318
[    8.752225]  el0_sync+0x158/0x180
[    8.752230] Code: a9bd7bfd 910003fd a90153f3 aa0003f3 (3940f000)
[    8.752232] ---[ end trace 90f6c89d62d85ff5 ]---

Reset the pointer on probe failure fixes the issue.

Fixes: 53d2a715c2403 ("phy: Add Tegra XUSB pad controller support")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20201013095820.311376-1-maz@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/phy/tegra/xusb.c | 1 +
 1 file changed, 1 insertion(+)

Message ID	20201201084648.319742063@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Marc Zyngier <maz@kernel.org>, Vinod Koul <vkoul@kernel.org>, Sasha Levin <sashal@kernel.org> Subject: [PATCH 4.14 26/50] phy: tegra: xusb: Fix dangling pointer on probe failure Date: Tue, 1 Dec 2020 09:53:25 +0100 Message-Id: <20201201084648.319742063@linuxfoundation.org> In-Reply-To: <20201201084644.803812112@linuxfoundation.org> References: <20201201084644.803812112@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [4.14,02/50] mm/userfaultfd: do not access vma->vm_mm after calling handle_userfault() [4.14,03/50] btrfs: fix lockdep splat when reading qgroup config on mount [4.14,04/50] wireless: Use linux/stddef.h instead of stddef.h [4.14,05/50] PCI: Add device even if driver attach failed [4.14,06/50] btrfs: tree-checker: Enhance chunk checker to validate chunk profile [4.14,07/50] btrfs: adjust return values of btrfs_inode_by_name [4.14,08/50] btrfs: inode: Verify inode mode to avoid NULL pointer dereference [4.14,09/50] KVM: x86: Fix split-irqchip vs interrupt injection window request [4.14,10/50] arm64: pgtable: Fix pte_accessible() [4.14,11/50] arm64: pgtable: Ensure dirty bit is preserved across pte_wrprotect() [4.14,12/50] ALSA: hda/hdmi: Use single mutex unlock in error paths [4.14,13/50] ALSA: hda/hdmi: fix incorrect locking in hdmi_pcm_close [4.14,14/50] HID: cypress: Support Varmilo Keyboards media hotkeys [4.14,15/50] Input: i8042 - allow insmod to succeed on devices without an i8042 controller [4.14,16/50] HID: hid-sensor-hub: Fix issue with devices with no report ID [4.14,17/50] dmaengine: xilinx_dma: use readl_poll_timeout_atomic variant [4.14,18/50] x86/xen: dont unbind uninitialized lock_kicker_irq [4.14,19/50] HID: Add Logitech Dinovo Edge battery quirk [4.14,20/50] proc: dont allow async path resolution of /proc/self components [4.14,21/50] nvme: free sq/cq dbbuf pointers when dbbuf set fails [4.14,22/50] dmaengine: pl330: _prep_dma_memcpy: Fix wrong burst size [4.14,23/50] scsi: libiscsi: Fix NOP race condition [4.14,24/50] scsi: target: iscsi: Fix cmd abort fabric stop race [4.14,25/50] perf/x86: fix sysfs type mismatches [4.14,26/50] phy: tegra: xusb: Fix dangling pointer on probe failure [4.14,27/50] batman-adv: set .owner to THIS_MODULE [4.14,28/50] scsi: ufs: Fix race between shutdown and runtime resume flow [4.14,29/50] bnxt_en: fix error return code in bnxt_init_one() [4.14,30/50] bnxt_en: fix error return code in bnxt_init_board() [4.14,31/50] video: hyperv_fb: Fix the cache type when mapping the VRAM [4.14,32/50] bnxt_en: Release PCI regions when DMA mask setup fails during probe. [4.14,33/50] IB/mthca: fix return value of error branch in mthca_init_cq() [4.14,34/50] nfc: s3fwrn5: use signed integer for parsing GPIO numbers [4.14,35/50] net: ena: set initial DMA width to avoid intel iommu issue [4.14,36/50] ibmvnic: fix NULL pointer dereference in reset_sub_crq_queues [4.14,37/50] ibmvnic: fix NULL pointer dereference in ibmvic_reset_crq [4.14,38/50] efivarfs: revert "fix memory leak in efivarfs_create()" [4.14,39/50] can: gs_usb: fix endianess problem with candleLight firmware [4.14,40/50] platform/x86: toshiba_acpi: Fix the wrong variable assignment [4.14,41/50] can: m_can: fix nominal bitiming tseg2 min for version >= 3.1 [4.14,42/50] perf probe: Fix to die_entrypc() returns error correctly [4.14,43/50] USB: core: Change %pK for __user pointers to %px [4.14,44/50] usb: gadget: f_midi: Fix memleak in f_midi_alloc [4.14,45/50] usb: gadget: Fix memleak in gadgetfs_fill_super [4.14,46/50] x86/speculation: Fix prctl() when spectre_v2_user={seccomp,prctl},ibpb [4.14,47/50] x86/resctrl: Remove superfluous kernfs_get() calls to prevent refcount leak [4.14,48/50] x86/resctrl: Add necessary kernfs_put() calls to prevent refcount leak [4.14,49/50] USB: core: add endpoint-blacklist quirk [4.14,50/50] USB: core: Fix regression in Hercules audio card

[4.14,26/50] phy: tegra: xusb: Fix dangling pointer on probe failure

Commit Message

Patch