diff mbox series

[36/38] ccs: Print written register values

Message ID	20201202180641.17401-37-sakari.ailus@linux.intel.com
State	Accepted
Commit	ba9dfeeb4fbe70885ac5372adf463659a9d499da
Headers	show Return-Path: <linux-media-owner@kernel.org> From: Sakari Ailus <sakari.ailus@linux.intel.com> To: linux-media@vger.kernel.org Cc: mchehab@kernel.org Subject: [PATCH 36/38] ccs: Print written register values Date: Wed, 2 Dec 2020 20:06:39 +0200 Message-Id: <20201202180641.17401-37-sakari.ailus@linux.intel.com> In-Reply-To: <20201202180641.17401-1-sakari.ailus@linux.intel.com> References: <20201202180641.17401-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Support additional CCS PLL features, C-PHY \| expand [00/38] Support additional CCS PLL features, C-PHY [02/38] ccs-pll: Split limits and PLL configuration into front and back parts [04/38] ccs-pll: End search if there are no better values available [05/38] ccs-pll: Remove parallel bus support [06/38] ccs-pll: Differentiate between CSI-2 D-PHY and C-PHY [10/38] ccs-pll: Begin calculation from OP system clock frequency [12/38] ccs-pll: Avoid overflow in pre-PLL divisor lower bound search [16/38] ccs-pll: Add support for lane speed model [17/38] ccs: Add support for lane speed model [19/38] ccs-pll: Add support for extended input PLL clock divider [22/38] ccs-pll: Add sanity checks [23/38] ccs-pll: Add C-PHY support [24/38] ccs-pll: Split off VT subtree calculation [27/38] ccs-pll: Print relevant information on PLL tree [29/38] ccs-pll: Make VT divisors 16-bit [30/38] ccs-pll: Fix VT post-PLL divisor calculation [32/38] ccs-pll: Add trivial dual PLL support [34/38] ccs-pll: Add support for DDR OP system and pixel clocks [36/38] ccs: Print written register values [37/38] ccs-pll: Print pixel rates

Commit Message

Sakari Ailus Dec. 2, 2020, 6:06 p.m. UTC

This helps debugging register writes.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/i2c/ccs/ccs-reg-access.c | 4 ++++
 1 file changed, 4 insertions(+)

diff mbox series

Patch

diff --git a/drivers/media/i2c/ccs/ccs-reg-access.c b/drivers/media/i2c/ccs/ccs-reg-access.c
index 3de863e3bf26..b776af2a3c33 100644
--- a/drivers/media/i2c/ccs/ccs-reg-access.c
+++ b/drivers/media/i2c/ccs/ccs-reg-access.c
@@ -338,6 +338,10 @@  int ccs_write_addr_no_quirk(struct ccs_sensor *sensor, u32 reg, u32 val)
 	put_unaligned_be16(CCS_REG_ADDR(reg), data);
 	put_unaligned_be32(val << (8 * (sizeof(val) - len)), data + 2);
 
+	dev_dbg(&client->dev, "writing reg 0x%4.4x value 0x%*.*x (%u)\n",
+		CCS_REG_ADDR(reg), ccs_reg_width(reg) << 1,
+		ccs_reg_width(reg) << 1, val, val);
+
 	r = ccs_write_retry(client, &msg);
 	if (r)
 		dev_err(&client->dev,